Closed
Bug 1452737
Opened 7 years ago
Closed 7 years ago
New Tab should use accentcolor to set dark or light background
Categories
(Firefox :: New Tab Page, defect, P3)
Tracking
()
RESOLVED
WONTFIX
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | unaffected |
| firefox61 | --- | wontfix |
People
(Reporter: jgruen, Assigned: jgruen)
References
Details
Attachments
(1 file)
|
128.53 KB,
image/png
|
Details |
Screen Shot 2018-04-09 at 3.02.10 PM.png
Looks like Activity Stream is using the luminance of the browser theme's text color to set the a dark background. This leads to some interesting results for washed-out or pastel themes (see attachment).
It seems like the value for setting a dark theme should be based on the luminance of a theme's accentcolor instead (except when the user has the default theme enabled).
|
||
Updated•7 years ago
|
|
Assignee | |
Comment 1•7 years ago
|
||
Hey I'll do a patch for this since it affects the quality of a Test Pilot experiment
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → jgruen
|
||
Comment 2•7 years ago
|
||
Sounds like design wants new tab dark theme to only apply or the built in dark theme in bug 1454501. Maybe this is wontfix then?
See Also: → 1454501
|
|
Assignee | |
Comment 3•7 years ago
|
||
Yep, just say R1cky's PR for that. Closing this
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•