1454501 - Make NTP dark theme available only for users of the built-in Dark theme

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Ricky Rosario [:rrosario, :r1cky]]

Instead of guessing if theme is dark or light by textcolor, we'll hard code it to only activate on Dark theme (id="[e-mail]").

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4095

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/ee4767547d53c06dfc9dc238f2c44164fe5e9d8e
Fix Bug 1454501 - apply dark theme only to builtin Dark theme

https://github.com/mozilla/activity-stream/commit/2e41605750b3f2132de3610242ee1e0145eb7839
Merge pull request #4095 from rlr/Bug1454501/dark-theme-only

Fix Bug 1454501 - apply dark theme only to builtin Dark theme

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4099

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/7f97e0f7bc713fe498e7fc61d6130bf030f17ba0
Fix Bug 1454501 - followup to ee47675 to handle default theme being undefined

https://github.com/mozilla/activity-stream/commit/fbc8f8cc9ac8a5666d60c93c7e7eb32463cafbb7
Merge pull request #4099 from rlr/followup-dark-switch-fix

Fix Bug 1454501 - followup to ee47675 to handle default theme being undefined

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/4183020e7017

Comment 6

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Build ID 	20180422223305
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0

I have verified that the issue is no longer reproducible on the latest Nightly build on Windows 10 x64, Mac 10.13.3 and Arch Linux x64. The New Tab page dark theme is only triggered when the browser's dark theme is enabled.