Tab warming causes janky tab hover animations

RESOLVED FIXED

Status

()

defect
P3
normal
RESOLVED FIXED
a year ago
10 months ago

People

(Reporter: bdahl, Assigned: mconley)

Tracking

unspecified
Unspecified
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 wontfix, firefox62 wontfix, firefox63 fixed)

Details

(Whiteboard: [fxperf:p1])

Reporter

Description

a year ago
With browser.tabs.remote.warmup.enabled set to true, my tab animations become very laggy/janky on MacOS. It seems to be most notable with pinned tabs.

STR:
- Pin several "heavy" sites (I have gmail, calendar, slack, ircloud)
- Move the mouse across these tabs a couple of times

The hover effect starts to fall behind where the mouse is actually located and I see the top border animation very slowly animate. My CPU usage from Firefox also shoots up to 100%.
Blocks: 1434651
Flags: needinfo?(mconley)
Whiteboard: [fxperf]
Hey bdahl, do things improve if you set browser.tabs.remote.warmup.maxTabs to 1 (and then restart)?
Flags: needinfo?(mconley) → needinfo?(bdahl)
Reporter

Comment 2

a year ago
It's better, but I still see the animation/hover fall behind occasionally.

Not sure if it's helpful, but here a profile with maxTabs at 3: https://perfht.ml/2qq7qRe
Flags: needinfo?(bdahl)
Priority: -- → P3
Whiteboard: [fxperf] → [fxperf:p2]
OS: Unspecified → Mac OS X
Whiteboard: [fxperf:p2] → [fxperf:p1]
Assignee: nobody → mconley
Depends on: 1457276

Comment 3

a year ago
In case they're useful, here's some profiles from my potato-grade 2016 12" MacBook:

Me scrubbing the tab bar with warming enabled: https://perfht.ml/2IszjlO
Me scrubbing the tab bar with warming disabled: https://perfht.ml/2IqQ29i
Depends on: 1353013
No longer depends on: 1353013
Assignee

Comment 4

10 months ago
Hey bdahl, with bug 1265824 having been fixed, I suspect this has probably gotten better. It has for me, anyhow. Can you confirm?
Depends on: 1265824
Flags: needinfo?(bdahl)
Reporter

Comment 5

10 months ago
Yeah, seems very smooth now!
Flags: needinfo?(bdahl)
Assignee

Comment 6

10 months ago
\o/
Status: NEW → RESOLVED
Last Resolved: 10 months ago
No longer depends on: 1457276
Resolution: --- → FIXED
Assignee

Updated

10 months ago
Blocks: 1481519
You need to log in before you can comment on or make changes to this bug.