Closed Bug 1453080 Opened 2 years ago Closed 2 years ago

Tab warming causes janky tab hover animations

Categories

(Firefox :: Tabbed Browser, defect, P3)

Unspecified
macOS
defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- fixed

People

(Reporter: bdahl, Assigned: mconley)

References

Details

(Whiteboard: [fxperf:p1])

With browser.tabs.remote.warmup.enabled set to true, my tab animations become very laggy/janky on MacOS. It seems to be most notable with pinned tabs.

STR:
- Pin several "heavy" sites (I have gmail, calendar, slack, ircloud)
- Move the mouse across these tabs a couple of times

The hover effect starts to fall behind where the mouse is actually located and I see the top border animation very slowly animate. My CPU usage from Firefox also shoots up to 100%.
Blocks: 1434651
Flags: needinfo?(mconley)
Whiteboard: [fxperf]
Hey bdahl, do things improve if you set browser.tabs.remote.warmup.maxTabs to 1 (and then restart)?
Flags: needinfo?(mconley) → needinfo?(bdahl)
It's better, but I still see the animation/hover fall behind occasionally.

Not sure if it's helpful, but here a profile with maxTabs at 3: https://perfht.ml/2qq7qRe
Flags: needinfo?(bdahl)
Priority: -- → P3
Whiteboard: [fxperf] → [fxperf:p2]
Whiteboard: [fxperf:p2] → [fxperf:p1]
Assignee: nobody → mconley
Depends on: 1457276
In case they're useful, here's some profiles from my potato-grade 2016 12" MacBook:

Me scrubbing the tab bar with warming enabled: https://perfht.ml/2IszjlO
Me scrubbing the tab bar with warming disabled: https://perfht.ml/2IqQ29i
Depends on: 1353013
No longer depends on: 1353013
Hey bdahl, with bug 1265824 having been fixed, I suspect this has probably gotten better. It has for me, anyhow. Can you confirm?
Depends on: 1265824
Flags: needinfo?(bdahl)
Yeah, seems very smooth now!
Flags: needinfo?(bdahl)
\o/
Status: NEW → RESOLVED
Closed: 2 years ago
No longer depends on: 1457276
Resolution: --- → FIXED
Blocks: 1481519
You need to log in before you can comment on or make changes to this bug.