1481519 - Enable tab warming by default on macOS

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement)

Description

[Mike Conley (:mconley) (:⚙️)]

Now that bug 1453080 is closed out, we're not dropping frames when hovering tabs when warming, so I think we're good to let warming ride out on release on macOS.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1481519 - Let tab warming ride out to release on macOS. r?florian

Comment 2

[Phabricator Automation]

Comment on attachment 8998282 [details]
Bug 1481519 - Let tab warming ride out to release on macOS. r?florian

Florian Quèze [:florian] has approved the revision.

https://phabricator.services.mozilla.com/D2874

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7d00bd8683f
Let tab warming ride out to release on macOS. r=florian

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Release Note Request (optional, but appreciated)
[Why is this notable]: Makes tab switching on macOS feel faster. This already went out to Windows and Linux in Firefox 61, and now macOS is catching up.
[Affects Firefox for Android]: No.
[Suggested wording]:

Faster tab switching in the majority of cases for our macOS users.

[Links (documentation, blog post, etc)]:

https://mikeconley.ca/blog/2018/01/11/making-tab-switching-faster-in-firefox-with-tab-warming/

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b7d00bd8683f

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Added to 63 nightly notes, for the final release notes, this may be reworded and included in a performance improvements section as we did when we mentioned this feature for Linux and Windows in 61 notes

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Note - I may have jumped the gun here. Letting this ride the trains is conditioned upon the client storage stuff[1] riding the trains as well. I'll see what the state of that is, and then update accordingly.

[1]: https://searchfox.org/mozilla-central/rev/f0c15db995198a1013e1c5f5b5bea54ef83f1049/gfx/thebes/gfxPrefs.h#517-521

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Tracking to make sure we either relnote it for 63 or revert the patch if it shouldn't ride the trains