145331 - get default topic when context is not found in Help

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Ian Oeschger (gone)]

Small patch addresses a lot of the issues we are having with context-sensitive
help (Cf. host of JS exception error bugs, 129540, others). It should always
have been the case, but this update makes sure we get at least the "Welcome"
page (or some other defaults, settable) when the ID given in openHelp is not found.

Comment 1

[Ian Oeschger (gone)]

Attachment: go to default topic

This patch (and ignore the lines in there about RegExp--that's for 130346)
opens the default topic when context-sensitive help is fired up.

Comment 2

[Ian Oeschger (gone)]

Comment on attachment 84101 [details] [diff] [review]
go to default topic

r=oeschger for pwilson's patch

Comment 3

[Ian Oeschger (gone)]

ACCEPTING, adding r=oeschger and cc'ing blake. 
Got a minute, blake? Have a small JS patch in here that I'd like to get in. I
will send reviewer mail to you shortly.

Comment 4

[Ian Oeschger (gone)]

peter wilson comments:
What it really needs is a missingtopic topic on mozillahelp.rdf.  This would
direct calls to missing topics to the missingtopic topic (except when the
missing topic is the missingtopic topic). 

I will see if I can create a little html file for this.

Comment 5

[Ian Oeschger (gone)]

nominating. steve (rudman), can you plus this? Together with 129540, it fixes
the context help.

Comment 6

[Alec Flett]

Comment on attachment 84101 [details] [diff] [review]
go to default topic

sr=alecf

Comment 7

[rudman]

nsbeta1+, setting milestone to moz 1.0.1.

Comment 8

[Scott Collins]

Comment on attachment 84101 [details] [diff] [review]
go to default topic

a=scc for checkin to mozilla1.0.1

Comment 9

[Ian Oeschger (gone)]

Checked in the go-to-welcome-page patch on trunk and branch. keeping this open
for possible go-to-special-page update

Comment 10

[rudman]

Ian, can we close this out for 1.0.1? Or are you planning on checking in
"possible go-to-special-page update" soon? Seems like you'd have to go through
review process again, in which case I suggest opening another bug and closing
this one out after requisiten checkins.

Comment 11

[Ian Oeschger (gone)]

FIXED. I will open up a new bug on default-choosing-enhancements if we go that way.

Comment 12

[Terri Preston]

Verified fix checked into lxr.mozilla.org, marking verified