129540 - Help buttons needed in UI

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Ian Oeschger (gone)]

There are a number of places in the interface that still need help buttons, and
for which there is already specific context-sensitive content.

Comment 1

[Ian Oeschger (gone)]

Attachment: account manager additions

Two new entries in the account manager help, one for a (relatively) new panel,
one for a panel that slipped through the cracks.

Comment 2

[Ian Oeschger (gone)]

Nominating.

Comment 3

[robinf]

Ian, here are the dialogs where I'd like to add a help button, along with the
context id for the button. These are all in Mail/News:

Subscribe dialog: subscribe_list_all
Download and Sync Messages dialog: offline_sync
Message Filters dialog: mail_filters
Filter Rules dialog: mail_filters (yes, points to same place)
Search Messages dialog: search_messages
Advanced Addressbook Search dialog: mail_advanced_ab_search*
Directory Server Properties dialog: mail_ldap_properties*

For Mail/News and Composer, the complete list of all dialogs and context ids is
here: http://jazz/users/robinf/public/machV/mach5context_help.html

*these entries don't yet appear in the TOC or content (will soon, though)

Comment 4

[Ian Oeschger (gone)]

Attachment: help button in news subscribe dialog

Here is the help button in the subscribe dialog. Next one is the two buttons in
the filter dialogs. Have to think a little about the others (and find them).
Robin, perhaps you and I can go over them on Monday, when I will be near a
machine that I can actually build/test these changes with. The search messages
dialog looks a little scary.

Comment 5

[Ian Oeschger (gone)]

Attachment: buttons for filter dialogs

Comment 6

[rudman]

Adding nsbeta1+.

Comment 7

[robinf]

Advanced Addressbook Search dialog: mail_advanced_ab_search

Directory Server Properties dialog: mail_ldap_properties

Note: Changes I'll check in tonight will include entries in TOC and content for
these buttons. This will complete all hooks into TOC and content for Mail/News
and Composer help buttons.

Comment 8

[Ian Oeschger (gone)]

Attachment: help button for offline dialog

offline_sync button added in this patch to msgSelectOffline.xul

Comment 9

[Ian Oeschger (gone)]

Attachment: button for search dialog

Comment 10

[Ian Oeschger (gone)]

Attachment: replacement patch adds ABSearchDialog.xul

This update includes the addressbook button, which also uses SearchDialog.dtd
for its string.

Comment 11

[Ian Oeschger (gone)]

Attachment: replacement for search dialogs

eek! Didn't see the layout problems with the updates I made in the previous
version of searchdlog.diff. Here are the Help buttons correctly placed in
searchdialog and absearchdialog

Comment 12

[Ian Oeschger (gone)]

Attachment: directory server help button

K, I think that's it for the mail buttons that need to be added. Bhuvan, you
want to take a look at these and put your seal of approval on them if they look
OK?

Comment 13

[Sean Cotter]

The help buttons for the Security panels of Mail & Newsgroup Account Settings
currently point to the wrong place (top of mail_help.html).

The correct target ID (same for both mail and newgroup Security panels) is
"mail_security_settings".

Comment 14

[racham]

Looks good. r=bhuvan.

* Can you repost the patch for offline dialog ? You may want to pull a new file
and then apply your changes before taking diffs on that file.

* Can you also post a screenshot of SearchDialog ?

Comment 15

[robinf]

Ian, two new help buttons are needed for the Prefs panel. They are:

Preferences>Mail&Newsgroups>Labels panel
Preferences>Mail&Newsgroups>Return Receipts panel

I'll post more info in this bug as soon as I have it. 

Comment 16

[rudman]

Setting milestone.

Comment 17

[robinf]

Preferences>Mail&Newsgroups>Labels panel

Context ID (from TOC) is mail-prefs-labels

Comment 18

[Ian Oeschger (gone)]

Working on labels one now. Robin, I don't see the Return Receipts panel in my
build. How new is that?

Comment 19

[robinf]

Return Receipts was checked in last Thursday, I think. I'm using this morning's
build and I see the prefs.

Preferences>Mail&Newsgroups>Return Receipts panel

Use this Context ID: mail-prefs-receipts

Please note that I haven't yet updated the TOC and mail_help.html with topic
headings. I'm working on that today. But if you need to check this in before I
update the TOC and mail_help.html, you can use the above ID and then it should
just work when I check in my updates. Thanks.

Comment 20

[Ian Oeschger (gone)]

Attachment: Help button for Preferences->Mail&Newsgroups->Labels

Comment 21

[Ian Oeschger (gone)]

Attachment: label *and* return receipt pref panel help buttons

K, found them both. This patch adds context-sensitive help for
prefs->m&n->labels and prefs->m&n->return receipts

Comment 22

[Jatin Billimoria]

This is the TOC entry that needs to be hooked up to the default browser dialog box:

  <rdf:Description about="#nav-doc-ses">
    <nc:subheadings>
      <rdf:Seq>
        <rdf:li> <rdf:Description ID="nav-doc-default" nc:name="Making Netscape
Your Default Browser" nc:link="chrome://help/locale/nav_help.html#nav_default"/>
</rdf:li>
      </rdf:Seq>
    </nc:subheadings>
  </rdf:Description>

The default browser dialog box appears when the users first install and Netscape
is not the default browser. Later it is displayed when another application has
taken over for Netscape and the user wants to be notified of such a change.

Comment 23

[Ian Oeschger (gone)]

Attachment: restoring help button to Account Manager

restores help button and fixes regression from converting the am window to a
dialog.

Comment 24

[robinf]

re: my comment #19: I just checked in updates to help-toc.rdf and mail_help.html
(to commercial trunk) for the Return Receipt pref panel help button. So when you
check in your patches, the help button in this new prefs panel should point to
the correct location in help. Thanks.

Comment 25

[Ian Oeschger (gone)]

Attachment: updates for all the mailnews buttons

This patch is an update for all the mailnews account manager buttons, post
window->dialog updates in tree last week.

Comment 26

[Ian Oeschger (gone)]

Attachment: this is an update for the label and return receipt pref panels

Patch adds help buttons for label and return receipt panels in prefs->mailnews.
Not even sure if I needed this update, but went back through and redid
everything after the large window->dialog update in mozilla.

Comment 27

[Ian Oeschger (gone)]

Attachment: screenshot of search dialog

screenshot per Bhuvan's request. Bhuvan, would you mind going back through and
reviewing this new patch, which contains all of the buttons for mailnews? Note
the following: I have a boo-boo in there; consider that repeated ondialogcancel
attribute out:
+	 ondialogcancel="return subscribeCancel();"
+	 ondialogcancel="return subscribeCancel();"

Comment 28

[robinf]

Just realized we need a new Help button hooked up for new Return Receipts panel
that appears in Mail/News Account Settings. Apologies for not catching this
yesterday.

Mail/News Account Settings>Return Receipts (new panel)

New context ID needed: mail-account-receipts

I need to check in updates to help-toc.rdf and mail_help.html so that this new
ID will work. I'll update this bug once that's done.

Comment 29

[Ian Oeschger (gone)]

Attachment: adding help for am->return receipts

adding am-mdn.xul to the list of subframes that have a help context in the
account manager.

Comment 30

[Jatin Billimoria]

Here are the Navigator-related help buttons that need to be hooked up for MachV
(including one regarding the default browser dialog box):

----------------------------------------
Preferences->Navigator->Tabbed Browsing

<rdf:li> <rdf:Description ID="nav-doc-tabbed" nc:name="Using Tabbed Browsing" 
nc:link="chrome://help/locale/nav_help.html#nav_tabbed_browsing"/> </rdf:li>

----------------------------------------
Preferences->Advanced->Scripts & Windows

<rdf:Description ID="advanced_pref_scripts" nc:name="Scripts &amp; Windows"
nc:link="chrome://help/locale/cs_nav_prefs_advanced.html#Scripts"/> </rdf:li>

----------------------------------------
Default Browser Dialog Box: "Netscape 6 is not currently set as your default
browser. Would you like to make it your default browser?"

<rdf:li> <rdf:Description ID="nav-doc-default" nc:name="Making Netscape Your
Default Browser" nc:link="chrome://help/locale/nav_help.html#nav_default"/>
</rdf:li>

----------------------------------------
Preferences->Navigator->Downloads**

<rdf:Description ID="navigator_pref_downloads" nc:name="Downloads"
nc:link="chrome://help/locale/cs_nav_prefs_navigator.html#downloads"/> </rdf:li>

**This panel, "Downloads," is not present in the current builds because it is
being reconsidered. However, I have already created pref. help for this
preference, in case it returns.

----------------------------------------

Comment 31

[Ian Oeschger (gone)]

Attachment: browser updates for jatin

this patch includes some overlap with some of the previous patches, but has
tabbed browsing and scripts & windows, though not the default browser dialog,
because that is something I'll have to discuss more with [e-mail], and
not the download one, since the file I would have to base this on is not around
yet.

Comment 32

[racham]

r=bhuvan on patch id #77260.

Comment 33

[rudman]

Marking adt1. 

Comment 34

[Jatin Billimoria]

A reminder for Ian regarding new help button that needs to be hooked up for the
HTTP Networking pref:

<rdf:Description ID="advanced_http_networking" nc:name="HTTP Networking"
  		

Comment 35

[Ian Oeschger (gone)]

Attachment: adding http networking to list of panels that have help context

Comment 36

[Ian Oeschger (gone)]

note: attachments 79003, 89047, 77173, and 77273 are NEW buttons that need to be
added to the UI. 77172, the first not-obsolete attachement in this list, has the
fixes for the Account Manager dialog regressions, but it also has some new stuff
for mailnews: the search dialog button, the search addressbook buttons, the
filter dialog button, and so on. Unfortunately, that large patch is a mix of new
buttons and fixes, but it needs to be super-reviewed (and has, I think, already
been reviewed by bhuvan). 77260 is a screenshot of the fix in that patch.

Comment 37

[scottputterman]

Let's get this in for RTM.

Comment 38

[Ian Oeschger (gone)]

Attachment: im help button additions

additional context for IM help buttons: buddy icons and style prefs panels

Comment 39

[Sean Cotter]

One more fix needed. The help button for "Server Certificate Not Yet Valid"
currently targets "exp_web_cert", which brings up the Help content for "Server
Certificate Expired".

Instead, the help button target for the "Server Certifidate Not Yet Valid"
dialog should be "not_yet_web_cert". 

To see this dialog, set your computer clock back to 1997 and go to
https://certs.netscape.com.

Comment 40

[andreww]

Comment on attachment 80717 [details] [diff] [review]
im help button additions

r=andreww

Comment 41

[Ian Oeschger (gone)]

Andrew! Dude! I need a review of the BIG patch--77172 in this bug, where all of
the help buttons for the mailnews UI are created/updated. Thanks for taking a
look at that one (and thanks for checking out the latest IM addition too).

Comment 42

[racham]

Ian,

Sorry, got delayed in gettnig back on this one..

Looking at the mailnews patch (77172), I have found one item that we may need 
to fix.

In 

RCS 
file: /cvsroot/mozilla/mailnews/base/search/resources/content/ABSearchDialog.xul
,v

help button (code pasted below) is going to bring up help window for searching 
messages where as user is really searching for addresses in this dialog

+           <button label="&helpButton.label;" align="end" oncommand="openHelp
('search_messages');" accesskey="&helpButton.accesskey;"/> 

Is the page corresponding to search messages has a search addresses section..? 
If so, do you resolve this command to show that section..?

Rest looks fine.

Comment 43

[Ian Oeschger (gone)]

Robin--Do you want to comment about this? I think I have mapped all the content
keys you have in the spec to the right buttons, but maybe this one is wrong, or
maybe there is some more specific place to send the reader to? Thanks, Bhuvan!

Comment 44

[robinf]

Please use 

Description ID="mail_ab_search", 

which will display "Searching Address Books" section of online help. Thanks.

Comment 45

[racham]

Cool !. Ian, you can make that change on your tree before checking in and no
need to post a new patch just for that (if you want to, you can do so for
records). Thanks Robin.

r=bhuvan

Comment 46

[robinf]

Apologies, please scratch my last comment #44. 

Please use Description ID="mail_advanced_ab_search" 

which will display "Searching for Specific Entries" in online help. Thanks.

Comment 47

[Ian Oeschger (gone)]

Right on! Thanks both of you. Just need a superreview and we can go in with this.

Comment 48

[Ian Oeschger (gone)]

Attachment: svelte button additions for mailnews

Replacing attachment 77172 [details] [diff] [review] with a slightly refreshed version. This one does not
include the Filter dialogs (which I will patch separately) and has a key update
from robin for the subscribe dialog. Wanted to make sure my work hadn't rotted.
I feel certain we can say that Bhuvan's review still obtains.

Comment 49

[Ian Oeschger (gone)]

Attachment: adds context for new panels in mozilla

refreshed. This patch takes care of some button->content needs for help
authors, and also addresses the bugs listed below (though not, in every case,
by pointing to related content: there is no content for the debug panels or for
the dom inspector, so I am starting up help with the welcome page for now).

138920 
138921 
138922 
138924 
138925 
138926 
138927 
138928 
138929

Comment 50

[Ian Oeschger (gone)]

Comment on attachment 77273 [details] [diff] [review]
adding help for am->return receipts 

Marking OBSOLETE. Attachment 83596 [details] [diff] ("svelte") also includes this new entry.

Comment 51

[Alec Flett]

Comment on attachment 83596 [details] [diff] [review]
svelte button additions for mailnews

sr=alecf, but the mechanism by which you add the mdn and smime help buttons
should probably be reworked at some point - these are both extensions that may
or may not be in the UI - what are you going to do if some 3rd party adds a new
page? your system needs to be extensible so that 3rd parties can hook into your
mechanism.

Comment 52

[Ian Oeschger (gone)]

Checked in mailnews/am fixes from attachment 83604 [details] [diff] [review] on trunk. Not closing this
yet because we have other help button additions here (but adding adt1.0.0
keyword for consideration on branch).

Comment 53

[Ian Oeschger (gone)]

Bhuvan - Now that we've got the mailnews buttons checked in and I've organized
things in this bug a little better, do you think you could take a look at this
most recent patch update (83604)? It's for new panels in preferences, very
similar to the last one. Thanks a lot!

Comment 54

[racham]

pref-inspector.xul is going to welcome page..? Is that intentional..? 

Comment 55

[Ian Oeschger (gone)]

For now it is. We don't have any content yet on inspector. I suppose another way
to do it would be to use a key like "inspector" that doesn't go anywhere now,
but which could be hooked up on the content side later. Or I could even do an
<h1>Inspector - Write me!</h1> in the mozilla content and have this actually go
somewhere. hmm...let me do that instead. It will save trouble updating next time.

Comment 56

[Ian Oeschger (gone)]

Just created bug 145056 to put a new section in the Mozilla Help TOC, which I
can then link to from spots in the UI like the Inspector panel, which don't
appear in the commercial builds. Thanks for making me think this through, Bhuvan.

Comment 57

[Ian Oeschger (gone)]

Attachment: update for new button context

This update adds real keys for the mozilla panels: dom inspector, the debugs.

Comment 58

[racham]

Comment on attachment 83972 [details] [diff] [review]
update for new button context

r=bhuvan

Comment 59

[scottputterman]

adding adt1.0.0+.  Please get drivers approval before checking into the 1.0 branch.

Comment 60

[Ian Oeschger (gone)]

Creating dependency on new bug to set default topic correctly for buttons that
don't have proper context, 145331. 

Comment 61

[Ian Oeschger (gone)]

adding dependency to the new TOC piece in Mozilla, bug 145056. 

Comment 62

[scottputterman]

changing to adt1.0.1+ for checkin to the 1.0 branch.  Please get drivers
approval before checking in.

Comment 63

[Alec Flett]

Comment on attachment 83972 [details] [diff] [review]
update for new button context

sr=alecf

Comment 64

[Scott Collins]

Comment on attachment 83972 [details] [diff] [review]
update for new button context

a=scc for checkin to mozilla1.0.1

Comment 65

[Ian Oeschger (gone)]

Checked in prefwindow updates (attachment 83972 [details] [diff] [review]) on trunk and branch. Keeping
this bug open to collect new IDs if necessary.

Comment 66

[Ian Oeschger (gone)]

Attachment: help context keys for IM and ICQ

Comment 67

[robinf]

The "Items for Offline Use" dialog has a help button (I wasn't aware of it) and
so consequently it's Help button is not hooked up.

Steps to reproduce:

In the Mail window, open the File menu and choose Offline, then choose
Download/Sync Now.
Click the Select button.
In the "Items for Offline Use" dialog, click the Help button.
The Help viewer opens, but the content pane is blank

The correct context ID to use here is mail-offline-items.

Comment 68

[robinf]

Attachment: Items for Offline Use dialog

Items for Offline Use dialog (help button not hooked up)

Comment 69

[Alec Flett]

Comment on attachment 86106 [details] [diff] [review]
help context keys for IM and ICQ

sr=alecf

Comment 70

[Asa Dotzler [:asa]]

Comment on attachment 86106 [details] [diff] [review]
help context keys for IM and ICQ

a=asa (on behalf of drivers) for checkin to the 1.1 trunk.

Comment 71

[Ian Oeschger (gone)]

Checked in IM and ICQ button keys on trunk. Baking now...

Comment 72

[Ian Oeschger (gone)]

Attachment: adding tabbed browsing and download button keys

Comment 73

[Ian Oeschger (gone)]

Attachment: imports the contextHelp script needed to call openHelp

attachment 73885 [details] [diff] [review]
(http://bugzilla.mozilla.org/attachment.cgi?id=73885&action=view) was
incomplete (but went in and created a disabled Help button). This patch fixes
the problem Robin identifies in attachment 83615 [details] [diff] [review], comment 30. Need this checked
in ASAP.

Comment 74

[andreww]

Comment on attachment 86751 [details] [diff] [review]
imports the contextHelp script needed to call openHelp

r=andreww

Comment 75

[Alec Flett]

Comment on attachment 86751 [details] [diff] [review]
imports the contextHelp script needed to call openHelp

sorry for the delay!
sr=alecf

Comment 76

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 86751 [details] [diff] [review]
imports the contextHelp script needed to call openHelp

Please land this on the 1.0.1 branch.  Once there, remove the
"mozilla1.0.1+" keyword, and add the "fixed1.0.1"

Comment 77

[Ian Oeschger (gone)]

Marking FIXED

Comment 78

[robinf]

Using June 17-08-1.0 build, I've noticed the following issues:

Account Setting dialog:
*Local Folders Help button opens to Help home page (should open to Mail &
Newsgroup Account Settings - Local Folders, ID = mail_local_folders_settings)

Other dialogs:
*Items for Offline Use dialog Help button opens to Help home page (should open
to "Selecting Items for Offline Viewing", ID = mail-offline-items)

*Filter Rules dialog: right side of this dialog is truncated so I can't see the
Help button, and I can't verify that it points to the correct place.

*Advanced Addressbook Search dialog Help button points to wrong place. Should
point to "Searching for Specific Entries", ID = mail_advanced_ab_search.

*Message Filters dialog box Help button is missing.

*Directory Server Properties dialog box Help button is missing. 

Comment 79

[robinf]

In June 17-07-trunk, I observed the same issues in my previous comment except that:

*Directory Server Properties dialog box Help button appears, but it points to
the Help home page.

Comment 80

[Jatin Billimoria]

In the 20020617 branch build, the help button for Navigator > Tabbed Browsing
incorrectly reverts to the Help and Support Center home page. Will check trunk
build shortly.

Comment 81

[Jatin Billimoria]

Same issue as in Comment #80 for the trunk build.

Comment 82

[John Gorham]

The button for the Connection preference in ICQ is not working.

Comment 83

[Sean Cotter]

I have tracked down the problems with the following broken Navigator and ICQ
help buttons. The solutions noted are required on both trunk and branch.

Navigator/Tabbed Browsing: ID in patch doesn't match help-toc.rdf. I will fix in
the latter.

ICQ/Notification & Sounds: ID in patch doesn't match help-toc.rdf. I will fix in
the latter.

ICQ/Connection: ID in patch is a copy and paste error. Since the copied ID
already exists in help-toc.rdf, this needs to be fixed as follows. 

In the file
/cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-help.js, this
line:

"chrome://aim/content/pref-Icq_connection.xul": "im_prefs_connection",

should be changed to this:

"chrome://aim/content/pref-Icq_connection.xul": "icq-prefs-connection",

The above change needs to be incorporated into another patch that also addresses
 the problems Robin describes with the mail dialogs.

Comment 84

[Navin Gupta]

I have a patch to make Jatin's Navigator issue and I was working on robinf's
mail issues. 

Comment 85

[Navin Gupta]

robin, where should this point to ?

*Directory Server Properties dialog box Help button is missing. 

Comment 86

[robinf]

Directory Server Properties Help button should use this context ID:

mail-ldap-properties

which references this heading in the mail Help: "Directory Server Settings"

Comment 87

[Navin Gupta]

Attachment: patch fixing jatin's and robin's comments

This patch fixes all the issues raised. I have left ICQ changes for sean, since
he figured out what was wrong before I did. 

The changes are pretty straightforward, adding help buttons whereever needed
and hooking them upto the help. 

bhuvan, Can I get r=? thx.

Comment 88

[Sean Cotter]

As noted above, there is still one ICQ fix (ICQ/Connection) that must be made on
the help button
side (as part of Navin's patch). It can't be fixed in the TOC because the ID
referenced by the help button already exists in the TOC for a different help
section.

In the file
/cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-help.js, this
line:

"chrome://aim/content/pref-Icq_connection.xul": "im_prefs_connection",

should be changed to this:

"chrome://aim/content/pref-Icq_connection.xul": "icq-prefs-connection",

I can make the other ICQ fix in the TOC itself.

Comment 89

[Navin Gupta]

Right now we have this on the mozilla trunk

  "chrome://aim/content/pref-Icq_connection.xul": "icq_prefs_connect"

Is this correct ?

Comment 90

[Sean Cotter]

Sorry, you are right.

"chrome://aim/content/pref-Icq_connection.xul": "icq_prefs_connect",

is correct. It should be on the branch as well as the trunk.

Comment 91

[Navin Gupta]

Andrew, can you review the last patch ? thx. 

Comment 92

[racham]

-  "chrome://messenger/content/am-offline.xul": "mail-offline-sync",
+  "chrome://messenger/content/am-offline.xul": "mail-offline-accounts",

AND

 function doHelpButton() 
 {
-    openHelp("offline_sync");
+    openHelp("mail-offline-items");
 }

Don't they ned to be in Sync ?  It got to be either "mail-offline-items" or
"mail-offline-accounts". If both of them need to be around where are they used..?

Bhuvan

Comment 93

[racham]

ned to be --> need to be

Comment 94

[Navin Gupta]

No, they don't need to be in sync because they are both for different things.
One is for account manager | setting up accounts for offline use. The other is for 
selecting folders to use for offline. 

Comment 95

[racham]

Comment on attachment 88203 [details] [diff] [review]
patch fixing jatin's and robin's comments

OK. I think we need comments on all these openHelp('foo')  calls.

Anyway, patch looks good. r=bhuvan

Comment 96

[Navin Gupta]

Alec, Can you sr the last patch? thx.

Comment 97

[Alec Flett]

Comment on attachment 88203 [details] [diff] [review]
patch fixing jatin's and robin's comments

sr=alecf

Comment 98

[Navin Gupta]

last patch landed on trunk.

Comment 99

[robinf]

Using June 21-09 trunk build, most of the mail help button issues are fixed
(thanks Navin!) but two still require attention:

Filter Rules dialog: This dialog is still chopped off on the right side (see
screen shot to follow) but now I can see the Help button. Clicking Help opens to
"Filtering Messages from a Specific Sender", which is incorrect. The correct
context ID is: mail_filters (which opens to "Creating Message Filters").

Directory Server Properties dialog: The Help button opens to the help home page.
Instead, it should open to "Directory Server Settings", context ID =
mail_ldap_properties.

To summarize what's left to fix:

Filter Rules dialog Help button context ID: mail_filters
Directory Server Properties dialog Help button context ID: mail_ldap_properties

Comment 100

[robinf]

Attachment: Truncated filter rules dialog

Comment 101

[robinf]

Correction to my previous comments:

Filter Rules dialog Help button context ID: mail-filters

Directory Server Properties dialog Help button context ID: mail-ldap-properties

I apologize, I didn't know that these context IDs had been changed to use dashes
instead of underscores.

Comment 102

[Navin Gupta]

>Directory Server Properties dialog Help button context ID: mail-ldap-properties. 
This is how it is right now and it worksforme on current trunk builds.

>Filter Rules dialog Help button context ID: mail-filters
I made it so that Filter-List dialog points to mail-filters. How can Filter Rules
dialog also point to the same place ? doesn't seem right to me. 

Comment 103

[robinf]

I tried all three commercial trunk builds from this morning, and I see the
incorrect behavior in all of them. The Directory Server Properties dialog Help
button points to the Help home page, instead of to "Directory Server Settings".

Yes, the Filter Rules dialog Help button should point to the same place as the
Messag Filters dialog - this is intentional. Thanks.

Comment 104

[Navin Gupta]

>I tried all three commercial trunk builds from this morning, and I see the
>incorrect behavior in all of them. The Directory Server Properties dialog Help
>button points to the Help home page, instead of to "Directory Server Settings".

I am talking about this dialog Edit | Preferences | Mail & Newsgroups |
Addressing | Edit Directories | Ldap Directory Servers. This does point to
"Directory Server Settings " on trunk Mozilla/5.0 (Windows; U; Windows NT 5.0;
en-US; rv:1.1a+) Gecko/20020621 Netscape/7.0b1+ 

I will change the filter rules. 

Comment 105

[robinf]

>I am talking about this dialog Edit | Preferences | Mail & Newsgroups |
>Addressing | Edit Directories | Ldap Directory Servers. This does point to
>"Directory Server Settings " on trunk Mozilla/5.0 (Windows; U; Windows NT 5.0;
>en-US; rv:1.1a+) Gecko/20020621 Netscape/7.0b1+ 

Yes, you are correct! However, look at the Directory Server Properties dialog:
Window | Address Book | (select an LDAP server from the list on the left) |
click Properties button. You see the Directory Server Properties dialog with
General, Offline, and Advanced Tabs. Click Help and you'll see that it points to
the help home page. It should point to the same place as the above dialog ("LDAP
Directory Server" dialog you describe above, which uses Help button context ID
mail-ldap-properties.) Hope this helps. 

Comment 106

[Navin Gupta]

Attachment: patch fixes these 2 issues

Robin, Can you review these changes ? thx. They are basically changind IDs.

Comment 107

[Navin Gupta]

Attachment: patch fixes these 2 issues

Robin, Can you review these changes ? thx. They are basically changing IDs.

Comment 108

[robinf]

r=robinf on the ID changes. Thanks again Navin!

Comment 109

[Navin Gupta]

I have landed both the patches on trunk and branch.

Comment 110

[robinf]

In today's branch build (Jun23-08-1.0) I have verified that the Filter Rules
dialog  and the Directory Server Properties dialog Help buttons point to the
correct place in Help. Thanks.

By the way, the Filter Rules dialog is truncated on the right side. You have to
manually resize it to display the complete dialog. I'll log a separate bug on this.

Comment 111

[robinf]

Bug 153943 filed for truncated Filter Rules dialog.

Comment 112

[Terri Preston]

Just a few comments from the QA ;-)This was using win xp branch build 2002070908

I still see the problem mentioned in comment 39, Help comes up with content
regarding certificate expired (instead of not yet valid)

Then the ICQ help dialogs are not coming up correctly (with the title of the
help content referenced on top and content right below) Seems about two-three
lines too low  

ICQ Away dialog comes up as Help and Support Center

So I'll wait to hear from you guys on whether to reopen, remove fixed1.0.1
(Hopefully just a few minor changes and I can verify)

Thanks for all your hard work on this bug

Comment 113

[rudman]

Terri, thanks for your comments. 

I'd leave this bug alone and open separate ones for the issues you describe. 

Comment 114

[Terri Preston]

New bugs created are 156760, 156762, 156763

Comment 115

[Terri Preston]

The new bugs cover any open issues in this bug, marking verified1.0.1

Comment 116

[Brant Gurganus]

v