Closed Bug 1453383 Opened 5 years ago Closed 5 years ago

Enable ESLint for devtools/client/{webaudioeditor,webide}/

Categories

(DevTools :: General, enhancement)

Product:
DevTools
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox61 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(2 files)

Bug 1453383 - Automatically fix ESLint issues in devtools/client/{webaudioeditor,webide}/.
59 bytes, text/x-review-board-request
jdescottes
: review+
Details
Bug 1453383 - Enable ESLint for devtools/client/{webaudioeditor,webide}/.
59 bytes, text/x-review-board-request
jdescottes
: review+
Details 
These files are currently ignored for ESLint.

Similar to bug 1451659, we should work on enabling at least some coverage, so that we have basic syntax and various rule checks.

Rules that aren't quick-fixes or easy to do can be done in follow-up bugs, thanks to being able to selectively apply rules via glob-based configurations.
Comment on attachment 8967057 [details]
Bug 1453383 - Enable ESLint for devtools/client/{webaudioeditor,webide}/.

https://reviewboard.mozilla.org/r/235716/#review241976

Thanks Mark! Looks good, just one small comment.

::: devtools/client/webide/content/details.js
(Diff revision 2)
>    }
>  
>    AppManager.update("details");
>  }
> -
> -function removeProject() {

removeProject is a callback used in devtools/client/webide/content/details.xhtml
Attachment #8967057 - Flags: review?(jdescottes) → review+
Comment on attachment 8967056 [details]
Bug 1453383 - Automatically fix ESLint issues in devtools/client/{webaudioeditor,webide}/.

https://reviewboard.mozilla.org/r/235714/#review241986
Attachment #8967056 - Flags: review?(jdescottes) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/61c06428ee96
Automatically fix ESLint issues in devtools/client/{webaudioeditor,webide}/. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/166b59bcb4ce
Enable ESLint for devtools/client/{webaudioeditor,webide}/. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/61c06428ee96
https://hg.mozilla.org/mozilla-central/rev/166b59bcb4ce
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox61: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.