1453383 - Enable ESLint for devtools/client/{webaudioeditor,webide}/

Status: RESOLVED FIXED

(DevTools :: General, enhancement)

Description

[Mark Banner (:standard8)]

These files are currently ignored for ESLint.

Similar to bug 1451659, we should work on enabling at least some coverage, so that we have basic syntax and various rule checks.

Rules that aren't quick-fixes or easy to do can be done in follow-up bugs, thanks to being able to selectively apply rules via glob-based configurations.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1453383 - Automatically fix ESLint issues in devtools/client/{webaudioeditor,webide}/.

Review commit: https://reviewboard.mozilla.org/r/235714/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/235714/

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1453383 - Enable ESLint for devtools/client/{webaudioeditor,webide}/.

Review commit: https://reviewboard.mozilla.org/r/235716/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/235716/

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8967057 [details]
Bug 1453383 - Enable ESLint for devtools/client/{webaudioeditor,webide}/.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/235716/diff/1-2/

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8967057 [details]
Bug 1453383 - Enable ESLint for devtools/client/{webaudioeditor,webide}/.

https://reviewboard.mozilla.org/r/235716/#review241976

Thanks Mark! Looks good, just one small comment.

::: devtools/client/webide/content/details.js
(Diff revision 2)
>    }
>  
>    AppManager.update("details");
>  }
> -
> -function removeProject() {

removeProject is a callback used in devtools/client/webide/content/details.xhtml

Comment 5

[Julian Descottes [:jdescottes]]

Comment on attachment 8967056 [details]
Bug 1453383 - Automatically fix ESLint issues in devtools/client/{webaudioeditor,webide}/.

https://reviewboard.mozilla.org/r/235714/#review241986

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 8967056 [details]
Bug 1453383 - Automatically fix ESLint issues in devtools/client/{webaudioeditor,webide}/.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/235714/diff/1-2/

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 8967057 [details]
Bug 1453383 - Enable ESLint for devtools/client/{webaudioeditor,webide}/.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/235716/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61c06428ee96
Automatically fix ESLint issues in devtools/client/{webaudioeditor,webide}/. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/166b59bcb4ce
Enable ESLint for devtools/client/{webaudioeditor,webide}/. r=jdescottes

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/61c06428ee96
https://hg.mozilla.org/mozilla-central/rev/166b59bcb4ce