Enable ESLint for devtools/client/{webaudioeditor,webide}/

RESOLVED FIXED in Firefox 61

Status

enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

(Blocks 1 bug)

Trunk
Firefox 61
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(2 attachments)

These files are currently ignored for ESLint.

Similar to bug 1451659, we should work on enabling at least some coverage, so that we have basic syntax and various rule checks.

Rules that aren't quick-fixes or easy to do can be done in follow-up bugs, thanks to being able to selectively apply rules via glob-based configurations.
Comment hidden (mozreview-request)

Comment 4

a year ago
mozreview-review
Comment on attachment 8967057 [details]
Bug 1453383 - Enable ESLint for devtools/client/{webaudioeditor,webide}/.

https://reviewboard.mozilla.org/r/235716/#review241976

Thanks Mark! Looks good, just one small comment.

::: devtools/client/webide/content/details.js
(Diff revision 2)
>    }
>  
>    AppManager.update("details");
>  }
> -
> -function removeProject() {

removeProject is a callback used in devtools/client/webide/content/details.xhtml
Attachment #8967057 - Flags: review?(jdescottes) → review+

Comment 5

a year ago
mozreview-review
Comment on attachment 8967056 [details]
Bug 1453383 - Automatically fix ESLint issues in devtools/client/{webaudioeditor,webide}/.

https://reviewboard.mozilla.org/r/235714/#review241986
Attachment #8967056 - Flags: review?(jdescottes) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 8

a year ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/61c06428ee96
Automatically fix ESLint issues in devtools/client/{webaudioeditor,webide}/. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/166b59bcb4ce
Enable ESLint for devtools/client/{webaudioeditor,webide}/. r=jdescottes

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/61c06428ee96
https://hg.mozilla.org/mozilla-central/rev/166b59bcb4ce
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61

Updated

a year ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.