145341 - no mail counter with automatic download

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Todd]

Hi All,

    In my Mail server settings, if I check the automatic download, I
loose the "Receiving 20 of 50" counter at the bottom of the screen.
(This down not occure if I download messages manually by clicking
"Get Msgs".)  I am using 1.0.0.2002050408 on Win NT.

Many thanks,
--Tony
[e-mail]

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

POP3, IMAP?

Comment 2

[Todd]

pop3

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

Confirming with Windows 2000 and the commercial 2002-05-20 1.0 mozilla branch build.

qatest36, set to biff every 1 minute, password saved, 2 messages.
pref of 'automatically download news messages' was checked.

setting bug status to new, over to Sheela.  I think this is part of GetMsgs and
not biff, let me know if it's my bug, Sheela.  Thanks!

Comment 4

[Sheela Ravindran]

Reporter,
Can you be more clear as to what you mean by automatic download?  
Do you have both Check for new messages every [n] minutes
And Autmatically download any new messages both checked in your preference?

Comment 5

[Todd]

Hi Sheela,

   Under the server settings, I have the following checked:

--- Check for new mail at startup
--- Check for new messages every 2 minutes
--- Automatically download any new messages

   My (eMail) password is not saved.

    Looking over my original post, I should have worked on the wording a 
bit longer.  Here is the problem.  When I open my eMail windows, the 
eMail program tries to poll my pop server.  It asks me for a password.  I 
enter the password.  The eMail program proceeds to download my new 
messages -- without the counter at the bottom of the windows that tells 
me "Receiving 10 or 25".

   Now, if I blast off a bunch of test messages to myself and click on "Get 
Msgs" before the two minute poll kicks off, I do get the "Recieving x of 
y" counter.

   So, manual downloads gives me the "Receiving x of y", but automatic does not.

Many thanks,
---Tony 
[e-mail]

Comment 6

[Navin Gupta]

David, can I get r=? for upcoming patch, thx (I don't see cavin around)

Comment 7

[Navin Gupta]

Attachment: proposed fix

The fix is to pass valid msgWindow when we are doing pop3 download on biff. So
I had to change that !msgWindow -> must be doing a biff. Not passing msgWindow
also causes other problems like you cannot stop download and no alerts will pop
up if there are errors.

Comment 8

[Sheela Ravindran]

Reporter,
Thanks for the info.  Now it is clear that we don't show the status when biff
retrieves messages vs a manual get message does show the status.  

Comment 9

[David :Bienvenu]

we don't want to display error messages when biffing. I take it this fix makes
it so that we do? that's undesirable.

Comment 10

[Navin Gupta]

But this is on automatic download on biff. We are writing to Inbox and there
could be an overflow because of less disk space etc. we still pass null
msgWindow for new mail check on biff.

Comment 11

[Navin Gupta]

*** Bug 145946 has been marked as a duplicate of this bug. ***

Comment 12

[David :Bienvenu]

Comment on attachment 84516 [details] [diff] [review]
proposed fix

I misunderstood your comments, sorry.

all you need here is this line:
+	    server->SetPerformingBiff(PR_FALSE);  //biff is over

you don't need to check if we were performing biff earlier; it's a bit like
saying 

if (bool)
  bool = false;

instead of just

bool = false;

other than that, it looks fine.

Comment 13

[Navin Gupta]

Attachment: patch with david's changes

Comment 14

[Navin Gupta]

Cavin, can I get r=? thx.

Comment 15

[Cavin Song]

Comment on attachment 84534 [details] [diff] [review]
patch with david's changes

r=cavin.

Comment 16

[David :Bienvenu]

Comment on attachment 84534 [details] [diff] [review]
patch with david's changes

sr=bienvenu

Comment 17

[Navin Gupta]

fixed

Comment 18

[Gilles Durys]

It seems that this has fixed bug 123812

Comment 19

[Navin Gupta]

We should take this bug because it fixes other problems as in bug 123812

Comment 20

[Sheela Ravindran]

Verified auto download shows the status of x of y downloading in the status 
bar while downloading messages
Commercial Trunk builds: 2002-05-28-08 on mac os x, win98, linux rh 6.2

Comment 21

[Sheela Ravindran]

*** Bug 148880 has been marked as a duplicate of this bug. ***

Comment 22

[scottputterman]

nsbeta1+ because it fixes 123812 which is to make the mail throbber animate
correctly.

Comment 23

[Jaime Rodriguez, Jr.]

adt1.0.1+ (on ADT's behalf) approval for checkin to the 1.0 branch, pending
Driver's approval. Pls check this in tonight, and add the fixed1.0.1 keyword.

Comment 24

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 84534 [details] [diff] [review]
patch with david's changes

please check into the 1.0.1 branch ASAP. once landed remove the 
mozilla1.0.1+ keyword and add the fixed1.0.1 keyword

Comment 25

[[e-mail] (gone - use [e-mail] instead)]

Using the testcase in http://bugzilla.mozilla.org/show_bug.cgi?id=145341#c5 with
builds:

6-5-2002 commercial mozilla 1.0.1, this is fixed with:

Mac OS X 10.1.5, Mac OS 9.2.2, Windows 2000, RedHat Linux 7.3