Closed Bug 1453549 Opened 6 years ago Closed 5 years ago

Intermittent devtools/client/debugger/new/test/mochitest/browser_dbg-babel-breakpoint-console.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort

Categories

(DevTools :: Debugger, defect, P5)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: intermittent-bug-filer, Assigned: CosminS)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell disabled])

Attachments

(1 file)

This is failing on coverage only and started with this merge push from autoland. https://goo.gl/qXcY4D
I would have said I has something to do with Bug 1453637 but that landed later on 12th april on inbound and personally I don't see something from that merge push https://goo.gl/1zJhYX that would hint something changed on browser_dbg-babel-breakpoint-console.js.

Joel, could you please take a look at this? Thank you.
Flags: needinfo?(jmaher)
Cosmin- you feel into the trap of chunks- browser_dbg-babel-breakpoint-console.js was run in dt3 prior to this push and that was not retriggered.

I think for ccov we should skip:
devtools/client/debugger/new/test/mochitest/browser_dbg-babel-breakpoint-console.js
devtools/client/debugger/new/test/mochitest/browser_dbg-babel-scopes.js

that might not clean it up, but will get most of it.

Cosmin, do you want to disable those tests?
Flags: needinfo?(jmaher) → needinfo?(csabou)
Thank you Joel for explaining this. Yes, I wanna have a try at disabling them. Will make a patch for them tomorrow.
Hi! Made a patch for skipping this test on coverage. The other one was already disabled with these lines:

[browser_dbg-babel-scopes.js]
skip-if = ccov # Bug 1441545

Joel, could you see if this is ok? Thank you.
Flags: needinfo?(csabou)
Attachment #8968421 - Flags: review?(jmaher)
Comment on attachment 8968421 [details] [diff] [review]
Disable on Win ccov

Review of attachment 8968421 [details] [diff] [review]:
-----------------------------------------------------------------

ok, this looks good
Attachment #8968421 - Flags: review?(jmaher) → review+
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f82556cd77c5
Disable devtools/client/debugger/new/test/mochitest/browser_dbg-babel-breakpoint-console.js on ccov for frequent failures. r=jmaher
Keywords: leave-open
Whiteboard: [stockwell disabled]
Product: Firefox → DevTools
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Assignee: nobody → csabou
You need to log in before you can comment on or make changes to this bug.