Closed
Bug 1453549
Opened 6 years ago
Closed 5 years ago
Intermittent devtools/client/debugger/new/test/mochitest/browser_dbg-babel-breakpoint-console.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort
Categories
(DevTools :: Debugger, defect, P5)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: intermittent-bug-filer, Assigned: CosminS)
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell disabled])
Attachments
(1 file)
786 bytes,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Filed by: philringnalda [at] gmail.com https://treeherder.mozilla.org/logviewer.html#?job_id=173176251&repo=mozilla-central https://queue.taskcluster.net/v1/task/ebrOcESjRO-owr-tvRjvsg/runs/0/artifacts/public/logs/live_backing.log
Assignee | ||
Comment 1•6 years ago
|
||
This is failing on coverage only and started with this merge push from autoland. https://goo.gl/qXcY4D I would have said I has something to do with Bug 1453637 but that landed later on 12th april on inbound and personally I don't see something from that merge push https://goo.gl/1zJhYX that would hint something changed on browser_dbg-babel-breakpoint-console.js. Joel, could you please take a look at this? Thank you.
Flags: needinfo?(jmaher)
Comment hidden (Intermittent Failures Robot) |
Comment 3•6 years ago
|
||
Cosmin- you feel into the trap of chunks- browser_dbg-babel-breakpoint-console.js was run in dt3 prior to this push and that was not retriggered. I think for ccov we should skip: devtools/client/debugger/new/test/mochitest/browser_dbg-babel-breakpoint-console.js devtools/client/debugger/new/test/mochitest/browser_dbg-babel-scopes.js that might not clean it up, but will get most of it. Cosmin, do you want to disable those tests?
Flags: needinfo?(jmaher) → needinfo?(csabou)
Assignee | ||
Comment 4•6 years ago
|
||
Thank you Joel for explaining this. Yes, I wanna have a try at disabling them. Will make a patch for them tomorrow.
Assignee | ||
Comment 5•6 years ago
|
||
Hi! Made a patch for skipping this test on coverage. The other one was already disabled with these lines: [browser_dbg-babel-scopes.js] skip-if = ccov # Bug 1441545 Joel, could you see if this is ok? Thank you.
Flags: needinfo?(csabou)
Attachment #8968421 -
Flags: review?(jmaher)
Comment 6•6 years ago
|
||
Comment on attachment 8968421 [details] [diff] [review] Disable on Win ccov Review of attachment 8968421 [details] [diff] [review]: ----------------------------------------------------------------- ok, this looks good
Attachment #8968421 -
Flags: review?(jmaher) → review+
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f82556cd77c5 Disable devtools/client/debugger/new/test/mochitest/browser_dbg-babel-breakpoint-console.js on ccov for frequent failures. r=jmaher
Assignee | ||
Updated•6 years ago
|
Keywords: leave-open
Whiteboard: [stockwell disabled]
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f82556cd77c5
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Assignee: nobody → csabou
Updated•5 years ago
|
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•