Closed Bug 1453549 Opened 2 years ago Closed 1 year ago
_dbg-babel-breakpoint-console .js | This test exceeded the timeout threshold . It should be rewritten or split up . If that's not possible, use request Longer Timeout(N), but only as a last resort
This is failing on coverage only and started with this merge push from autoland. https://goo.gl/qXcY4D I would have said I has something to do with Bug 1453637 but that landed later on 12th april on inbound and personally I don't see something from that merge push https://goo.gl/1zJhYX that would hint something changed on browser_dbg-babel-breakpoint-console.js. Joel, could you please take a look at this? Thank you.
Cosmin- you feel into the trap of chunks- browser_dbg-babel-breakpoint-console.js was run in dt3 prior to this push and that was not retriggered. I think for ccov we should skip: devtools/client/debugger/new/test/mochitest/browser_dbg-babel-breakpoint-console.js devtools/client/debugger/new/test/mochitest/browser_dbg-babel-scopes.js that might not clean it up, but will get most of it. Cosmin, do you want to disable those tests?
Flags: needinfo?(jmaher) → needinfo?(csabou)
Thank you Joel for explaining this. Yes, I wanna have a try at disabling them. Will make a patch for them tomorrow.
Hi! Made a patch for skipping this test on coverage. The other one was already disabled with these lines: [browser_dbg-babel-scopes.js] skip-if = ccov # Bug 1441545 Joel, could you see if this is ok? Thank you.
Attachment #8968421 - Flags: review?(jmaher)
Comment on attachment 8968421 [details] [diff] [review] Disable on Win ccov Review of attachment 8968421 [details] [diff] [review]: ----------------------------------------------------------------- ok, this looks good
Attachment #8968421 - Flags: review?(jmaher) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f82556cd77c5 Disable devtools/client/debugger/new/test/mochitest/browser_dbg-babel-breakpoint-console.js on ccov for frequent failures. r=jmaher
Whiteboard: [stockwell disabled]
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Assignee: nobody → csabou
You need to log in before you can comment on or make changes to this bug.