145362 - RFE: Ignore stale lock files

Status: VERIFIED FIXED

(Core Graveyard :: Profile: BackEnd, enhancement)

Description

[Aleksey Nogin]

If Mozilla is started on the same machine as the lock file points to and the pid
specified by the lock file no longer exists, Mozilla should just take over the
lock file, not consider the profile locked.

Comment 1

[Aleksey Nogin]

Sorry, this should be "BackEnd", probably.

Comment 2

[Conrad Carlen (not reading bugmail)]

That's what the code does and it worked for me in testing. How did you make this
happen? Also, if it does happen, I wouldn't call it an enhancement but a
showstopper.

Comment 3

[Aleksey Nogin]

Just reporoduced it again.

gulag|~/.mozilla/nogin/5aop1tz1.slt> ls -l lock
lrwxrwxrwx    1 nogin    nogin          19 May 17 17:58 lock -> 128.84.97.207:14591
gulag|~/.mozilla/nogin/5aop1tz1.slt> kill -9 14591
gulag|~/.mozilla/nogin/5aop1tz1.slt> ls -l lock
lrwxrwxrwx    1 nogin    nogin          19 May 17 17:58 lock -> 128.84.97.207:14591
gulag|~/.mozilla/nogin/5aop1tz1.slt> mozilla
 ---> Pops up the Profile Manager and does not let me use the "nogin" profile
Exit 1
gulag|~/.mozilla/nogin/5aop1tz1.slt> ls -l lock
lrwxrwxrwx    1 nogin    nogin          19 Май 17 17:58 lock -> 128.84.97.207:14591
gulag|~/.mozilla/nogin/5aop1tz1.slt> rm -f lock
gulag|~/.mozilla/nogin/5aop1tz1.slt> mozilla&
[1] 18659
gulag|~/.mozilla/nogin/5aop1tz1.slt> ls -l lock
lrwxrwxrwx    1 nogin    nogin          19 Май 17 20:08 lock -> 128.84.97.207:18659

BuildID 2002051509, compiled on RedHat Linux 7.2, running on RedHat Linux 7.3

Comment 4

[Andrew Schultz]

Attachment: patch

errno is ESRCH if the pid does *not* exist

Comment 5

[Boris Zbarsky [:bzbarsky]]

Dollars to donuts you're using a build from before bug 145061 was fixed (Andrew
definitely is).

Comment 6

[Brendan Eich [:brendan]]

Fixed already.

/be

Comment 7

[K'Trina Medina]

Verified