RFE: Ignore stale lock files

VERIFIED FIXED in mozilla1.0

Status

Core Graveyard
Profile: BackEnd
--
enhancement
VERIFIED FIXED
16 years ago
2 years ago

People

(Reporter: Aleksey Nogin, Assigned: Conrad Carlen (not reading bugmail))

Tracking

Trunk
mozilla1.0
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
If Mozilla is started on the same machine as the lock file points to and the pid
specified by the lock file no longer exists, Mozilla should just take over the
lock file, not consider the profile locked.
(Reporter)

Comment 1

16 years ago
Sorry, this should be "BackEnd", probably.
Assignee: ben → ccarlen
Component: Profile Manager FrontEnd → Profile Manager BackEnd
(Assignee)

Comment 2

16 years ago
That's what the code does and it worked for me in testing. How did you make this
happen? Also, if it does happen, I wouldn't call it an enhancement but a
showstopper.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0
(Reporter)

Comment 3

16 years ago
Just reporoduced it again.

gulag|~/.mozilla/nogin/5aop1tz1.slt> ls -l lock
lrwxrwxrwx    1 nogin    nogin          19 May 17 17:58 lock -> 128.84.97.207:14591
gulag|~/.mozilla/nogin/5aop1tz1.slt> kill -9 14591
gulag|~/.mozilla/nogin/5aop1tz1.slt> ls -l lock
lrwxrwxrwx    1 nogin    nogin          19 May 17 17:58 lock -> 128.84.97.207:14591
gulag|~/.mozilla/nogin/5aop1tz1.slt> mozilla
 ---> Pops up the Profile Manager and does not let me use the "nogin" profile
Exit 1
gulag|~/.mozilla/nogin/5aop1tz1.slt> ls -l lock
lrwxrwxrwx    1 nogin    nogin          19 Май 17 17:58 lock -> 128.84.97.207:14591
gulag|~/.mozilla/nogin/5aop1tz1.slt> rm -f lock
gulag|~/.mozilla/nogin/5aop1tz1.slt> mozilla&
[1] 18659
gulag|~/.mozilla/nogin/5aop1tz1.slt> ls -l lock
lrwxrwxrwx    1 nogin    nogin          19 Май 17 20:08 lock -> 128.84.97.207:18659

BuildID 2002051509, compiled on RedHat Linux 7.2, running on RedHat Linux 7.3

Comment 4

16 years ago
Created attachment 84132 [details] [diff] [review]
patch

errno is ESRCH if the pid does *not* exist

Updated

16 years ago
Keywords: patch
Dollars to donuts you're using a build from before bug 145061 was fixed (Andrew
definitely is).
Fixed already.

/be
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 7

16 years ago
Verified
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.