Closed Bug 1453638 Opened 2 years ago Closed 2 years ago

"Open RSS site" in live bookmark is not working

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect, P1)

61 Branch
x86_64
Windows 10
defect

Tracking

(firefox-esr52 unaffected, firefox59 unaffected, firefox60 unaffected, firefox61 verified)

VERIFIED FIXED
Firefox 61
Tracking Status
firefox-esr52 --- unaffected
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 --- verified

People

(Reporter: kuroweb, Assigned: mak)

References

Details

(Keywords: regression, Whiteboard: [fxsearch])

Attachments

(3 files)

Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Built from https://hg.mozilla.org/mozilla-central/rev/88f297d206a65910871de724e9c8bb462f04d792

Steps to reproduce:
1.make to clean profile.
2.Open a website offering RSS. example: https://www.fxsitecompat.com/ja/
3.open bookmark menu, click to "subscribe to this site".
4.click to "subscribe now".
5."subscribe with Live Bookmark" window, folder set to "bookmark toolbar",and subscribe.
6.click to subscribed site button.
7.click to "open Web Site Name".

Actual results:
Nothing happens.

Expected results:
show to web site offering RSS.

browser console log:
TypeError: Services.scriptSecurityManger is undefined browser.xul:1:53
Attached image open-rss-site-menu.png
open RSS web site menu.
Attached image browser-console.png
browser console.
Looks like a regression of bug 1374741, and it's a typo "Manger" instead of "Manager".
Assignee: nobody → mak77
Blocks: 1374741
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: regression
Priority: -- → P1
Whiteboard: [fxsearch]
Note: I'm not adding a test because the Live Bookmarks feature is currently under investigation for "Great or Dead", not worth adding a complex mochitest-browser test yet.
Comment on attachment 8967406 [details]
Bug 1453638 - 'Open site' in live bookmarks is not working.

LGTM, sorry I missed this in the code.
Attachment #8967406 - Flags: review?(jkt) → review+
Comment on attachment 8967406 [details]
Bug 1453638 - 'Open site' in live bookmarks is not working.

https://reviewboard.mozilla.org/r/236092/#review241848
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/cf9a7901409b
'Open site' in live bookmarks is not working. r=jkt
https://hg.mozilla.org/mozilla-central/rev/cf9a7901409b
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
I have reproduced this bug with Nightly 61.0a1 (2018-04-12) on Windows 10 , 64 Bit ! 

This bug's fix is Verified with latest Nightly !

Build   ID    20180423100754
User Agent    Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0

[bugday-20180418]
I have reproduced this bug with Nightly 61.0a1 (2018-04-12) on Ubuntu 16.04 LTS!

This bug's fix is Verified with latest Nightly !

Build   ID - 20180424220100
User Agent - Mozilla/5.0 (X11; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0
QA Whiteboard: [bugday-20180425]
As par comment 10 & comment 11 , I am marking this bug as verified fixed !
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.