1453638 - "Open RSS site" in live bookmark is not working

Status: VERIFIED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect, P1)

Description

[PRiMENON]

Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Built from https://hg.mozilla.org/mozilla-central/rev/88f297d206a65910871de724e9c8bb462f04d792

Steps to reproduce:
1.make to clean profile.
2.Open a website offering RSS. example: https://www.fxsitecompat.com/ja/
3.open bookmark menu, click to "subscribe to this site".
4.click to "subscribe now".
5."subscribe with Live Bookmark" window, folder set to "bookmark toolbar",and subscribe.
6.click to subscribed site button.
7.click to "open Web Site Name".

Actual results:
Nothing happens.

Expected results:
show to web site offering RSS.

browser console log:
TypeError: Services.scriptSecurityManger is undefined browser.xul:1:53

Comment 1

[PRiMENON]

Attachment: open-rss-site-menu.png

open RSS web site menu.

Comment 2

[PRiMENON]

Attachment: browser-console.png

browser console.

Comment 3

[Marco Bonardo [:mak]]

Looks like a regression of bug 1374741, and it's a typo "Manger" instead of "Manager".

Comment 4

[Marco Bonardo [:mak]]

Attachment: Bug 1453638 - 'Open site' in live bookmarks is not working.

Review commit: https://reviewboard.mozilla.org/r/236092/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/236092/

Comment 5

[Marco Bonardo [:mak]]

Note: I'm not adding a test because the Live Bookmarks feature is currently under investigation for "Great or Dead", not worth adding a complex mochitest-browser test yet.

Comment 6

[Jonathan Kingston [:jkt] he/him]

Comment on attachment 8967406 [details]
Bug 1453638 - 'Open site' in live bookmarks is not working.

LGTM, sorry I missed this in the code.

Comment 7

[Jonathan Kingston [:jkt] he/him]

Comment on attachment 8967406 [details]
Bug 1453638 - 'Open site' in live bookmarks is not working.

https://reviewboard.mozilla.org/r/236092/#review241848

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf9a7901409b
'Open site' in live bookmarks is not working. r=jkt

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/cf9a7901409b

Comment 10

[Sajedul Islam]

I have reproduced this bug with Nightly 61.0a1 (2018-04-12) on Windows 10 , 64 Bit ! 

This bug's fix is Verified with latest Nightly !

Build   ID    20180423100754
User Agent    Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0

[bugday-20180418]

Comment 11

[Md Maruf Rahman]

I have reproduced this bug with Nightly 61.0a1 (2018-04-12) on Ubuntu 16.04 LTS!

This bug's fix is Verified with latest Nightly !

Build   ID - 20180424220100
User Agent - Mozilla/5.0 (X11; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0

Comment 12

[Sajedul Islam]

As par comment 10 & comment 11 , I am marking this bug as verified fixed !