Closed Bug 1453789 Opened 5 years ago Closed 5 years ago

Remove Element.createShadowRoot.

Categories

(Core :: DOM: Core & HTML, enhancement)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 2 obsolete files)

With tests fixed.
58.52 KB, patch
smaug
: review+
Details | Diff | Splinter Review 
It breaks sites trying to detect shadow dom v0 support.
Comment on attachment 8967521 [details] [diff] [review]
0001-Bug-1453789-Remove-Element.createShadowRoot.-r-smaug.patch

I assume there will be another patch to fix tests.
Attachment #8967521 - Flags: review?(bugs) → review+
Attached patch Fix tests (obsolete) — — Splinter Review 
(To be squashed on the following commit)
Attachment #8967594 - Flags: review?(bugs)
Comment on attachment 8967594 [details] [diff] [review]
Fix tests

Hmm, looks like we have still test_shadow_element.html but never run it.
I guess that file should be removed.

But there are quite a few more tests based on searchfox.
Attachment #8967594 - Flags: review?(bugs) → review-

        Attachment #8967521 -
        Attachment is obsolete: true

        Attachment #8967594 -
        Attachment is obsolete: true

        Attachment #8967707 -
        Flags: review?(bugs)

    
    

    
  
Comment on attachment 8967707 [details] [diff] [review]
With tests fixed.

thanks!

        Attachment #8967707 -
        Flags: review?(bugs) → review+

    
    

    
  
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b2dd9ca61e0b
Remove Element.createShadowRoot. r=smaug

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/b2dd9ca61e0b
Status: NEW → RESOLVED
Closed: 5 years ago

          status-firefox61:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61

    
    

    
  
Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10466 for changes under testing/web-platform/tests

    
  
Keywords: dev-doc-needed
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.