Remove Element.createShadowRoot.

RESOLVED FIXED in Firefox 61

Status

()

enhancement
RESOLVED FIXED
a year ago
a month ago

People

(Reporter: emilio, Assigned: emilio)

Tracking

({dev-doc-complete})

unspecified
mozilla61
Points:
---

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

It breaks sites trying to detect shadow dom v0 support.
Comment on attachment 8967521 [details] [diff] [review]
0001-Bug-1453789-Remove-Element.createShadowRoot.-r-smaug.patch

I assume there will be another patch to fix tests.
Attachment #8967521 - Flags: review?(bugs) → review+
(Assignee)

Comment 3

a year ago
Posted patch Fix tests (obsolete) — Splinter Review
(To be squashed on the following commit)
(Assignee)

Updated

a year ago
Attachment #8967594 - Flags: review?(bugs)
Comment on attachment 8967594 [details] [diff] [review]
Fix tests

Hmm, looks like we have still test_shadow_element.html but never run it.
I guess that file should be removed.

But there are quite a few more tests based on searchfox.
Attachment #8967594 - Flags: review?(bugs) → review-
(Assignee)

Comment 5

a year ago
Attachment #8967521 - Attachment is obsolete: true
Attachment #8967594 - Attachment is obsolete: true
Attachment #8967707 - Flags: review?(bugs)
Comment on attachment 8967707 [details] [diff] [review]
With tests fixed.

thanks!
Attachment #8967707 - Flags: review?(bugs) → review+

Comment 7

a year ago
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b2dd9ca61e0b
Remove Element.createShadowRoot. r=smaug

Comment 8

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b2dd9ca61e0b
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10466 for changes under testing/web-platform/tests
Upstream PR merged

Updated

a year ago
Keywords: dev-doc-needed
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.