Closed
Bug 1453789
Opened 7 years ago
Closed 7 years ago
Remove Element.createShadowRoot.
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 2 obsolete files)
|
58.52 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
It breaks sites trying to detect shadow dom v0 support.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8967521 -
Flags: review?(bugs)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8967521 [details] [diff] [review]
0001-Bug-1453789-Remove-Element.createShadowRoot.-r-smaug.patch
I assume there will be another patch to fix tests.
Attachment #8967521 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
(To be squashed on the following commit)
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8967594 -
Flags: review?(bugs)
|
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8967594 [details] [diff] [review]
Fix tests
Hmm, looks like we have still test_shadow_element.html but never run it.
I guess that file should be removed.
But there are quite a few more tests based on searchfox.
Attachment #8967594 -
Flags: review?(bugs) → review-
|
|
Assignee | |
Comment 5•7 years ago
|
||
Attachment #8967521 -
Attachment is obsolete: true
Attachment #8967594 -
Attachment is obsolete: true
Attachment #8967707 -
Flags: review?(bugs)
|
|
||
Comment 6•7 years ago
|
||
Comment on attachment 8967707 [details] [diff] [review]
With tests fixed.
thanks!
Attachment #8967707 -
Flags: review?(bugs) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b2dd9ca61e0b
Remove Element.createShadowRoot. r=smaug
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10466 for changes under testing/web-platform/tests
Upstream PR merged
Keywords: dev-doc-needed
|
||
Comment 11•7 years ago
|
||
Mentioned here https://developer.mozilla.org/en-US/Firefox/Releases/61#Removals_from_the_web_platform
https://developer.mozilla.org/en-US/docs/Web/API/Element/createShadowRoot#Browser_compatibility has been updated in https://github.com/mdn/browser-compat-data/pull/1782
Keywords: dev-doc-needed → dev-doc-complete
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•