Closed Bug 1454232 Opened 2 years ago Closed 2 years ago

Syncing icon could follow attention icon fill color

Categories

(Firefox :: Theme, defect, P5)

defect

Tracking

()

RESOLVED FIXED
Firefox 62
Tracking Status
firefox61 --- fixed
firefox62 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

Details

Attachments

(2 files)

Attached image Screenshot
The blue spinning sync icon could follow the toolbarbutton-attention-fill variable.
Priority: -- → P5
Blocks: 1408121
No longer blocks: dark-theme-darkening
Assignee: nobody → ntim.bugs
Comment on attachment 8981010 [details]
Bug 1454232 - Use toolbarbutton-attention-fill for syncing animation.

https://reviewboard.mozilla.org/r/247128/#review253378
Attachment #8981010 - Flags: review?(dao+bmo) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/73aef553df3d
Use toolbarbutton-attention-fill for syncing animation. r=dao
https://hg.mozilla.org/mozilla-central/rev/73aef553df3d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Comment on attachment 8981010 [details]
Bug 1454232 - Use toolbarbutton-attention-fill for syncing animation.

Approval Request Comment
[Feature/Bug causing the regression]: dark theme darkening
[User impact if declined]: low visibility of syncing animation on dark theme
[Is this code covered by automated tests?]: low
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: no
[Why is the change risky/not risky?]: css only
[String changes made/needed]: no
Attachment #8981010 - Flags: approval-mozilla-beta?
Comment on attachment 8981010 [details]
Bug 1454232 - Use toolbarbutton-attention-fill for syncing animation.

Low-risk polish fix for the dark theme work shipping in Fx61. Approved for 61.0b12.
Attachment #8981010 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.