1454232 - Syncing icon could follow attention icon fill color

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P5)

Description

[Tim Nguyen :ntim]

Attachment: Screenshot

The blue spinning sync icon could follow the toolbarbutton-attention-fill variable.

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1454232 - Use toolbarbutton-attention-fill for syncing animation.

Review commit: https://reviewboard.mozilla.org/r/247128/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247128/

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8981010 [details]
Bug 1454232 - Use toolbarbutton-attention-fill for syncing animation.

https://reviewboard.mozilla.org/r/247128/#review253378

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73aef553df3d
Use toolbarbutton-attention-fill for syncing animation. r=dao

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/73aef553df3d

Comment 5

[Tim Nguyen :ntim]

Comment on attachment 8981010 [details]
Bug 1454232 - Use toolbarbutton-attention-fill for syncing animation.

Approval Request Comment
[Feature/Bug causing the regression]: dark theme darkening
[User impact if declined]: low visibility of syncing animation on dark theme
[Is this code covered by automated tests?]: low
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: no
[Why is the change risky/not risky?]: css only
[String changes made/needed]: no

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8981010 [details]
Bug 1454232 - Use toolbarbutton-attention-fill for syncing animation.

Low-risk polish fix for the dark theme work shipping in Fx61. Approved for 61.0b12.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e049dc25908c