1454263 - Regression? NTP Search Bar Result Menu has a wrong divider color in Dark Theme

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P2)

Description

[Mehmet]

Attachment: Screenshot with wrong divider color

Nightly 61.0a1 (2018-04-15) (64-Bit)
macOS 10.12.6

(1) Open a NTP
(2) Focus the Search Bar and type something so that the menu with the results appears
(3) Take a look at the divider (please see the attached screenshot)

Actual: Wrong color.

Expected: Same color like the other dividers in this menu.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

Amy confirmed this should be fixed.

Comment 2

[Amy Lee [:amylee] UX]

Agreed. Also the vertical dividers between the search logos should also be the same colour as well.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4093

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/6a260b7b5e4becee40a421174e14dc28677df83e
Fix Bug 1454263 - fix search drop down dividers and hover colors

https://github.com/mozilla/activity-stream/commit/a79149a5bd8bb4b012975e0a262a1896b3e4437b
Merge pull request #4093 from rlr/Bug1454263/divider

Fix Bug 1454263 - fix search drop down dividers and hover colors

Comment 5

[Mehmet]

Hi, is the fix from Github already landed in latest Nightly? I'm still not seeing the correct divider colour?

Thanks for your feedback in advance.

Comment 6

[Ed Lee :Mardak]

No, it will be exported in bug 1455216

Comment 7

[Mehmet]

(In reply to Ed Lee :Mardak from comment #6)
> No, it will be exported in bug 1455216

Thanks for the update :-)

Comment 8

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/5d2486077e4b

Comment 9

[Mehmet]

Attachment: Screenshot from 61.0a1 (2018-04-23)

(In reply to Ed Lee :Mardak from comment #8)
> https://hg.mozilla.org/mozilla-central/rev/5d2486077e4b

I am not seeing it fixed in 61.0a1 (2018-04-23) (64-Bit) :-(

Comment 10

[Ricky Rosario [:rrosario, :r1cky]]

Attachment: Screen Shot 2018-04-23 at 1.41.19 PM.png

(In reply to Mehmet from comment #9)
> Created attachment 8970257 [details]
> Screenshot from 61.0a1 (2018-04-23)
> 
> (In reply to Ed Lee :Mardak from comment #8)
> > https://hg.mozilla.org/mozilla-central/rev/5d2486077e4b
> 
> I am not seeing it fixed in 61.0a1 (2018-04-23) (64-Bit) :-(

It is there, it's just barely visible because of the opacity of the color. If I change the variable for the color (--newtab-border-secondary-color) to solid white then you can see it's there (see attachment).

Comment 11

[Mehmet]

Attachment: Addressbar-Dropdown.png

(In reply to Ricky Rosario [:rrosario, :r1cky] from comment #10)
> Created attachment 8970270 [details]
> Screen Shot 2018-04-23 at 1.41.19 PM.png
> 
> (In reply to Mehmet from comment #9)
> > Created attachment 8970257 [details]
> > Screenshot from 61.0a1 (2018-04-23)
> > 
> > (In reply to Ed Lee :Mardak from comment #8)
> > > https://hg.mozilla.org/mozilla-central/rev/5d2486077e4b
> > 
> > I am not seeing it fixed in 61.0a1 (2018-04-23) (64-Bit) :-(
> 
> It is there, it's just barely visible because of the opacity of the color.
> If I change the variable for the color (--newtab-border-secondary-color) to
> solid white then you can see it's there (see attachment).

Thanks for your feedback. Do you wan't to leave it as it is or make it consistent with the Addressbar-Dropdown? Please see the attached screenshot. Thanks :-)