1454264 - New Tab Page Search Bar Focus effect looks wrong on Mac OS X

Status: RESOLVED INVALID

(Firefox :: New Tab Page, defect)

Description

[Mehmet]

Attachment: Actual vs Expected

Nightly 61.0a1 (2018-04-15) (64-Bit)
macOS 10.12.6

(1) Open a NTP
(2) Focus the Search Bar.

Actual: Wrong Focus Ring color.

Expected: Correct color.

A screenshot is attached.

This is a regression in recent Nightly.

Comment 1

[Ciprian Muresan [:cmuresan], Ecosystem QA]

10:43.49 INFO: Last good revision: 1344ca26ef0aec57cb0177f7089287b263c7a52b
10:43.49 INFO: First bad revision: 9896401414cb3c7cb5f1118b307b0267212c8aad
10:43.49 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1344ca26ef0aec57cb0177f7089287b263c7a52b&tochange=9896401414cb3c7cb5f1118b307b0267212c8aad

Looks like bug 1454074 caused this.

The Top Site edit fields also have the same hover effect. Should those be changed as well?

Comment 2

[Amy Lee [:amylee] UX]

Hi, 

The new focus style is intentional (double outline) and also intentional in the Top Site edit field. This is to reflect the DSG here: https://design.firefox.com/photon/components/input-fields.html

Comment 3

[Mehmet]

Attachment: Bildschirmfoto 2018-04-16 um 21.09.51.png

(In reply to Amy Lee [:amylee] UX from comment #2)
> Hi, 
> 
> The new focus style is intentional (double outline) and also intentional in
> the Top Site edit field. This is to reflect the DSG here:
> https://design.firefox.com/photon/components/input-fields.html

Thanks for your feedback. If this is intentional, maybe the Dropdown (especially the top grey border) can be placed under the blue focus ring? Please see the enclosed screenshot.

Thanks :-)

Comment 4

[Amy Lee [:amylee] UX]

(In reply to Mehmet from comment #3)
> Created attachment 8968295 [details]
> Bildschirmfoto 2018-04-16 um 21.09.51.png
> 
> (In reply to Amy Lee [:amylee] UX from comment #2)
> > Hi, 
> > 
> > The new focus style is intentional (double outline) and also intentional in
> > the Top Site edit field. This is to reflect the DSG here:
> > https://design.firefox.com/photon/components/input-fields.html
> 
> Thanks for your feedback. If this is intentional, maybe the Dropdown
> (especially the top grey border) can be placed under the blue focus ring?
> Please see the enclosed screenshot.
> 
> Thanks :-)

Hi, 

Yes this will be fixed in the next update. There's some visual changes I'm currently working on for the search bar in New Tab.

Comment 5

[Ed Lee :Mardak]

This change is by design as per comment 2. amylee, if there's a bug for the dropdown position, please link it.

Comment 6

[Ed Lee :Mardak]

The adjusting dropdown position is fixed as part of bug 1454263.

Comment 7

[Mehmet]

(In reply to Ed Lee :Mardak from comment #6)
> The adjusting dropdown position is fixed as part of bug 1454263.

Thanks for the info :-)