1454414 - slow rasterizing on http://themaninblue.com/experiment/eclipse/

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[Ben Kelly [:bkelly, not reviewing]]

Visit:

http://themaninblue.com/experiment/eclipse/

Move your mouse around to trigger the animation.  Note the low fps.

Profile:

https://perfht.ml/2qD3JXL

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Chrome seems to run at 60fps.  Edge seems to run slower than FF nightly.

Comment 2

[Matt Woodrow (:mattwoodrow)]

Looks like most of the time is spent within DrawTargetD2D1::CreatePathBuilder (for a rounded rectangle), waiting on a critical section. No obvious contention from any other gecko threads in the profile.

I don't remember why we needed threadsafe d2d, but maybe we could try cache these objects internally somehow.

Comment 3

[Mayank Bansal]

with WR, we are smoother than Chrome (Wintel+iGFX system)

Comment 4

[Jean Gong :jgong]

Bas, can please take a look at this bug?

Comment 5

[Kannan Vijayan [:djvj]]

Tested with WebRender on Linux and this performs really smoothly for me as well.  This problem will likely go away as webrender lands.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Hey Bas, any thoughts on comment 2?

Comment 7

[Bas Schouten (:bas.schouten)]

I have a patch that should address this, I forgot in which bug, I've never quite been convinced there's usecases important enough to justify the effort, it would probably take a day or two. If this is that usecase, that seems reasonable, not sure if it is.

Comment 8

[Mayank Bansal]

This *might* have regressed a bit on WR+Wintel+iGFX system in maybe a week or two. Chrome *feels* smoother

Here is a profile with WR-y threads added: https://perfht.ml/2sBmHPm