1454443 - Ship a system add-on that properly attributes Google searches on older versions of Firefox

Status: VERIFIED FIXED

(Firefox :: Search, enhancement, P1)

Description

[Mike Kaply [:mkaply]]

We still have quite a few users on older versions of Firefox, so we'd like to ship a sytem add-on to properly attributes Google searches for all those cases.

Here are the specific cases we are addressing:

Firefox 43-45 - No Google search attribution, so we add it.

Firefox 46-56 - In some regions we were not attributing searches, so we add the code in those cases. We also have a unique code we use for the US that became available in Firefox 57. We are adding that code for US users pre 57.

These changes only affect our built in Google engine.

Comment 1

[Mike Kaply [:mkaply]]

The code for this is available here:

https://github.com/mozilla/one-off-system-add-ons/pull/104

It's been reviewed by florian for correctness. Now needs review from system add-ons team.

Comment 3

[Mike Kaply [:mkaply]]

Attachment: XPI for signing

Wezhou:

Can we get this signed so we can get it on a test channel.

Comment 4

[Mike Kaply [:mkaply]]

Rehan:

Are you the person who sets this up in balrog?

This is going to target everything we can below 57.

Things are looking good from a test perspective, but they have a scenario that requires it being in the channel.

Thanks!

Comment 5

[:wezhou]

Attachment: signed.8970738.xpi

Signed file attached. Please test.

Comment 6

[Rehan Dalal (Inactive)]

I am the one who would set this up, I'll get this up later today

Comment 7

[Mike Kaply [:mkaply]]

Any updates Rehan?

Comment 8

[Rehan Dalal (Inactive)]

Sorry about the delay. I have this up on the test channel "release-sysaddon". 

It is currently targeted at 47.* to 56.*. Does it need to go lower?

Comment 9

[Mike Kaply [:mkaply]]

yes. it should go to 42 if possible. we think that was the first version with system addons. 

thanks!

Comment 10

[Rehan Dalal (Inactive)]

Done, this should take effect in about 5 minutes.

Comment 11

[Mike Kaply [:mkaply]]

Rehan: Can you confirm this is live for Firefox 43? It doesn't appear to download it - only the hotfix addon.

Maybe system add-ons don't work on 43 after all?

Comment 12

[Rehan Dalal (Inactive)]

It has been configured for 43 but I think it might be that <=43.* do not get system addon updates. 

I did not see any existing rules for those versions.

Perhaps rhelmer has a better idea?

Comment 13

[Robert Helmer [:rhelmer]]

(In reply to Rehan Dalal [:rehan, :rdalal] from comment #12)
> It has been configured for 43 but I think it might be that <=43.* do not get
> system addon updates. 
> 
> I did not see any existing rules for those versions.
> 
> Perhaps rhelmer has a better idea?

I'll dig up the history, it was in 43 that initial support landed but I'm not sure exactly when we pushed the first update.

Comment 14

[Robert Helmer [:rhelmer]]

Hm, looking at bug 1212059 it seems likely that we didn't have updates ready until 44... pretty sure that in 43 we landed support for built-in add-ons but didn't have the signature check and other things ready until 44 at least.

Hotfix add-on should work further back, not sure the state of the server infra there :) I can help take a look if needed though. I'd expect the same XPI to work, although it likely needs to be signed with a different key.

Comment 15

[Mike Kaply [:mkaply]]

If we can't do 43, that's life. This is really just a "do what we can" thing.

Comment 16

[Mike Kaply [:mkaply]]

Per signoff email, this is ready to go.

Comment 17

[Mike Kaply [:mkaply]]

This is ready to go. QA signoff came in.

Comment 18

[Rehan Dalal (Inactive)]

Mike could you please forward me the email?

Comment 19

[Rehan Dalal (Inactive)]

The rules have been updated for the "release" channel and are pending relman signoff.

NI'ing :lizzard for sign off -- There are 17 rules that need sign off.

Comment 20

[Mike Kaply [:mkaply]]

Liz is at Google I/O. moving ni to RyanVM or julien.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

Signed off in Balrog. No scheduled changes pending now.

Comment 22

[Mike Kaply [:mkaply]]

I've verified we're seeing searches allocated to these new search engines, so everything is working as expected.