1456426 - The "firefox-b(-1)" string is not added to a search made from the "about:home" or "about:newtab" page on Firefox 48 and older

Status: VERIFIED FIXED

(Firefox :: Search, enhancement)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected Versions]:
- Firefox 48 and older

[Affected Platforms]:
- All Windows
- All Linux
- All Mac

[Prerequisites]:
- Have a new Firefox profile.
- Have the following prefs. in the "about:config" page (If a preference does not exist, please create it):
	- “xpinstall.signatures.required” pref set to “false”;
	- “browser.search.countryCode” pref set to "US".
- Have the latest "Google Code Correction" add-on (1.0) installed from https://goo.gl/P2KVst.

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites and navigate to the "about:home" page.
2. Focus the "Search" field and write something.
3. Press the "Enter" key and observe the URL.

[Expected result]:
- The URL contains the "firefox-b-1" string.

[Actual result]:
- The URL does not contains the "firefox-b-1" string.

[Regression Window]:
First good revision: ae7413abfa4d3954a6a4ce7c1613a7100f367f9a (2016-04-19)
Last bad revision: 1f16d3da9280e40ada252acf8110b91ee1edbb08 (2016-04-18)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1f16d3da9280e40ada252acf8110b91ee1edbb08&tochange=ae7413abfa4d3954a6a4ce7c1613a7100f367f9a

From the pushlog, I think that the behavior was changed in Bug 1264786.

[Notes]:
- This issue is reproducible if a search is made from the "about:newtab" page search field.
- The issue is also reproducible with the non-US builds.
- The issue is not reproducible if a search is made from the "Search Bar" or from the "Address Bar".
- Attached a screen recording of the issue.

Comment 1

[Mike Kaply [:mkaply]]

Fixed by:

https://github.com/mozilla/one-off-system-add-ons/pull/104/commits/b18b1bd18525057d12de9e64acddec051a7d1f38

Comment 2

[Mike Kaply [:mkaply]]

The wording of this was bad. This was a test of the system add-on. So there was no regression.

Comment 3

[Marius Coman [:mcoman], Ecosystem QA]

Marking this issue as verified as this was a test of a system add-on and it was already fixed on GitHub.