Closed
Bug 1454788
Opened 6 years ago
Closed 6 years ago
Remove in-tree generated style binding code
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
3.51 MB,
patch
|
emilio
:
review+
|
Details | Diff | Splinter Review |
This is now dead code, and only serves to confuse people. :-)
Assignee | ||
Comment 1•6 years ago
|
||
MozReview-Commit-ID: 2AjKSzYEOUB
Attachment #8968669 -
Flags: review?(emilio)
Updated•6 years ago
|
Attachment #8968669 -
Flags: review?(emilio) → review+
Pushed by bholley@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8e754a50cee5 Remove in-tree generated style binding code. r=emilio
Comment 3•6 years ago
|
||
Backed out changeset 8e754a50cee5 (bug 1454788) for failing Linux rusttests on a CLOSED TREE Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8e754a50cee54e4d516657e52c6fe9779df82762 Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=174227888&repo=mozilla-inbound&lineNumber=30320 Log snippet: [task 2018-04-18T00:01:54.062Z] 00:01:54 INFO - warning: build failed, waiting for other jobs to finish... [task 2018-04-18T00:03:33.761Z] 00:03:33 INFO - error: build failed [task 2018-04-18T00:03:33.761Z] 00:03:33 INFO - /builds/worker/workspace/build/src/config/rules.mk:967: recipe for target 'force-cargo-test-run' failed [task 2018-04-18T00:03:33.761Z] 00:03:33 INFO - make[2]: *** [force-cargo-test-run] Error 101 [task 2018-04-18T00:03:33.762Z] 00:03:33 INFO - make[2]: Target 'check' not remade because of errors. [task 2018-04-18T00:03:33.762Z] 00:03:33 INFO - make[2]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/library/rust' [task 2018-04-18T00:03:33.762Z] 00:03:33 INFO - /builds/worker/workspace/build/src/config/recurse.mk:100: recipe for target 'toolkit/library/rust/check' failed [task 2018-04-18T00:03:33.762Z] 00:03:33 INFO - make[1]: *** [toolkit/library/rust/check] Error 2 [task 2018-04-18T00:03:33.762Z] 00:03:33 INFO - make[1]: Target 'recurse_check' not remade because of errors. [task 2018-04-18T00:03:33.762Z] 00:03:33 INFO - make[1]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox' [task 2018-04-18T00:03:33.762Z] 00:03:33 INFO - /builds/worker/workspace/build/src/config/recurse.mk:32: recipe for target 'check' failed [task 2018-04-18T00:03:33.762Z] 00:03:33 INFO - make: *** [check] Error 2 [task 2018-04-18T00:03:33.860Z] 00:03:33 ERROR - Return code: 2 [task 2018-04-18T00:03:33.861Z] 00:03:33 INFO - TinderboxPrint: check<br/>17/0/0 [task 2018-04-18T00:03:33.861Z] 00:03:33 WARNING - setting return code to 2 [task 2018-04-18T00:03:33.861Z] 00:03:33 ERROR - 'mach build check' did not run successfully. Please check log for errors.
Flags: needinfo?(bobbyholley)
Backout by rgurzau@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e138e43fb405 Backed out changeset 8e754a50cee5 for failing Linux rusttests on a CLOSED TREE
Assignee | ||
Comment 6•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ddb5e4127b7bfd9818e52c92829379c59fab556
Pushed by bholley@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/39f5189c574b Remove in-tree generated style binding code. r=emilio
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(bobbyholley)
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/39f5189c574b
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•