Closed
Bug 1454820
Opened 6 years ago
Closed 6 years ago
bundled WebExtension experiments do not work for SIGNEDSTATE_SYSTEM
Categories
(WebExtensions :: Experiments, enhancement, P1)
WebExtensions
Experiments
Tracking
(firefox60 wontfix, firefox61+ fixed)
RESOLVED
FIXED
mozilla61
People
(Reporter: rhelmer, Assigned: jkt)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
System add-ons have a different OU and signed state: https://searchfox.org/mozilla-central/rev/f65d7528e34ef1a7665b4a1a7b7cdb1388fcd3aa/toolkit/mozapps/extensions/AddonManager.jsm#3366 This currently fails the `isPrivileged()` check used to allow bundled experiments: https://searchfox.org/mozilla-central/rev/f65d7528e34ef1a7665b4a1a7b7cdb1388fcd3aa/toolkit/components/extensions/Extension.jsm#1349-1353
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 3•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8968708 [details] Bug 1454820 - Add support for system addon signing for web extension bundling. https://reviewboard.mozilla.org/r/237414/#review243196 Sorry for the drive-by but I don't think this is enough. This will enable system addon updates, but not system addons that are distributed with the app in the features directory.
|
Reporter | |
Updated•6 years ago
|
Assignee: rhelmer → jkt
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 7•6 years ago
|
||
n-i on myself to remember to check up on this tomorrow.
Flags: needinfo?(lhenry)
| Comment hidden (mozreview-request) |
|
||
Comment 9•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8968708 [details] Bug 1454820 - Add support for system addon signing for web extension bundling. https://reviewboard.mozilla.org/r/237414/#review245342 Looks fine to me, should probably be sure to get Kris' approval, too.
Attachment #8968708 -
Flags: review?(jhofmann) → review+
|
|
||
Comment 10•6 years ago
|
||
Kris, do you think this is ready to land? Are you aiming at 61 here, or at 60?
status-firefox60:
--- → ?
status-firefox61:
--- → ?
tracking-firefox61:
--- → ?
Flags: needinfo?(lhenry) → needinfo?(kmaglione+bmo)
|
||
Comment 11•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8968708 [details] Bug 1454820 - Add support for system addon signing for web extension bundling. https://reviewboard.mozilla.org/r/237414/#review245906
Attachment #8968708 -
Flags: review?(kmaglione+bmo) → review+
|
|
||
Updated•6 years ago
|
Priority: -- → P1
|
|
||
Comment 12•6 years ago
|
||
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #10) > Kris, do you think this is ready to land? Are you aiming at 61 here, or at > 60? Yes, I think so. I think we can aim for 61 at this point, unless anyone thinks we're very likely to need to ship system extensions with bundled experiments on 60. The issues that would have originally justified an uplift have been resolved. It is a very low-risk patch, though.
Flags: needinfo?(kmaglione+bmo)
|
||
Comment 13•6 years ago
|
||
Pushed by jkingston@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8141b60030b9 Add support for system addon signing for web extension bundling. r=johannh,kmag
|
||
Comment 14•6 years ago
|
||
Backed out changeset for browser chrome failures on browser_901207_searchbar_in_panel.js on Linux debug Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=8141b60030b908c1f291979d72e0f21db8206c5c&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=pending&filter-resultStatus=running&filter-resultStatus=success&filter-searchStr=85738035d76b555081da1b1a9cc773701c1f68c8 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=175883593&repo=autoland&lineNumber=4285 Backout link: https://hg.mozilla.org/integration/autoland/rev/8229360171458d5e2a36fd562e9ba1da6af9b6ba
Flags: needinfo?(jkt)
|
Assignee | |
Comment 15•6 years ago
|
||
This fail seems very unrelated and it also looks like another backout happened to solve the same error in Bug 1457287. Can we try landing this again?
Flags: needinfo?(jkt) → needinfo?(csabou)
|
|
||
Comment 16•6 years ago
|
||
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7e3aa63ae752 Add support for system addon signing for web extension bundling. r=johannh,kmag
|
|
||
Comment 17•6 years ago
|
||
I have re-landed it. https://hg.mozilla.org/integration/autoland/rev/7e3aa63ae7529cc0b48c106cbc918e937872c273 https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=7e3aa63ae7529cc0b48c106cbc918e937872c273&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified Will monitor to see if the fail is gone.
Flags: needinfo?(csabou)
|
|
||
Comment 18•6 years ago
|
||
Backed out changeset for ESlint failure on extensions/Extension.jsm:509:22 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=7e3aa63ae7529cc0b48c106cbc918e937872c273&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&filter-resultStatus=pending&filter-resultStatus=running&filter-searchStr=eslint&selectedJob=175948164 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=175948164&repo=autoland&lineNumber=264 Backout link: https://hg.mozilla.org/integration/autoland/rev/b2c04559e167b863e9aaf74481b63179868495aa Jonathan, I do know what happened here, could you please take a look? Thanks.
Flags: needinfo?(jkt)
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 20•6 years ago
|
||
Marked for landing after other commits landed broke the complexity of this function.
Flags: needinfo?(jkt)
|
|
||
Comment 21•6 years ago
|
||
Pushed by jkingston@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5e8342edb62d Add support for system addon signing for web extension bundling. r=johannh,kmag
|
|
||
Comment 22•6 years ago
|
||
Backed out changeset for mochitest e-10s failures on test_bug386782.html. Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=5e8342edb62d87e2d8a3f2f20a13edc11526581d&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=runnable&selectedJob=175983563 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=175983563&repo=autoland&lineNumber=3883 https://treeherder.mozilla.org/logviewer.html#?job_id=175983976&repo=autoland&lineNumber=16374 https://treeherder.mozilla.org/logviewer.html#?job_id=175985715&repo=autoland&lineNumber=2653 https://treeherder.mozilla.org/logviewer.html#?job_id=175985444&repo=autoland&lineNumber=36499 https://treeherder.mozilla.org/logviewer.html#?job_id=175985566&repo=autoland&lineNumber=13246 Backout link: https://hg.mozilla.org/integration/autoland/rev/04e9bfc67922d06ba95281cbc2a7ea5f28512365 Please take a look at all the above failures.
Flags: needinfo?(jkt)
|
|
Assignee | |
Comment 23•6 years ago
|
||
None of those seem relevant, these are all DOM tests? Was there anything else that seemed closer to extensions? I don't recognise any of these whilst I was building this patch. Thanks!
Flags: needinfo?(jkt) → needinfo?(csabou)
|
|
||
Comment 24•6 years ago
|
||
So Jonathan, I will give the range for each one from when you pushed to where I've backed it out. https://tinyurl.com/ydf5po4d -> https://treeherder.mozilla.org/logviewer.html#?job_id=175983563&repo=autoland&lineNumber=3883 https://tinyurl.com/ybd9j6y8 -> https://treeherder.mozilla.org/logviewer.html#?job_id=175983976&repo=autoland&lineNumber=16374 https://tinyurl.com/y8k4seoy -> https://treeherder.mozilla.org/logviewer.html#?job_id=175985715&repo=autoland&lineNumber=2653 https://tinyurl.com/yanhtu5h -> https://treeherder.mozilla.org/logviewer.html#?job_id=175985444&repo=autoland&lineNumber=36499 https://tinyurl.com/y7nst9le -> https://treeherder.mozilla.org/logviewer.html#?job_id=175985566&repo=autoland&lineNumber=13246 These are all of the above. I think you can clearly see they started with your push. There are also lots of other failures that started after this bug was landed. Please take a look at them. The following: https://tinyurl.com/y7nst9le, https://tinyurl.com/yckouh3p, http://tinyurl.com/y7wl7sy3, http://tinyurl.com/yb42c27t, http://tinyurl.com/y9j5dhqa, http://tinyurl.com/y8eayppg and I could go on.
Flags: needinfo?(csabou) → needinfo?(jkt)
|
|
Assignee | |
Comment 25•6 years ago
|
||
Crap I merged another patch in whilst trying to rush this out the door. I understand now sorry. Will fix now!
Flags: needinfo?(jkt)
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 27•6 years ago
|
||
I requested for landing again after removing the other patch which got merged in by mistake. I got a clean try run, especially not including any of the mentioned dom issues from the previous. https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b491c5fc8b8837804892e5247969f65f7eabfd9
|
|
||
Comment 28•6 years ago
|
||
Pushed by jkingston@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fa02de71ebf7 Add support for system addon signing for web extension bundling. r=johannh,kmag
|
||
Comment 29•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fa02de71ebf7
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
|
||
Comment 30•6 years ago
|
||
wontfix for 60 based on comment 12. Is this something QE should verify?
|
|
Assignee | |
Comment 31•6 years ago
|
||
I think this is fine without verifying at this point given the tests we have.
Flags: needinfo?(jkt)
|
||
Updated•6 years ago
|
Flags: qe-verify-
|
|
||
Comment 32•6 years ago
|
||
Set to "Flags: qe-verify-" as per https://bugzilla.mozilla.org/show_bug.cgi?id=1454820#c31.
|
||
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•