Closed
Bug 1454822
Opened 7 years ago
Closed 7 years ago
Cache intrinsic sizes of flex containers
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
(Keywords: perf)
Attachments
(2 files)
As suggested in bug 1448672 comment 4, we should cache the results of nsFlexContainerFrame::GetMinISize/GetPrefISize, like we do in nsGridContainerFrame. I'm cloning the [qf:p3] whiteboard status from bug 1448672, because this fix is a big part of addressing that bug.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 3•7 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=22e8b55d04e4b978531a4a14b37f37b77b3e3de3
|
|
Assignee | |
Updated•7 years ago
|
Blocks: flexbox-perf-issues
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8968715 [details] Bug 1454822 part 1: Refactor nsFlexContainerFrame::GetMinISize/GetPrefISize to be implemented via a common helper function. https://reviewboard.mozilla.org/r/237436/#review243306
Attachment #8968715 -
Flags: review?(mats) → review+
|
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8968716 [details] Bug 1454822 part 2: Cache the results of nsFlexContainerFrame::GetMinISize/GetPrefISize. https://reviewboard.mozilla.org/r/237438/#review243308
Attachment #8968716 -
Flags: review?(mats) → review+
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9afaf3e043b2 part 1: Refactor nsFlexContainerFrame::GetMinISize/GetPrefISize to be implemented via a common helper function. r=mats https://hg.mozilla.org/integration/autoland/rev/8f14385e4b18 part 2: Cache the results of nsFlexContainerFrame::GetMinISize/GetPrefISize. r=mats
|
||
Comment 7•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9afaf3e043b2 https://hg.mozilla.org/mozilla-central/rev/8f14385e4b18
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
|
||
Updated•3 years ago
|
Performance Impact: --- → P3
Whiteboard: [qf:p3]
You need to log in
before you can comment on or make changes to this bug.
Description
•