Closed Bug 1454822 Opened 2 years ago Closed 2 years ago

Cache intrinsic sizes of flex containers

Categories

(Core :: Layout, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

(Keywords: perf, Whiteboard: [qf:p3] )

Attachments

(2 files)

As suggested in bug 1448672 comment 4, we should cache the results of nsFlexContainerFrame::GetMinISize/GetPrefISize, like we do
in nsGridContainerFrame.

I'm cloning the [qf:p3] whiteboard status from bug 1448672, because this fix is a big part of addressing that bug.
Comment on attachment 8968715 [details]
Bug 1454822 part 1: Refactor nsFlexContainerFrame::GetMinISize/GetPrefISize to be implemented via a common helper function.

https://reviewboard.mozilla.org/r/237436/#review243306
Attachment #8968715 - Flags: review?(mats) → review+
Comment on attachment 8968716 [details]
Bug 1454822 part 2: Cache the results of nsFlexContainerFrame::GetMinISize/GetPrefISize.

https://reviewboard.mozilla.org/r/237438/#review243308
Attachment #8968716 - Flags: review?(mats) → review+
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9afaf3e043b2
part 1: Refactor nsFlexContainerFrame::GetMinISize/GetPrefISize to be implemented via a common helper function. r=mats
https://hg.mozilla.org/integration/autoland/rev/8f14385e4b18
part 2: Cache the results of nsFlexContainerFrame::GetMinISize/GetPrefISize. r=mats
https://hg.mozilla.org/mozilla-central/rev/9afaf3e043b2
https://hg.mozilla.org/mozilla-central/rev/8f14385e4b18
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.