Closed Bug 794267 Opened 12 years ago Closed 3 years ago

Cache the value computed in nsFlexContainerFrame::GetMinWidth() & GetPrefWidth()

Categories

(Core :: Layout: Flexbox, defect)

Product:
Core
Component:
Layout: Flexbox
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1454822

People

(Reporter: dholbert, Unassigned)

References

Details

Quoting David Baron [:dbaron] from bug 666041 comment #105:
> >+  // XXXdholbert Optimization: We could cache our intrinsic widths like
> >+  // nsBlockFrame does (and return it early from this function if it's set).
> >+  // Whenever anything happens that might change it, set it to
> >+  // NS_INTRINSIC_WIDTH_UNKNOWN (like nsBlockFrame::MarkIntrinsicWidthsDirty
> >+  // does)
> 
> I think you should probably do this

Filing this bug as a followup to cover that ^

We fixed this in bug 1454822.

Status: NEW → RESOLVED
Closed: 3 years ago
Component: Layout → Layout: Flexbox
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.