1454889 - Remove createObjectURL()'s MediaStream overload

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Anne (:annevk)]

Per https://w3c.github.io/mediacapture-main/ this was removed in 2013 from the standard, but we appear to still implement it. Safari does throw.

Comment 1

[Anne (:annevk)]

Test: https://github.com/w3c/web-platform-tests/pull/10515.

Comment 2

[Andrea Marchesini [:baku]]

The warning message landed 1 year ago, in Firefox 54. I think it's time to remove this method.

Comment 3

[Andrea Marchesini [:baku]]

Attachment: URL_mediaStream.patch

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c5a4939300c
Remove createObjectURL()'s MediaStream overload, r=valentin

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/0c5a4939300c

Comment 6

[Kohei Yoshino]

Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/url-createobjecturl-no-longer-accepts-mediastream-as-argument/

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/fb435df9797a
Backed out changeset 0c5a4939300c for causing frequent Leaks (Bug 1378025). a=backout

Comment 8

[Narcis Beleuzu [:NarcisB]]

Backed out for causing frequent Leaks (Bug 1378025)

Backout link: https://hg.mozilla.org/mozilla-central/rev/fb435df9797a471419670fe2d053432556959a9d
Failure log link: https://treeherder.mozilla.org/logviewer.html#?job_id=177193780&repo=autoland&lineNumber=3463
Bug 1378025 : https://bugzilla.mozilla.org/show_bug.cgi?id=1378025

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/43e0ab28dfe2
Re-add expected fail mediacapture-streams/historical.html after backout. a=wpt-fix

Comment 10

[Andreas Pehrson [:pehrsons]]

You should be able to reland now. Note that WPT needs an additional unexpected-pass fix, per https://treeherder.mozilla.org/#/jobs?repo=try&revision=b568e34493797742ad83deea0a439cdda9dbf4ce&selectedJob=178302962

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1076e77e7b5c
Remove createObjectURL()'s MediaStream overload, r=valentin

Comment 12

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/1076e77e7b5c

Comment 13

[Kohei Yoshino]

Updated the site compatibility note for 62: https://www.fxsitecompat.com/en-CA/docs/2018/url-createobjecturl-no-longer-accepts-mediastream-as-argument/

Comment 14

[Eric Shepherd [:sheppy]]

Docs updated:

https://developer.mozilla.org/en-US/docs/Web/API/URL/createObjectURL
https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/srcObject
https://developer.mozilla.org/en-US/docs/Web/API/URL/revokeObjectURL

Also submitted BCD PR #2149 to update compatibility tables with notes referring to https://developer.mozilla.org/en-US/docs/Web/API/URL/createObjectURL#Using_object_URLs_for_media_streams for details.

Comment 16

[Andrea Marchesini [:baku]]

This issue has been discussed on dev-platform. I didn't know when Chrome was planning to deprecate this feature.