Let POMTP tiling with skia on windows ride the trains

RESOLVED FIXED in Firefox 62

Status

()

enhancement
P3
normal
RESOLVED FIXED
a year ago
8 months ago

People

(Reporter: rhunt, Assigned: rhunt)

Tracking

(Blocks 1 bug, {feature})

unspecified
mozilla62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(relnote-firefox 62+, firefox62+ fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

(Assignee)

Description

a year ago
This is the bug to track letting bug 1454978 ride the trains.
(Assignee)

Updated

a year ago
Depends on: 1457007
(Assignee)

Updated

a year ago
Depends on: 1459767
(Assignee)

Updated

a year ago
Depends on: 1458480
Manual testing passed.
(Assignee)

Comment 2

11 months ago
With all outstanding bugs resolved and manual testing passed, I think we are good to let this ride the trains.
Attachment #8981481 - Flags: review?(dbolter)
Comment on attachment 8981481 [details] [diff] [review]
pomtp-trains.patch

Review of attachment 8981481 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #8981481 - Flags: review?(dbolter) → review+

Comment 4

11 months ago
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c587c9fb7de
Let tiled parallel skia on unaccelerated windows ride the trains. r=davidb

Comment 5

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9c587c9fb7de
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
This already landed, but we can track it to make sure to catch if it reopens.
(Assignee)

Updated

10 months ago
Blocks: omtp
Is this something you'd like in the release notes for 62?
Flags: needinfo?(dbolter)
Yes and thanks for catching Liz. Probably best to get a one-liner straight from Ryan.
Flags: needinfo?(dbolter) → needinfo?(rhunt)
(Assignee)

Comment 9

10 months ago
I looked at some past release notes for OMTP and wrote one. Feel free to workshop it.

"Improved graphics rendering using Parallel-Off-Main-Thread Painting (P-OMTP) for Windows users without accelerated hardware (P-OMTP for OSX was released in Firefox 60)"

Note: I looked back at the release notes for Firefox 60 and noticed that P-OMTP being enabled on OSX was not mentioned there. It must have gotten lost somehow. It was originally enabled in bug 1430793.
Flags: needinfo?(rhunt)
Added to Firefox 62 release notes.
You need to log in before you can comment on or make changes to this bug.