1455075 - ContentParent::RecvShowAlert null-ptr-defers is aAlert is null

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect, P1)

Description

[Alex Gaynor [:Alex_Gaynor]]

It derefs the argument unconditionally. Prior to bug 1443954 the value was passed as a const reference, so it couldn't be null, but that change made it nullable.

Fuzzing triggers the null deref crash pretty easily.

Comment 1

[Alex Gaynor [:Alex_Gaynor]]

Attachment: Bug 1455075 - handle a null argument in ContentParent::RecvShowAlert;

Review commit: https://reviewboard.mozilla.org/r/237702/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/237702/

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8969014 [details]
Bug 1455075 - handle a null argument in ContentParent::RecvShowAlert;

https://reviewboard.mozilla.org/r/237702/#review243762

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4261c7933ce9
handle a null argument in ContentParent::RecvShowAlert; r=mystor

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4261c7933ce9