User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0 Build ID: 20180327223059 Steps to reproduce: - Visit any GitHub repository. - Open Page Info and then the Permissions tab. - Uncheck "Use Default" for the new "Override Keyboard Shortcuts" permission and select "Block". - Press the / (i.e. slash) key. Actual results: GitHub captures the keydown event and then focus it's own search box. Expected results: GitHub shouldn't be able to override this shortcut: instead, the Quick Find bar should be displayed at the bottom.
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0 20180418112600
Status: UNCONFIRMED → NEW
Has Regression Range: --- → irrelevant
Has STR: --- → yes
Component: Untriaged → Event Handling
Ever confirmed: true
OS: Unspecified → All
Product: Firefox → Core
Hardware: Unspecified → All
Summary: New Override Keyboard Shortcuts permission doesn't work as expected → Website can capture / (Quick Find bar shortcut) even with Override Keyboard Shortcuts set to Block
We don't block printable characters as they need to be able to be entered on the page, only shortcut keys get blocked. You can use Ctrl/Cmd+F for find at least.
Slash and Quick Find are much more convenient than Ctrl/Cmd+F. I'm frustrated continually by their lack when using things besides Firefox, less, vim, and similar. If it's impossible to make slash and Quick Find work due to the design of the web, that's a sad but sufficient answer. Pointing out that Ctrl/Cmd+F are available is not a sufficient answer for the reason just stated.
(In reply to Neil Deakin from comment #2) > We don't block printable characters as they need to be able to be entered on > the page, only shortcut keys get blocked. You can use Ctrl/Cmd+F for find at > least. How so? slash displays the "Quick find" bar. It's extremely counterintuitive that a website can still hijack this functionally when the user explicitly configured the browser to not allow this kind of behavior. The fact that the slash key prints a slash character when some sort of text box in the DOM is focused is unrelated to this particular issue. Thanks!
Component: Event Handling → Find Toolbar
Product: Core → Toolkit
This is by design and very hard to implement differently. Since this has worked like this from the very beginning and there's no sign that QuickFind and its `/` and `'` shortcuts will be removed any time soon (if ever). Therefore I think it's appropriate to close this, since there's nothing actionable left.
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → WONTFIX
I agree, '/' functions as a shortcut when a text box isn't focused. Therefore it's a shortcut and must not be overridden. And yeah, when you block github from getting shortcut keys for some reason backspace breaks. So: 1) '/' should always do quick find when a text box is not focused. 2) What's up with backspace? Maybe some broken JS on github? 3) This permission should be more granular, allowing me to block github's access to '/' and not Backspace. Can we reopen this bug please?
You need to log in before you can comment on or make changes to this bug.