Blocking "Override keyboard shortcuts" doesn't block overriding
Categories
(Toolkit :: Find Toolbar, defect)
Tracking
()
People
(Reporter: akkzilla, Unassigned)
Details
Go to any github page.
Type / intending to start a firefox search.
Instead, github pops up its own search box. So,
Tools->Page info
Choose the Permissions tab
Under "Override keyboard shortcuts", un-check "Use Default" and check Block.
Try github again: / is still overridden, even after a browser restart.
See related bug 1461533, which may be the same issue though it's for a specific, and different, website and key.
|
||
Comment 1•4 years ago
|
||
FindBar handles shortcut key with a keypress event listener so that it's out of scope of the "Override keyboard shortcuts" feature for now.
https://searchfox.org/mozilla-central/rev/13d69189a8abfc5064fe44944550b9b6eb4544f5/toolkit/actors/FindBarChild.jsm#90
Perhaps, FindBar should register keyboard shortcuts with XUL <key> and handle it something special.
|
||
Comment 2•4 years ago
|
||
Yes, override keyboard shortcuts is implemented by preventing keys for defined browser shortcuts being sent to the website content process, but it isn't really feasible to do this for the '/' key as it would prevent entering text.
Note that Ctrl/Cmd+F will open the findbar when Override keyboard shortcuts is used.
Description
•