1455337 - Language packs should be compatible with major.minor.* rather than declaring the .sec version

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Justin Wood (:Callek)]

AMO needs to enter the application version for every Firefox release at this time, and in doing so they don't usually enter .sec versions, as these versions are exposed to addon devs in UX where they can specify outside of the xpi what versions of Firefox they are compatible with.

Language packs however set min version to things like 59.0.2 which AMO doesn't know about.

AMO will also fail to validate an .xpi with an unknown min version.

Comment 2

[Phabricator Automation]

Attachment: Bug 1455337 - Set min version appropriately for language packs. r=glandium

AMO needs to enter the application version for every Firefox release at this time, and in doing so they don't usually enter .sec versions, as these versions are exposed to addon devs in UX where they can specify outside of the xpi what versions of Firefox they are compatible with.

Language packs however set min version to things like 59.0.2 which AMO doesn't know about.

AMO will also fail to validate an .xpi with an unknown min version.

This code logic is slightly compounded by the fact that SeaMonkey uses these codepaths as well, so we need to account for it here.

Comment 3

[Phabricator Automation]

Comment on attachment 8972760 [details]
Bug 1455337 - Set min version appropriately for language packs. r=glandium

Gregory Szorc [:gps] has approved the revision.

https://phabricator.services.mozilla.com/D1112

Comment 4

[Jordan Lund (:jlund)]

https://hg.mozilla.org/releases/mozilla-esr60/rev/f7f40b6cf8cfc0d7a84b585a1e6d27ad14dc06c4
Bug 1455337 - Set min version appropriately for language packs. r=gps, a=testing

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Followup fix:
https://hg.mozilla.org/releases/mozilla-release/rev/03d4f76300bedeffd47c726ce7fee0221873da11
https://hg.mozilla.org/releases/mozilla-esr60/rev/efbcc205a0d3562691bf62bb0cb55bb7e891e8ff

Comment 6

[Ryan VanderMeulen [:RyanVM]]

For posterity, Jordan's m-r push:
https://hg.mozilla.org/releases/mozilla-release/rev/ea9a60e5c79e864167d495ce900d34b5c74e99e5

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/062628e67ca3
Set min version appropriately for language packs. r=gps

Comment 8

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/062628e67ca3

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Looks like Callek pushed it to Beta also.
https://hg.mozilla.org/releases/mozilla-beta/rev/4f8ff11754a5