Remove checkState from nsIDOMXULCheckboxElement and nsIDOMXULButtonElement

RESOLVED FIXED in Firefox 61

Status

()

enhancement
RESOLVED FIXED
a year ago
4 months ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

(Blocks 1 bug)

unspecified
mozilla61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

a year ago
This is only ever used to check for CHECKSTATE_MIXED which in turn is used to set mozilla::a11y::states::MIXED

- https://searchfox.org/mozilla-central/search?q=%3A%3Acheckstate&path=

However, there's only one place we ever set that state - in the about:addons 'Recent Updates' list. The mixed state is set when the list is ascending, which doesn't seem right. The element is 'checked' whether it's ascending or descending. https://searchfox.org/mozilla-central/rev/59a9a86553e9bfd9277202748ff791fd9bc0713b/toolkit/mozapps/extensions/content/extensions.xml#302

If we get rid of that consumer, I believe we can remove all the idl and accessibility code handling this case, which should help unblock switching to an actual html:input (since the only remaining attribute on nsIDOMXULCheckboxElement.idl after this and Bug 1455359 will be 'checked').
(Assignee)

Comment 1

a year ago
Andrew - we could update the checkState to always be '1' for the selected header. But.. could we just remove this UI? The default sort order is by Date (most recent first) which seems like the correct order for a 'recent updates' list.
Flags: needinfo?(aswan)
(Assignee)

Updated

a year ago
Blocks: 1455433
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 4

a year ago
mozreview-review
Comment on attachment 8969410 [details]
Bug 1455392 - Remove checkState from nsIDOMXULCheckboxElement and nsIDOMXULButtonElement

https://reviewboard.mozilla.org/r/238164/#review243884

r=me for a11y part
Attachment #8969410 - Flags: review?(surkov.alexander) → review+
(In reply to Brian Grinstead [:bgrins] from comment #1)
> Andrew - we could update the checkState to always be '1' for the selected
> header. But.. could we just remove this UI? The default sort order is by
> Date (most recent first) which seems like the correct order for a 'recent
> updates' list.

Works for me, ccing Emanuela and Markus from UX so they are not surprised.
Odds are high that somebody will pop up in the next few weeks and say that they have a hundred extensions installed and now they can't effectively find things in recent updates, but I don't think that should stand in the way of de-XBLing
Flags: needinfo?(aswan)

Comment 6

a year ago
mozreview-review
Comment on attachment 8969409 [details]
Bug 1455392 - Remove sortable UI in about:addons recent updates;

https://reviewboard.mozilla.org/r/238162/#review243886
Attachment #8969409 - Flags: review?(aswan) → review+
(Assignee)

Comment 7

a year ago
Posted image sort-headers.png
For reference - this is the UI we are talking about
(Assignee)

Updated

a year ago
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 10

a year ago
Comment on attachment 8969410 [details]
Bug 1455392 - Remove checkState from nsIDOMXULCheckboxElement and nsIDOMXULButtonElement

Requesting review for the dom idl changes
Attachment #8969410 - Flags: review?(bzbarsky)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 13

a year ago
mozreview-review
Comment on attachment 8969410 [details]
Bug 1455392 - Remove checkState from nsIDOMXULCheckboxElement and nsIDOMXULButtonElement

https://reviewboard.mozilla.org/r/238164/#review244262

r=me, but you don't have to rev iids...
Attachment #8969410 - Flags: review?(bzbarsky) → review+

Comment 14

a year ago
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8a24709c044b
Remove sortable UI in about:addons recent updates;r=aswan
https://hg.mozilla.org/integration/autoland/rev/e166407fe8b0
Remove checkState from nsIDOMXULCheckboxElement and nsIDOMXULButtonElement;r=bz,surkov

Comment 15

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/8a24709c044b
https://hg.mozilla.org/mozilla-central/rev/e166407fe8b0
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL

Updated

4 months ago
Depends on: 1514186
You need to log in before you can comment on or make changes to this bug.