1455429 - Drag and drop of message(s) to Desktop and Finder stopped working in macOS High Sierra

Status: RESOLVED WORKSFORME

(Thunderbird :: OS Integration, defect)

Description

[Lee Binder]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180323154952

Steps to reproduce:

TB 52.7.0, macOS High Sierra 10.13.4. Neither dragging an email to the Desktop nor into a Finder window works anymore. I see the drag handler, even the Finder window signals activation with the blue highlight frame, but on drop nothing happens.

Drag & drop of an attachment to Desktop and Finder windows does still work, so it is no permission issue.

This also does not work anymore in a brand-new profile with no add-ons. Neither does it matter if the email is in the Inbox or in Sent.

This worked before in older versions of TB in older versions of OS X. This happens to be the first version of TB I run in High Sierra. Not sure if this bug also occurs in macOS Sierra and below with TB 52.7.0.

Same bug with TB 45.8.0 and 60.0b3, but working fine as always with TB 52.7.0 32bit in Windows 10 64 bit.

For now I am right clicking, Save as.

I'm willing to receive a beta version for testing if needed. Thank you for looking into this.


Actual results:

Nothing


Expected results:

email message visible where dragged (Finder or Desktop) as .eml file.

Comment 1

[Jorg K (CEST = GMT+2)]

Richard, can you confirm?

Comment 2

[Richard Marti (:Paenglab)]

Yes, doesn't work with TB 52 and Daily.

Comment 3

[Lee Binder]

Hello Richard, Jorg

I again tried to drag/ drop as used to from Windows and realized this still is not working in TB 52.9.1. Bummer. Is it possible to assign this bug? Since drag & drop of an attachment works, the code is known, and it might be a really quick copy/ paste of the correct code from the attachment code module.

I am willing to beta test.

Ever grateful for your work on Thunderbird
Lee

Comment 4

[Jorg K (CEST = GMT+2)]

How about TB 60 available now at www.thunderbird.net?

Comment 5

[Lee Binder]

oh, thanks for the pointer, I was not aware it's already out in the release channel (did not appear as update from within TB yet). Downloaded, tested - no, regression remains :(

It looks as if this bug won't get resolved unless assigned.

Comment 6

[Jorg K (CEST = GMT+2)]

Sadly we don't have (m)any Mac developers. If I read comment #0 correctly, none of TB 45, TB 52 and TB 60 work on macOS High Sierra 10.13.4, whereas the feature works on other version on macOS. So it's not that we broke drag&drop at some stage, which would be a regression, it more like *all* TB version are incompatible with "High Sierra". Correct?

NI'ing a Mac developer who might be able to help.

Comment 7

[Lee Binder]

No, not correct. ALL 10.13.5+ (Sierra, High Sierra) related code incompatibilities got solved, incl. drag/ drop to Finder (incl. Desktop). I remember drag/ drop attachment was not working either with some older version of TB in High Sierra I was still using first (45.8.0). Updated to the latest from the 50s line, drag/drop attachment to Finder worked. It's just that the refined code from the attachment module was never implemented to the code for the mail window (Inbox, Sent etc.), that's it.

Hope it's all clear now :)

Comment 8

[Javi Rueda :javirid]

I am no longer willing to collaborate on this project.

Thank you, Jorg, for considering me to help here.

Comment 9

[Wayne Mery (:wsmwk)]

Monterey 12.5 using Thunderbird 109 beta fails ...

21:57:54.105 Uncaught
Exception { name: "NS_ERROR_FAILURE", message: "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsITransferable.getTransferData]", result: 2147500037, filename: "chrome://messenger/content/msgMail3PaneWindow.js", lineNumber: 1853, columnNumber: 0, data: null, stack: "getFlavorData@chrome://messenger/content/msgMail3PaneWindow.js:1853:19\n", location: XPCWrappedNative_NoHelper }
msgMail3PaneWindow.js:1853

Comment 10

[b8]

https://github.com/Betterbird/thunderbird-patches/blob/main/102/bugs/1455429-fix-drag-msg-to-folder-mac.patch

Comment 11

[Lee Binder]

wow, thank you b8 and the Betterbird team !!

Comment 12

[BB]

Attachment: 1455429-fix-drag-msg-to-folder-mac.patch

Comment 13

[Magnus Melin [:mkmelin] (away, back Aug 4)]

Comment on attachment 9331106 [details] [diff] [review]
1455429-fix-drag-msg-to-folder-mac.patch

Review of attachment 9331106 [details] [diff] [review]:
-----------------------------------------------------------------

I don't have a mac to test. But, threadPane.js is basically dead code by now (used in the search dialog only)

Comment 14

[BB]

Comment on attachment 9331106 [details] [diff] [review]
1455429-fix-drag-msg-to-folder-mac.patch

Thanks for checking the patch. We can confirm that ThreadPaneOnDragStart (threadPane.js) is not invoked when dragging from the thread pane. It is invoked when dragging from the folder search dialogue, and that drag is broken. Is there a bug for it?

Comment 15

[BB]

Attachment: 1455429-fix-drag-msg-to-folder-mac.patch

Please try on Mac.

Comment 16

[Richard Marti (:Paenglab)]

Comment on attachment 9331364 [details] [diff] [review]
1455429-fix-drag-msg-to-folder-mac.patch

With actual Daily I can dnd messages to the desktop or Finder but not attachments. The patch makes it worse and dnd of messages fails too.

Comment 17

[BB]

Comment on attachment 9331364 [details] [diff] [review]
1455429-fix-drag-msg-to-folder-mac.patch

Thanks for testing. I dragging messages to the OS desktop or OS folder works, this bug can be closed. Can someone please file a bug for not being able to drag attachments to the desktop. That works on Windows.

Comment 18

[Magnus Melin [:mkmelin] (away, back Aug 4)]

We have bug 1827685