1455490 - Crash in static void webrender::resource_cache::ResourceCache::block_until_all_resources_added (Invalid vector image key)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Darkspirit]

Seen on Socorro. 2 reports from Win10, probably from the same user.

bp-092f1f0e-c2f8-49c9-a41c-c5f930180420 build 20180419100148.
> Invalid vector image key

Comment 1

[Dzmitry Malyshau [:kvark]]

Looks to be originating from Gecko (not WR): the blob image renderer (provided by Gecko) refuses to recognize one of the image keys pending an update.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

This might be fixed by bug 1453801

Comment 3

[Darkspirit]

Seen on Socorro.
bp-c22698a5-2e94-41b4-a750-6910b0180425 build 20180424220100 MacOS

Comment 4

[bull500]

https://www.google.com/search?q=kochi+weather&ie=utf-8&oe=utf-8&client=firefox-b    


Click on any other days weather info casuses FFNightly crashes.

Comment 5

[Marcia Knous [:marcia]]

static void webrender::resource_cache::ResourceCache::block_until_all_resources_added signature shows 71 crashes/27 installs in the last 7 days (although I don't see crashes after May 29th). 63% of the users crashed in under a minute.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

This was the #1 WR-specific topcrash over the last 7 days, so we should definitely fix this before turning on WR in nightly. That being said, there are no crashes after May 29th as Marcia said, so maybe it's fixed already.

Comment 7

[bull500]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #6)
> This was the #1 WR-specific topcrash over the last 7 days, so we should
> definitely fix this before turning on WR in nightly. That being said, there
> are no crashes after May 29th as Marcia said, so maybe it's fixed already.

no its still happening consistently for me FF 62.0a1 (2018-05-31) (64-bit)

https://crash-stats.mozilla.com/report/index/8f934e47-0a49-42d6-bb83-9c5c50180531  

https://crash-stats.mozilla.com/report/index/da3184c6-e3fe-48b0-bc47-ae0570180531 

Same situation:
https://www.google.com/search?q=kochi+weather&ie=utf-8&oe=utf-8&client=firefox-b    


Click on any other days weather info casuses FFNightly crashes.

Comment 8

[Dzmitry Malyshau [:kvark]]

> Click on any other days weather info casuses FFNightly crashes.

ftr, FF nightly doesn't crash for me on Linux/Intel when doing this.

Comment 9

[bull500]

(In reply to Dzmitry Malyshau [:kvark] from comment #8)
> > Click on any other days weather info casuses FFNightly crashes.
> 
> ftr, FF nightly doesn't crash for me on Linux/Intel when doing this.

You're right. 

Offending addon - https://addons.mozilla.org/en-US/firefox/addon/facebook-container/  

Problem start after enabling it, restarting and clicking on the link

Comment 11

[Darkspirit]

(In reply to Eitan Isaacson [:eeejay] from comment #0)
> 1. Go to https://twoblindbrothers.com/pages/curing-blindness-mobile
> 2. Bring up the svg in the DOM inspector.

Confirmed. I had to zoom in and out and it worked:
bp-adebad6b-01a2-454b-86d3-e90f50180531	31.05.18 19:51
bp-60f72169-1aa4-494f-b4b9-16cef0180531	31.05.18 19:50

Comment 12

[Sotaro Ikeda [:sotaro]]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #11)
> (In reply to Eitan Isaacson [:eeejay] from comment #0)
> > 1. Go to https://twoblindbrothers.com/pages/curing-blindness-mobile
> > 2. Bring up the svg in the DOM inspector.

I could reproduce the crash with Comment 11 on my Win10 PC(P50).

Comment 13

[Kartikaya Gupta (email:[e-mail])]

I can also reproduce the crash. I am investigating.

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Seems to be a pretty straightforward issue. I wrote a patch with logging and got the output, both of which can be seen at [1]. What seems to be happening is that the resource cache decides to not request a blob at [2] but it leaves the `request` in `self.pending_image_requests` (from [3]). So the blob renderer has no idea that it needs to render this request, and then later the resource cache goes to resolve the request and gets back an InvalidKey. I think the resource_cache should probably be removing the request from `self.pending_image_requests` if it decides to not send the request. I'll test that change.


[1] https://gist.github.com/staktrace/74e4721229aa3f39885cde69a2ead7e9
[2] https://searchfox.org/mozilla-central/rev/83a923ef7a3b95a516f240a6810c20664b1e0ac9/gfx/webrender/src/resource_cache.rs#664
[3] https://searchfox.org/mozilla-central/rev/83a923ef7a3b95a516f240a6810c20664b1e0ac9/gfx/webrender/src/resource_cache.rs#647

Comment 15

[Kartikaya Gupta (email:[e-mail])]

This should be fixed in the next nightly. I'll leave it open for a few days and check crash-stats.

Comment 16

[Kartikaya Gupta (email:[e-mail])]

Last buildid that had this crash is 20180604100129