Closed Bug 1455680 Opened 2 years ago Closed 2 years ago

Notify document-element-inserted in XUL documents

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(1 file)

Spinning this out of Bug 1411707 since it'll also help for Bug 1455649.
Assignee: nobody → bgrinstead
Blocks: 1455649
Status: NEW → ASSIGNED
Comment on attachment 8969716 [details]
Bug 1455680 - Notify document-element-inserted in XUL documents;

https://reviewboard.mozilla.org/r/238516/#review244268

r=me, but can you please add a nsContentUtils::IsSafeToRunScript() assert in NotifyDocElementCreated?  And it that assert fails with this patch, use nsDocElementCreatedNotificationRunner as a scriptrunner as needed.
Attachment #8969716 - Flags: review?(bzbarsky) → review+
Comment on attachment 8969716 [details]
Bug 1455680 - Notify document-element-inserted in XUL documents;

Re-requesting review just to confirm I've done Comment 2 correctly
Attachment #8969716 - Flags: review+ → review?(bzbarsky)
Comment on attachment 8969716 [details]
Bug 1455680 - Notify document-element-inserted in XUL documents;

https://reviewboard.mozilla.org/r/238516/#review244336
Attachment #8969716 - Flags: review?(bzbarsky) → review+
Looks like we'll also need to convert the XML sink calls to the scriptrunner given all the assertion failures here https://treeherder.mozilla.org/#/jobs?repo=try&revision=9008183fd14fe422e08b4e25522e4daa75997038
In that case, it might be simplest to just put the scriptrunner bit inside the shared method like that pastebin you showed me on IRC instead of having all the callers doing it manually.
(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #7)
> In that case, it might be simplest to just put the scriptrunner bit inside
> the shared method like that pastebin you showed me on IRC instead of having
> all the callers doing it manually.

Turns out there were only two other callers (XML and XSLT). I updated the patch to include them - will see how try looks with that change.
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/427e3dce92c2
Notify document-element-inserted in XUL documents;r=bz
https://hg.mozilla.org/mozilla-central/rev/427e3dce92c2
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.