1455680 - Notify document-element-inserted in XUL documents

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Brian Grinstead [:bgrins]]

Spinning this out of Bug 1411707 since it'll also help for Bug 1455649.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1455680 - Notify document-element-inserted in XUL documents;

We'll want to use this event to inject scripts before other scripts run
in XUL documents. It already fires in HTML documents.

Review commit: https://reviewboard.mozilla.org/r/238516/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238516/

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8969716 [details]
Bug 1455680 - Notify document-element-inserted in XUL documents;

https://reviewboard.mozilla.org/r/238516/#review244268

r=me, but can you please add a nsContentUtils::IsSafeToRunScript() assert in NotifyDocElementCreated?  And it that assert fails with this patch, use nsDocElementCreatedNotificationRunner as a scriptrunner as needed.

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8969716 [details]
Bug 1455680 - Notify document-element-inserted in XUL documents;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/238516/diff/1-2/

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8969716 [details]
Bug 1455680 - Notify document-element-inserted in XUL documents;

Re-requesting review just to confirm I've done Comment 2 correctly

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8969716 [details]
Bug 1455680 - Notify document-element-inserted in XUL documents;

https://reviewboard.mozilla.org/r/238516/#review244336

Comment 6

[Brian Grinstead [:bgrins]]

Looks like we'll also need to convert the XML sink calls to the scriptrunner given all the assertion failures here https://treeherder.mozilla.org/#/jobs?repo=try&revision=9008183fd14fe422e08b4e25522e4daa75997038

Comment 7

[Boris Zbarsky [:bzbarsky]]

In that case, it might be simplest to just put the scriptrunner bit inside the shared method like that pastebin you showed me on IRC instead of having all the callers doing it manually.

Comment 8

[Brian Grinstead [:bgrins]]

Comment on attachment 8969716 [details]
Bug 1455680 - Notify document-element-inserted in XUL documents;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/238516/diff/2-3/

Comment 9

[Brian Grinstead [:bgrins]]

(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #7)
> In that case, it might be simplest to just put the scriptrunner bit inside
> the shared method like that pastebin you showed me on IRC instead of having
> all the callers doing it manually.

Turns out there were only two other callers (XML and XSLT). I updated the patch to include them - will see how try looks with that change.

Comment 10

[Brian Grinstead [:bgrins]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=762d0f3c402488ba122d870edcf6ff0fc06b00a0

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/427e3dce92c2
Notify document-element-inserted in XUL documents;r=bz

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/427e3dce92c2