|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
After we have Custom Elements in XUL, <stringbundle> would be a simple binding  to migrate as a way to figure out what the migration process can look like before attempting more complex bindings. For example, we still need to figure out how to register the Custom Element on the window. Should we register a <script> for every XUL doc  that creates a stringbundle? And, should we preprocess all Custom Element definitions into a single file or let documents opt in to only elements they use? : http://searchfox.org/mozilla-central/source/toolkit/content/widgets/stringbundle.xml : http://searchfox.org/mozilla-central/search?q=%3Cstringbundle&path=xul%24
Need to confirm that "XStringBundle" doesn't show up as a directory in the debugger after the change, and remove the relevant debugger code if it's not a problem anymore (see http://searchfox.org/mozilla-central/search?q=XStringBundle and Bug 843609).
Going to spend some time looking into this
Have a try push working around an issue for now by removing disconnectedCallback to avoid widespread leaks (https://bugzilla.mozilla.org/show_bug.cgi?id=1404420#c30). https://treeherder.mozilla.org/#/jobs?repo=try&revision=d178e7b50b0eb456c70c44e631f73f3bab53fe6d. The approach of loading the script with the subscript loader on the "chrome-document-global-created" message seems to work, but will need to do some talos runs.