Migrate <stringbundle> from a XBL binding to a Custom Element

ASSIGNED
Assigned to

Status

()

Core
XBL
P3
normal
ASSIGNED
28 days ago
16 days ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

(Depends on: 2 bugs, Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

28 days ago
After we have Custom Elements in XUL, <stringbundle> would be a simple binding [0] to migrate as a way to figure out what the migration process can look like before attempting more complex bindings.

For example, we still need to figure out how to register the Custom Element on the window. Should we register a <script> for every XUL doc [0] that creates a stringbundle? And, should we preprocess all Custom Element definitions into a single file or let documents opt in to only elements they use?

[0]: http://searchfox.org/mozilla-central/source/toolkit/content/widgets/stringbundle.xml
[1]: http://searchfox.org/mozilla-central/search?q=%3Cstringbundle&path=xul%24
(Assignee)

Comment 1

28 days ago
Need to confirm that "XStringBundle" doesn't show up as a directory in the debugger after the change, and remove the relevant debugger code if it's not a problem anymore (see http://searchfox.org/mozilla-central/search?q=XStringBundle and Bug 843609).
See Also: → bug 843609
(Assignee)

Comment 2

28 days ago
Going to spend some time looking into this
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
(Assignee)

Comment 4

27 days ago
Have a try push working around an issue  for now by removing disconnectedCallback to avoid widespread leaks (https://bugzilla.mozilla.org/show_bug.cgi?id=1404420#c30). https://treeherder.mozilla.org/#/jobs?repo=try&revision=d178e7b50b0eb456c70c44e631f73f3bab53fe6d.

The approach of loading the script with the subscript loader on the "chrome-document-global-created" message seems to work, but will need to do some talos runs.
(Assignee)

Updated

21 days ago
Depends on: 1413418
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.