Closed Bug 1455708 Opened 2 years ago Closed 2 years ago

Require Python 3.5+ on Windows builds

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: gps, Assigned: gps)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1451065 made Python 3.5+ required on Linux. We punted on Windows because it was non-trivial.

Let's get this working with Windows.
Comment on attachment 8969751 [details]
Bug 1455708 - Find Python 3 in MozillaBuild, require Python 3 everywhere;

https://reviewboard.mozilla.org/r/238560/#review244760

::: build/moz.configure/init.configure:375
(Diff revision 3)
>  
> -@depends('PYTHON3', 'MOZ_AUTOMATION')
> +@depends('PYTHON3', 'MOZILLABUILD')
>  @checking('for Python 3',
>            callback=lambda x: '%s (%s)' % (x.path, x.str_version) if x else 'no')
>  @imports(_from='__builtin__', _import='Exception')
>  @imports('platform')

I think 'platform' is no longer required.

::: build/moz.configure/init.configure:389
(Diff revision 3)
>              version = python_executable_version(python).version
>          except Exception as e:
>              raise FatalCheckError('could not determine version of PYTHON '
>                                    '(%s): %s' % (python, e))
>  
>          if version < (3, 5, 0):

Do we need to repeat this check in the mozillabuild block? Or should it be moved outside?

::: build/moz.configure/init.configure:395
(Diff revision 3)
>              raise FatalCheckError('PYTHON3 must point to Python 3.5 or newer; '
>                                    '%d.%d found' % (version[0], version[1]))
> +    elif mozillabuild:
> +        # MozillaBuild provides a Python 3.
> +        python = '%s/python3/python3.exe' % mozillabuild
> +        python = python.replace('\\', '/')

Can we use a mozpath function here instead?
Attachment #8969751 - Flags: review+
Attachment #8969751 - Flags: review?(core-build-config-reviews)
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1e78f2ccb865
Find Python 3 in MozillaBuild, require Python 3 everywhere; r=mshal
https://hg.mozilla.org/mozilla-central/rev/1e78f2ccb865
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.