1455708 - Require Python 3.5+ on Windows builds

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Gregory Szorc [:gps]]

Bug 1451065 made Python 3.5+ required on Linux. We punted on Windows because it was non-trivial.

Let's get this working with Windows.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1455708 - Find Python 3 in MozillaBuild, require Python 3 everywhere;

We previously did not require Python 3.5+ everywhere because we failed
to detect Python 3.5 on Windows in CI. That's because CI isn't using
start-shell.bat and it hasn't yet updated PATH to include
%MOZILLABUILD%\python3.

We shouldn't need to teach CI to have PATH contain everything in
MozillaBuild. This commit teaches moz.configure to automatically use
MozillaBuild's Python 3 if we're running in MozillaBuild.

Since we can now detect Python 3 everywhere in CI, we make Python 3.5+
required on all build configurations.

Review commit: https://reviewboard.mozilla.org/r/238560/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238560/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8969751 [details]
Bug 1455708 - Find Python 3 in MozillaBuild, require Python 3 everywhere;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/238560/diff/1-2/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8969751 [details]
Bug 1455708 - Find Python 3 in MozillaBuild, require Python 3 everywhere;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/238560/diff/2-3/

Comment 4

[Michael Shal [:mshal]]

Comment on attachment 8969751 [details]
Bug 1455708 - Find Python 3 in MozillaBuild, require Python 3 everywhere;

https://reviewboard.mozilla.org/r/238560/#review244760

::: build/moz.configure/init.configure:375
(Diff revision 3)
>  
> -@depends('PYTHON3', 'MOZ_AUTOMATION')
> +@depends('PYTHON3', 'MOZILLABUILD')
>  @checking('for Python 3',
>            callback=lambda x: '%s (%s)' % (x.path, x.str_version) if x else 'no')
>  @imports(_from='__builtin__', _import='Exception')
>  @imports('platform')

I think 'platform' is no longer required.

::: build/moz.configure/init.configure:389
(Diff revision 3)
>              version = python_executable_version(python).version
>          except Exception as e:
>              raise FatalCheckError('could not determine version of PYTHON '
>                                    '(%s): %s' % (python, e))
>  
>          if version < (3, 5, 0):

Do we need to repeat this check in the mozillabuild block? Or should it be moved outside?

::: build/moz.configure/init.configure:395
(Diff revision 3)
>              raise FatalCheckError('PYTHON3 must point to Python 3.5 or newer; '
>                                    '%d.%d found' % (version[0], version[1]))
> +    elif mozillabuild:
> +        # MozillaBuild provides a Python 3.
> +        python = '%s/python3/python3.exe' % mozillabuild
> +        python = python.replace('\\', '/')

Can we use a mozpath function here instead?

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8969751 [details]
Bug 1455708 - Find Python 3 in MozillaBuild, require Python 3 everywhere;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/238560/diff/3-4/

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 8969751 [details]
Bug 1455708 - Find Python 3 in MozillaBuild, require Python 3 everywhere;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/238560/diff/4-5/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e78f2ccb865
Find Python 3 in MozillaBuild, require Python 3 everywhere; r=mshal

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/1e78f2ccb865