1455743 - async-scene-building: Crash in static void webrender::resource_cache::ResourceCache::request_image

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Darkspirit]

New on Socorro.

bp-c6432113-f807-49b6-882c-d0a240180420 build 2018-04-20_100056 Win10
> MOZ_CRASH Reason 	called `Option::unwrap()` on a `None` value

bug 1413571 had the same crash reason.
https://crash-stats.mozilla.com/search/?moz_crash_reason=~called%20%60Option%3A%3Aunwrap%28%29%60%20on%20a%20%60None%60%20value&app_notes=~WR%2B&product=Firefox&date=%3E%3D2018-01-20T21%3A33%3A34.000Z&date=%3C2018-04-20T22%3A33%3A34.000Z&_sort=-date&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#crash-reports

Comment 1

[Josh Matthews [:jdm]]

I can reproduce this by visiting google.co.nz and searching for "auckland forecast" in the latest mac nightly.

Comment 3

[Darkspirit]

Maximize the window: Crash when zooming in & out by Ctrl + mousewheel.
bp-56be35c4-c30d-41ac-b174-a63140180424

mozregression --good 2018-04-18 --bad 2018-04-21 --pref gfx.webrender.all:true startup.homepage_welcome_url:'https://www.amazon.co.jp/gp/offer-listing/B00008BBBX'
> 6:13.81 INFO: Last good revision: 69008e17de668cca67e7a27c73245961fe285d23
> 6:13.81 INFO: First bad revision: c3da365d2916344fac340eeab98319089915e46f
> 6:13.81 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=69008e17de668cca67e7a27c73245961fe285d23&tochange=c3da365d2916344fac340eeab98319089915e46f

> c3da365d2916	Kartikaya Gupta — Bug 1391318 - Automatically enable async scene building with webrender.all. r=jrmuizel


mozregression --repo autoland --launch c3da365d2916344fac340eeab98319089915e46f -B debug --pref gfx.webrender.all:true startup.homepage_welcome_url:'https://www.amazon.co.jp/gp/offer-listing/B00008BBBX'
>  0:49.68 INFO: thread 'WRRenderBackend#1' panicked at 'called `Option::unwrap()` on a `None` value', libcore/option.rs:335:21

Comment 5

[Kartikaya Gupta (email:[e-mail])]

This (at least the subset of the issues that resulted from turning on async scene building) should be fixed by servo/webrender#2695 based on the comment by nical at https://github.com/servo/webrender/issues/2689#issuecomment-384576217

Comment 6

[Josh Matthews [:jdm]]

I can reproduce this consistently by loading https://stardewvalley.net/stardew-valley-v1-3-beta/ in the latest nightly on macOS.

Comment 7

[Dylan Hardison [:dylan] (he/him)]

I was getting this from visiting jvns.ca in nightly on OSX with webrender enabled.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

I expect this should be fixed in the next Nightly build, or whenever bug 1459935 makes it to central. With the current tree closure I'm not sure when that will happen.

Comment 9

[Darkspirit]

STR from comment 3:

mozregression --find-fix --bad 2018-04-24 --good 2018-05-12 --pref gfx.webrender.all:true startup.homepage_welcome_url:'https://www.amazon.co.jp/gp/offer-listing/B00008BBBX'
> 11:52.62 INFO: First good revision: 84f298282f592fceb8f5f5bb9f3bbfafdf3b7d60
> 11:52.62 INFO: Last bad revision: fc4f2d0a1dfb663404260c36c1b5f85fc1b14f96
> 11:52.62 INFO: Pushlog:
> https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fc4f2d0a1dfb663404260c36c1b5f85fc1b14f96&tochange=84f298282f592fceb8f5f5bb9f3bbfafdf3b7d60

> 84f298282f59	Kartikaya Gupta — Bug 1459935 - Update for API change in WR PR 2747. r=jrmuizel
> 3ad8053cee91	Kartikaya Gupta — Bug 1459935 - Update Cargo lockfiles and re-vendor rust dependencies. r=jrmuizel
> 972eab977ff3	Kartikaya Gupta — Bug 1459935 - Update webrender to commit 4811a6e7c06f9dd1b4056e5f5e66983842983ba0. r=jrmuizel

This bug:
https://crash-stats.mozilla.com/search/?signature=~webrender%3A%3Aresource_cache%3A%3AResourceCache%3A%3Arequest_image&proto_signature=~webrender%3A%3Aprim_store%3A%3APrimitiveStore%3A%3Aprepare_prim_runs&product=Firefox&date=%3E%3D2018-05-12T01%3A31%3A22.000Z&date=%3C2018-05-13T01%3A31%3A22.000Z&_sort=-build_id&_sort=-date&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#crash-reports

Last crash with build:  2018-05-11_220149
Included the WR update: 2018-05-12_100055

-----

bug 1423311 has the same crash signature, but looks a bit different and is still reproducible:

https://crash-stats.mozilla.com/search/?signature=~webrender%3A%3Aresource_cache%3A%3AResourceCache%3A%3Arequest_image&proto_signature=~webrender%3A%3Aclip_scroll_tree%3A%3AClipScrollTree%3A%3Aupdate_node&product=Firefox&date=%3E%3D2018-05-12T01%3A41%3A21.000Z&date=%3C2018-05-13T01%3A41%3A21.000Z&_sort=-build_id&_sort=-date&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#crash-reports

Comment 10

[Kartikaya Gupta (email:[e-mail])]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #9)
> bug 1423311 has the same crash signature, but looks a bit different and is
> still reproducible:

That bug also pre-dates turning on async scene building, so I think it's a different problem. Thanks for verifying the fix for this bug! I'm going to close this bug since it should be fixed now.