Closed Bug 1455756 Opened 6 years ago Closed 6 years ago

count of results is not shown for Search Messages

Categories

(Thunderbird :: Search, defect)

Product:
Thunderbird
Component:
Search
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird60 fixed, thunderbird61 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 61.0
Tracking Flags:
Tracking Status
thunderbird60 --- fixed
thunderbird61 --- fixed

People

(Reporter: wsmwk, Assigned: Paenglab)

References

Details

(Keywords: regression)

Attachments

(1 file)

Find.patch
2.16 KB, patch
jorgk-bmo
: review+
jorgk-bmo
: approval-comm-beta+
Details | Diff | Splinter Review 
count of results is not shown for Search Messages.

- Search Messages (ctrl+shift+F)
- do search

status bar of search pane is missing message count
Victim of overlay elimination?
Flags: needinfo?(richard.marti)
Flags: needinfo?(acelists)
Attached patch Find.patch — — Splinter Review 
(In reply to Jorg K (GMT+1) from comment #1)
> Victim of overlay elimination?

No, the overlays are not always guilty. ;-)
This time, the statusbar binding was the culprit.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Flags: needinfo?(richard.marti)
Flags: needinfo?(acelists)
Attachment #8969873 - Flags: review?(jorgk)
Attachment #8969873 - Flags: approval-comm-beta?
Wayne, if you see obvious regressions like this one, please NI me and don't rely on the fact that I'm triaging bugs every once in a while, OK?
Comment on attachment 8969873 [details] [diff] [review]
Find.patch

Review of attachment 8969873 [details] [diff] [review]:
-----------------------------------------------------------------

This is why I wanted we extend xul.css with these moved bindings. Otherwise we have to hunt for all the users of the moved bindings/xul elements and make them load our .css with the bindings. And endless and fragile battle.
Comment on attachment 8969873 [details] [diff] [review]
Find.patch

Thanks, works for me.
Attachment #8969873 - Flags: review?(jorgk)
Attachment #8969873 - Flags: review+
Attachment #8969873 - Flags: approval-comm-beta?
Attachment #8969873 - Flags: approval-comm-beta+
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/e714722cfe08
Add the statusbar bindings back to the search windows. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 61.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: