1455974 - Crash in mozilla::ipc::MessageChannel::CxxStackFrame::CxxStackFrame | mozilla::ipc::MessageChannel::Send | mozilla::layers::PCompositorBridgeParent::SendSharedCompositorFrameMetrics

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Darkspirit]

New on Socorro. Starting with 2018-04-20. All crashes of this signature affect WebRender.

bp-7812ecb8-112c-4444-898c-22b280180421 build 20180420100056 Win10
> MOZ_RELEASE_ASSERT(mWorkerThread == GetCurrentVirtualThread()) (not on worker thread!)

Other occurrences of this general crash reason:
https://crash-stats.mozilla.com/search/?moz_crash_reason=~MOZ_RELEASE_ASSERT%28mWorkerThread%20%3D%3D%20GetCurrentVirtualThread%28%29%29%20%28not%20on%20worker%20thread%21%29&product=Firefox&date=%3E%3D2018-04-15T18%3A59%3A14.000Z&date=%3C2018-04-22T18%3A59%3A14.000Z&_sort=-date&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature

WR+
https://crash-stats.mozilla.com/search/?moz_crash_reason=~MOZ_RELEASE_ASSERT%28mWorkerThread%20%3D%3D%20GetCurrentVirtualThread%28%29%29%20%28not%20on%20worker%20thread%21%29&app_notes=~WR%2B&product=Firefox&date=%3E%3D2018-04-15T19%3A01%3A42.000Z&date=%3C2018-04-22T19%3A01%3A42.000Z&_sort=-date&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature

Comment 1

[Kartikaya Gupta (email:[e-mail])]

This is an async scene building bug.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Also for the record this should only occur if somebody turns on layers.progressive-paint which is off by default on desktop.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1455974 - Ensure that mCanSend is cleared at the right time.

mCanSend was being cleared in ActorDestroy which is fine, but we
actually cannot reliably send IPC messages from CompositorBridgeParent
after we get a RecvWillClose message, because that's the last thing that
the child side sends before it gets destroyed. After the WillClose
message there's no guarantee that the child side actor will still be
alive. So this patch also sets mCanSend to false in RecvWillClose.

mCanSend is only used in two places, both of which have to do with the
APZ metrics-sharing code, so this shouldn't have any unexpected
side-effects. It is needed for the next patch.

Review commit: https://reviewboard.mozilla.org/r/239076/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239076/

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1455974 - Ensure the metrics sharing IPC messages are sent from the compositor thread.

With WR+async scene building, the updater thread is no longer the
compositor thread, but we can only send the IPC messages from the
compositor thread. So we need to bounce those calls over to the right
thread.

Review commit: https://reviewboard.mozilla.org/r/239078/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239078/

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1455974 - Clear the client-side shared frame metrics data on shutdown with WR as well.

There's some cleanup happening in CompositorBridgeChild to release the
shared frame metrics when the client side is destroyed. However the code
is specific to PLayerTransaction, and is missing for the WR codepath.
This patch extracts the code to a helper and ensures that it runs for
the WR equivalent codepath.

Review commit: https://reviewboard.mozilla.org/r/239080/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239080/

Comment 6

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8970279 [details]
Bug 1455974 - Ensure that mCanSend is cleared at the right time.

https://reviewboard.mozilla.org/r/239076/#review244824

Comment 7

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8970281 [details]
Bug 1455974 - Clear the client-side shared frame metrics data on shutdown with WR as well.

https://reviewboard.mozilla.org/r/239080/#review244864

Looks good!

Comment 8

[Botond Ballo [:botond]]

Comment on attachment 8970280 [details]
Bug 1455974 - Ensure the metrics sharing IPC messages are sent from the compositor thread.

https://reviewboard.mozilla.org/r/239078/#review245090

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9ee020a4abd
Ensure that mCanSend is cleared at the right time. r=sotaro
https://hg.mozilla.org/integration/autoland/rev/59f704125010
Ensure the metrics sharing IPC messages are sent from the compositor thread. r=botond
https://hg.mozilla.org/integration/autoland/rev/74de53b433e0
Clear the client-side shared frame metrics data on shutdown with WR as well. r=sotaro

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/c9ee020a4abd
https://hg.mozilla.org/mozilla-central/rev/59f704125010
https://hg.mozilla.org/mozilla-central/rev/74de53b433e0