Closed
Bug 1456050
Opened 6 years ago
Closed 6 years ago
Add marionette.debugging.clicktostart and marionette.contentListener to MarionettePrefs
Categories
(Remote Protocol :: Marionette, enhancement)
Remote Protocol
Marionette
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
Details
Attachments
(3 files)
No description provided.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8970079 [details] Bug 1456050 - Use MarionettePrefs.port in TCPListener. https://reviewboard.mozilla.org/r/238848/#review244936 ::: testing/marionette/server.js (Diff revision 1) > "@mozilla.org/network/server-socket;1", > "nsIServerSocket", > "initSpecialConnection"); > > ChromeUtils.import("resource://gre/modules/Log.jsm"); > -ChromeUtils.import("resource://gre/modules/Preferences.jsm"); I would be happier when we got rid of Preferences.jsm at all in a single patch, but it's also ok to do it step by step.
Attachment #8970079 -
Flags: review?(hskupin) → review+
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8970077 [details] Bug 1456050 - Add marionette.debugging.clicktostart to MarionettePrefs. https://reviewboard.mozilla.org/r/238844/#review244938 ::: testing/marionette/test/unit/test_prefs.js:106 (Diff revision 1) > run_next_test(); > }); > > add_test(function test_MarionettePrefs_getters() { > equal(false, MarionettePrefs.enabled); > + equal(false, MarionettePrefs.clickToStart); If you want to keep the alphabitical order just move it up.
Attachment #8970077 -
Flags: review?(hskupin) → review+
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8970078 [details] Bug 1456050 - Add marionette.contentListener to MarionettePrefs. https://reviewboard.mozilla.org/r/238846/#review244940
Attachment #8970078 -
Flags: review?(hskupin) → review+
Comment 7•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8970079 [details] Bug 1456050 - Use MarionettePrefs.port in TCPListener. https://reviewboard.mozilla.org/r/238848/#review244936 > I would be happier when we got rid of Preferences.jsm at all in a single patch, but it's also ok to do it step by step. Just drop that. I should have checked the other commits first.
Assignee | ||
Comment 8•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8970077 [details] Bug 1456050 - Add marionette.debugging.clicktostart to MarionettePrefs. https://reviewboard.mozilla.org/r/238844/#review244938 > If you want to keep the alphabitical order just move it up. I don’t think alphabetizing a this list in the test has any particular value.
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6a7a5b9844b8 Add marionette.debugging.clicktostart to MarionettePrefs. r=whimboo https://hg.mozilla.org/integration/autoland/rev/c0541b429211 Add marionette.contentListener to MarionettePrefs. r=whimboo https://hg.mozilla.org/integration/autoland/rev/bc9936221cb1 Use MarionettePrefs.port in TCPListener. r=whimboo
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6a7a5b9844b8 https://hg.mozilla.org/mozilla-central/rev/c0541b429211 https://hg.mozilla.org/mozilla-central/rev/bc9936221cb1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•