1456050 - Add marionette.debugging.clicktostart and marionette.contentListener to MarionettePrefs

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement)

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1456050 - Add marionette.debugging.clicktostart to MarionettePrefs.

Review commit: https://reviewboard.mozilla.org/r/238844/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238844/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1456050 - Add marionette.contentListener to MarionettePrefs.

Review commit: https://reviewboard.mozilla.org/r/238846/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238846/

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1456050 - Use MarionettePrefs.port in TCPListener.

Review commit: https://reviewboard.mozilla.org/r/238848/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/238848/

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Comment on attachment 8970079 [details]
Bug 1456050 - Use MarionettePrefs.port in TCPListener.

https://reviewboard.mozilla.org/r/238848/#review244936

::: testing/marionette/server.js
(Diff revision 1)
>      "@mozilla.org/network/server-socket;1",
>      "nsIServerSocket",
>      "initSpecialConnection");
>  
>  ChromeUtils.import("resource://gre/modules/Log.jsm");
> -ChromeUtils.import("resource://gre/modules/Preferences.jsm");

I would be happier when we got rid of Preferences.jsm at all in a single patch, but it's also ok to do it step by step.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Comment on attachment 8970077 [details]
Bug 1456050 - Add marionette.debugging.clicktostart to MarionettePrefs.

https://reviewboard.mozilla.org/r/238844/#review244938

::: testing/marionette/test/unit/test_prefs.js:106
(Diff revision 1)
>    run_next_test();
>  });
>  
>  add_test(function test_MarionettePrefs_getters() {
>    equal(false, MarionettePrefs.enabled);
> +  equal(false, MarionettePrefs.clickToStart);

If you want to keep the alphabitical order just move it up.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Comment on attachment 8970078 [details]
Bug 1456050 - Add marionette.contentListener to MarionettePrefs.

https://reviewboard.mozilla.org/r/238846/#review244940

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Comment on attachment 8970079 [details]
Bug 1456050 - Use MarionettePrefs.port in TCPListener.

https://reviewboard.mozilla.org/r/238848/#review244936

> I would be happier when we got rid of Preferences.jsm at all in a single patch, but it's also ok to do it step by step.

Just drop that. I should have checked the other commits first.

Comment 8

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8970077 [details]
Bug 1456050 - Add marionette.debugging.clicktostart to MarionettePrefs.

https://reviewboard.mozilla.org/r/238844/#review244938

> If you want to keep the alphabitical order just move it up.

I don’t think alphabetizing a this list in the test has any particular
value.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a7a5b9844b8
Add marionette.debugging.clicktostart to MarionettePrefs. r=whimboo
https://hg.mozilla.org/integration/autoland/rev/c0541b429211
Add marionette.contentListener to MarionettePrefs. r=whimboo
https://hg.mozilla.org/integration/autoland/rev/bc9936221cb1
Use MarionettePrefs.port in TCPListener. r=whimboo

Comment 10

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/6a7a5b9844b8
https://hg.mozilla.org/mozilla-central/rev/c0541b429211
https://hg.mozilla.org/mozilla-central/rev/bc9936221cb1