1456231 - Add-on errors in TB 60.0 beta "This add-on could not be installed because it appears to be corrupt."

Status: RESOLVED INVALID

(Thunderbird :: Add-Ons: General, defect)

Description

[Matt Slay]

Attachment: TB60.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.181 Safari/537.36

Steps to reproduce:

I am trying to install manually add-ons in TB 60.0


Actual results:

Gives error "This add-on could not be installed because it appears to be corrupt."  
Almost all add-ons are now saying this, when they worked fine in TB 59


Expected results:

it should install add-on, just like before.

Comment 1

[Jorg K (CEST = GMT+2)]

Which add-on?

Comment 2

[gene c]

I have same in daily build (61.0a1 (2018-05-02) (64-bit). Mine is linux.

All add-ons stopped working - last working version was march 21 (no builds until May 1st so this is first version I see problem). If I try to reinstall any add-on I get the same error message reporter sees.

I have this in the error console if it helps.

No chrome package registered for chrome://browser/content/built_in_addons.json
1525261926294	addons.xpi	WARN	List of valid built-in add-ons could not be parsed.: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.readUTF8URI]"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: _readAddons :: line 3063"  data: no] Stack trace: _readAddons()@resource://gre/modules/addons/XPIProvider.jsm:3063
getAddonLocations()@resource://gre/modules/addons/XPIProvider.jsm:2984
getInstallState()@resource://gre/modules/addons/XPIProvider.jsm:1056
checkForChanges()@resource://gre/modules/addons/XPIProvider.jsm:2075
startup()@resource://gre/modules/addons/XPIProvider.jsm:1588
callProvider()@resource://gre/modules/AddonManager.jsm:207
_startProvider()@resource://gre/modules/AddonManager.jsm:657
startup()@resource://gre/modules/AddonManager.jsm:821
startup()@resource://gre/modules/AddonManager.jsm:2887
observe()@jar:file:///opt/Local/vers/mozilla/x86_64/thunderbird-61.0a1.20180502/omni.ja!/components/addonManager.js:66

Comment 3

[Jorg K (CEST = GMT+2)]

You're mixing three issues here :-(

Firstly, when "manually"(?) installing an unknown(!) add-on, something doesn't work in TB. Since we don't know what you're doing and which add-on you're trying to use, we can action this. Also note bug 1457270 comment #1.

Secondly, all non-bootstrapped add-ons don't work in TB 61 Daily (bug 1447831 and bug 1448221). We're working on getting them going again in bug 1448808.

Lastly, "WARN List of valid built-in add-ons could not be parsed" should have been fixed in bug 1416480. I'm surprised you're seeing this in a Daily of 2nd of May. How did you install that package? Aceman, can you please take this up with the user.

Comment 4

[gene c]

Hi - thanks for quick feedback.

The add-ons were installed from addons.mozilla.org by downloading and then using Thunderbird "Addons Manager" drop down menu 'Install Add-ons from File ...'

They have been updating themselves until this recent build.

(1) The extenions used are

 a) contact photos:  
     https://addons.mozilla.org/en-US/thunderbird/addon/contact-photos/

 b) gcontactsync
        https://addons.mozilla.org/en-US/thunderbird/addon/gcontactsync/
        (I did update to the dev version last year from: https://github.com/jdgeenen/gcontactsync)

  c) emoji menu:
         https://addons.mozilla.org/en-US/thunderbird/addon/emoji-menu/

  d) sieve
          https://addons.mozilla.org/en-US/thunderbird/addon/sieve/

  After installing from the thunderbird menu it looks like they get places into my personal directory:
   ~/.thunderbird/xxx/extensions


(2) Sorry I don't know what a "non-bootstrapped" add-on is?


(3) I installed the daily build from :
    http://ftp.mozilla.org/pub/thunderbird/nightly/latest-comm-central/thunderbird-61.0a1.en-US.linux-x86_64.tar.bz2

   I simply untar the package into an area accessible to all users, and run it from there.

Thank you for your help.

gene

Comment 5

[Jorg K (CEST = GMT+2)]

(2) If the AMO site says: "Requires Restart", then it's non-bootstrapped. Bootstrapped add-ons do not require restart.

(1) In your list of four, only "Sieve" is boostrapped, the other ones are non-bootstrapped.
    Those will not work in TB 61 Daily any more.

(3) I suggest to wipe the area before untaring. We occasionally remove files.

Due to the situation in TB 61 Daily, I'm currently using TB 60 beta myself, which I can recommend.

I've downloaded "Sieve" and "Contact Photos" and used "Install Add-on From File" (I usually just drag the add-on onto the Add-on Manager tab") and that worked just fine.

So far I don't see an actionable problem here.

Comment 6

[gene c]

Great - thank you for the info - much appreciated!

Sorry for any noise.

Comment 7

[Jorg K (CEST = GMT+2)]

"WARN List of valid built-in add-ons could not be parsed" should have been fixed in bug 1416480, but wasn't. I still see that error. Thanks for alerting us to that.

Comment 8

[Matt Slay]

You asked for an example add-on that give this error "This add-on could not be installed because it appears to be corrupt."

Well, the Quick Folder Move add-on by Philipp Kewisch is one that gives this error. He is away of this because I have emailed him about it.

Quick Folder Move
https://addons.mozilla.org/en-US/thunderbird/addon/quick-folder-move/

Comment 9

[Jorg K (CEST = GMT+2)]

Yes, this one appears to be somewhat corrupt.

I'm closing this bug. There is nothing actionable here. Whatever doesn't work is covered elsewhere.

With regard to the summary this bug is invalid since we don't track add-on issues here.

Comment 10

[:aceman]

Can you please try the latest nightly to see if problem 3) (built_in_addons.json) got sovled?

Comment 11

[gene c]

I confirm the message has gone in latest nightly. 
Now just need the add-on devs to modify their code :)

Comment 12

[Jorg K (CEST = GMT+2)]

As a responsible reviewer and release manager, I verified it, too :-)