Closed Bug 1456284 Opened 7 years ago Closed 5 years ago

Intermittent browser/extensions/formautofill/test/browser/browser_insecure_form.js | Uncaught exception - The popup should be a form autofill one - timed out after 50 tries.

Categories

(Toolkit :: Form Autofill, enhancement, P3)

Product:
Toolkit
Component:
Form Autofill
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox61 --- disabled
firefox62 --- disabled

People

(Reporter: intermittent-bug-filer, Assigned: jimm)

References

(Depends on 2 open bugs, Blocks 1 open bug)

Details

(Keywords: intermittent-failure, Whiteboard: [cc-autofill-mvp])

Attachments

(2 files, 1 obsolete file)

disable test on linux and osx
1.30 KB, patch
gbrown
: review+
Details | Diff | Splinter Review
Bug 1456284 - Enable browser_insecure_form.js.
47 bytes, text/x-phabricator-request
Details | Review
Filed by: btara [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=175114924&repo=mozilla-inbound https://queue.taskcluster.net/v1/task/bFz_8laTT1-nbzH15wF0Uw/runs/0/artifacts/public/logs/live_backing.log 2:21:10 INFO - Buffered messages logged at 12:21:09 12:21:10 INFO - 1166 INFO getDisplayedPopupItems 12:21:10 INFO - 1167 INFO getDisplayedPopupItems 12:21:10 INFO - 1168 INFO getDisplayedPopupItems 12:21:10 INFO - 1169 INFO getDisplayedPopupItems 12:21:10 INFO - 1170 INFO getDisplayedPopupItems 12:21:10 INFO - 1171 INFO getDisplayedPopupItems 12:21:10 INFO - 1172 INFO getDisplayedPopupItems 12:21:10 INFO - 1173 INFO getDisplayedPopupItems 12:21:10 INFO - 1174 INFO getDisplayedPopupItems 12:21:10 INFO - 1175 INFO getDisplayedPopupItems 12:21:10 INFO - Buffered messages logged at 12:21:10 12:21:10 INFO - 1176 INFO getDisplayedPopupItems 12:21:10 INFO - 1177 INFO getDisplayedPopupItems 12:21:10 INFO - Buffered messages finished 12:21:10 ERROR - 1178 INFO TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_insecure_form.js | Uncaught exception - The popup should be a form autofill one - timed out after 50 tries. 12:21:10 INFO - 1179 INFO Leaving test bound test_insecure_form 12:21:10 INFO - 1180 INFO Entering test bound test_click_on_insecure_warning 12:21:10 INFO - 1181 INFO expecting the target input being focused and identified 12:21:10 INFO - 1182 INFO !previouslyFocused 12:21:10 INFO - 1183 INFO FieldsIdentified 12:21:11 INFO - 1184 INFO openPopupOn: before VK_DOWN 12:21:11 INFO - 1185 INFO expectPopupOpen 12:21:11 INFO - 1186 INFO getDisplayedPopupItems 12:21:11 INFO - 1187 INFO getDisplayedPopupItems 12:21:11 INFO - 1188 INFO TEST-PASS | browser/extensions/formautofill/test/browser/browser_insecure_form.js | undefined assertion name - 12:21:11 INFO - 1189 INFO Leaving test bound test_click_on_insecure_warning 12:21:11 INFO - 1190 INFO Entering test bound test_press_enter_on_insecure_warning 12:21:11 INFO - 1191 INFO expecting the target input being focused and identified 12:21:11 INFO - 1192 INFO !previouslyFocused 12:21:11 INFO - 1193 INFO FieldsIdentified 12:21:12 INFO - 1194 INFO openPopupOn: before VK_DOWN 12:21:12 INFO - 1195 INFO expectPopupOpen 12:21:12 INFO - 1196 INFO getDisplayedPopupItems 12:21:12 INFO - 1197 INFO TEST-PASS | browser/extensions/formautofill/test/browser/browser_insecure_form.js | undefined assertion name - 12:21:12 INFO - 1198 INFO Leaving test bound test_press_enter_on_insecure_warning 12:21:12 INFO - 1199 INFO expecting record retrievals: addresses 12:21:12 INFO - 1200 INFO expecting address removed 12:21:12 INFO - 1201 INFO expecting record retrievals: creditCards 12:21:12 INFO - 1202 INFO expecting credit card removed 12:21:12 INFO - GECKO(1996) | MEMORY STAT | vsize 747MB | vsizeMaxContiguous 632MB | residentFast 226MB | heapAllocated 86MB 12:21:12 INFO - 1203 INFO TEST-OK | browser/extensions/formautofill/test/browser/browser_insecure_form.js | took 10875ms 12:21:12 INFO - Not taking screenshot here: see the one that was previously logged 12:21:12 ERROR - 1204 INFO TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_insecure_form.js | Found an unexpected tab at the end of test run: https://example.org/browser/browser/extensions/formautofill/test/browser/autocomplete_creditcard_basic.html - 12:21:12 INFO - 1205 INFO checking window state 12:21:12 INFO - 1206 INFO TEST-START | browser/extensions/formautofill/test/browser/browser_manageAddressesDialog.js 12:21:13 INFO - GECKO(1996) | JavaScript error: jar:file:///Z:/task_1524484527/build/application/firefox/omni.ja!/components/mozIntl.js, line 211: TypeError: All region codes must be strings. 12:21:13 INFO - GECKO(1996) | MEMORY STAT | vsize 729MB | vsizeMaxContiguous 632MB | residentFast 218MB | heapAllocated 90MB 12:21:13 INFO - 1207 INFO TEST-OK | browser/extensions/formautofill/test/browser/browser_manageAddressesDialog.js | took 570ms
This bug has failed 81 times in the last 7 days. On all platforms except for Mac and Android. Build types are OPT, PGO, Asan and debug. Here is a recent windows log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-central&job_id=176204097 And here is a part of the log: INFO - Buffered messages finished 12:10:29 ERROR - 1566 INFO TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_insecure_form.js | Uncaught exception - The popup should be a form autofill one - timed out after 50 tries. 12:10:29 INFO - 1567 INFO Leaving test bound test_click_on_insecure_warning 12:10:29 INFO - 1568 INFO Entering test bound test_press_enter_on_insecure_warning 12:10:29 INFO - 1569 INFO expecting the target input being focused and identified 12:10:29 INFO - 1570 INFO !previouslyFocused 12:10:29 INFO - 1571 INFO FieldsIdentified 12:10:30 INFO - 1572 INFO openPopupOn: before VK_DOWN 12:10:30 INFO - 1573 INFO expectPopupOpen 12:10:30 INFO - 1574 INFO getDisplayedPopupItems 12:10:30 INFO - 1575 INFO TEST-PASS | browser/extensions/formautofill/test/browser/browser_insecure_form.js | undefined assertion name - 12:10:30 INFO - 1576 INFO Leaving test bound test_press_enter_on_insecure_warning 12:10:30 INFO - 1577 INFO expecting record retrievals: addresses 12:10:30 INFO - 1578 INFO expecting address removed 12:10:30 INFO - 1579 INFO expecting record retrievals: creditCards 12:10:30 INFO - 1580 INFO expecting credit card removed 12:10:30 INFO - GECKO(3840) | MEMORY STAT | vsize 2098955MB | vsizeMaxContiguous 130648442MB | residentFast 280MB | heapAllocated 99MB 12:10:30 INFO - 1581 INFO TEST-OK | browser/extensions/formautofill/test/browser/browser_insecure_form.js | took 12030ms 12:10:30 INFO - Not taking screenshot here: see the one that was previously logged 12:10:30 ERROR - 1582 INFO TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/browser_insecure_form.js | Found an unexpected tab at the end of test run: http://example.org/browser/browser/extensions/formautofill/test/browser/autocomplete_creditcard_basic.html - 12:10:30 INFO - 1583 INFO checking window state 12:10:30 INFO - 1584 INFO TEST-START | browser/extensions/formautofill/test/browser/browser_manageAddressesDialog.js 12:10:31 INFO - GECKO(3840) | JavaScript error: jar:file:///Z:/task_1525002908/build/application/firefox/omni.ja!/components/mozIntl.js, line 211: TypeError: All region codes must be strings. 12:10:31 INFO - GECKO(3840) | MEMORY STAT | vsize 2098947MB | vsizeMaxContiguous 130648454MB | residentFast 281MB | heapAllocated 104MB 12:10:31 INFO - 1585 INFO TEST-OK | browser/extensions/formautofill/test/browser/browser_manageAddressesDialog.js | took 756ms 12:10:31 INFO - 1586 INFO checking window state 12:10:31 INFO - 1587 INFO TEST-START | browser/extensions/formautofill/test/browser/browser_manageCreditCardsDialog.js 12:10:32 INFO - GECKO(3840) | MP change from to omgsecret! 12:10:32 INFO - GECKO(3840) | MEMORY STAT | vsize 2098937MB | vsizeMaxContiguous 130648454MB | residentFast 279MB | heapAllocated 109MB 12:10:32 INFO - 1588 INFO TEST-OK | browser/extensions/formautofill/test/browser/browser_manageCreditCardsDialog.js | took 1075ms 12:10:32 INFO - 1589 INFO checking window state 12:10:32 INFO - 1590 INFO TEST-START | browser/extensions/formautofill/test/browser/browser_privacyPreferences.js 12:10:35 INFO - GECKO(3840) | MEMORY STAT | vsize 2098964MB | vsizeMaxContiguous 130648454MB | residentFast 323MB | heapAllocated 145MB 12:10:35 INFO - 1591 INFO TEST-OK | browser/extensions/formautofill/test/browser/browser_privacyPreferences.js | took 2819ms 12:10:35 INFO - 1592 INFO checking window state 12:10:35 INFO - 1593 INFO TEST-START | browser/extensions/formautofill/test/browser/browser_submission_in_private_mode.js 12:10:36 INFO - GECKO(3840) | JavaScript error: resource://devtools/client/jsonview/converter-observer.js, line 91: NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIChannel.contentType] 12:10:37 INFO - GECKO(3840) | MEMORY STAT | vsize 2098990MB | vsizeMaxContiguous 130648413MB | residentFast 343MB | heapAllocated 147MB 12:10:37 INFO - 1594 INFO TEST-OK | browser/extensions/formautofill/test/browser/browser_submission_in_private_mode.js | took 1659ms 12:10:37 INFO - 1595 INFO checking window state 12:10:39 INFO - GECKO(3840) | Completed ShutdownLeaks collections in process 5336 12:10:39 INFO - GECKO(3840) | Completed ShutdownLeaks collections in process 6132 12:10:39 INFO - GECKO(3840) | Completed ShutdownLeaks collections in process 7808 12:10:39 INFO - GECKO(3840) | Completed ShutdownLeaks collections in process 3676 12:10:39 INFO - GECKO(3840) | Completed ShutdownLeaks collections in process 8220 12:10:39 INFO - GECKO(3840) | Completed ShutdownLeaks collections in process 3840 12:10:39 INFO - 1596 INFO TEST-START | Shutdown 12:10:39 INFO - 1597 INFO Browser Chrome Test Summary 12:10:39 INFO - 1598 INFO Passed: 220 12:10:39 WARNING - 1599 INFO Failed: 2 12:10:39 WARNING - One or more unittests failed. 12:10:39 INFO - 1600 INFO Todo: 0 12:10:39 INFO - 1601 INFO Mode: e10s 12:10:39 INFO - 1602 INFO *** End BrowserChrome Test Results *** Hi :MattN: Can you please take a look at this bug?
Flags: needinfo?(MattN+bmo)
Whiteboard: [stockwell needswork]
Attached patch bug1456284.patch (obsolete) — — Splinter Review
Attachment #8973917 - Flags: review?(jmaher)
Comment on attachment 8973917 [details] [diff] [review] bug1456284.patch Review of attachment 8973917 [details] [diff] [review]: ----------------------------------------------------------------- Thanks
Attachment #8973917 - Flags: review?(jmaher) → review+
Keywords: checkin-needed, leave-open
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5dbd8eafc7fd Disable browser_insecure_form.js for frequent failures. r=jmaher
Keywords: checkin-needed
Whiteboard: [stockwell disabled] → [stockwell disable-recommended]
ok, this is silly, but the original patch had a special character which when converted to ascii was a ' '. Why did the diff tools and raw_diff not show it!?! I tested this locally, it looks much better
Attachment #8973917 - Attachment is obsolete: true
Attachment #8974127 - Flags: review?(gbrown)
Attachment #8974127 - Flags: review?(gbrown) → review+
Keywords: checkin-needed
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f6a510be5566 Disable browser_insecure_form.js for frequent failures. r=gbrown
Keywords: checkin-needed
Priority: P5 → P1
Flags: needinfo?(MattN+bmo)
Blocks: ccautofill-tests
Severity: normal → S3
Type: defect → enhancement
Keywords: leave-open
OS: Unspecified → All
Priority: P1 → P3
Hardware: Unspecified → All
Whiteboard: [stockwell disabled] → [stockwell disabled][cc-autofill-reserve]
Version: unspecified → Trunk

Thanks to some work we've done on cc autofill, this test is now passing. I'm going to re-enable it.

Assignee: nobody → jmathies
Whiteboard: [stockwell disabled][cc-autofill-reserve] → [stockwell disabled][cc-autofill-mvp]
Status: NEW → ASSIGNED
Pushed by jmathies@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/783c3b4c9931 Enable browser_insecure_form.js. r=zbraniecki

https://hg.mozilla.org/mozilla-central/rev/783c3b4c9931

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
Pushed by malexandru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ff32132cb490 Disable browser_insecure_form.js on macos for causing permafailures. a=fix
Status: RESOLVED → REOPENED
status-firefox80: fixed → ---
Flags: needinfo?(jmathies)
Keywords: leave-open
Resolution: FIXED → ---
Target Milestone: mozilla80 → ---
Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
Flags: needinfo?(jmathies)
Keywords: leave-open
Resolution: --- → FIXED
Whiteboard: [stockwell disabled][cc-autofill-mvp] → [cc-autofill-mvp]

(In reply to Alexandru Michis [:malexandru] from comment #53)

Pushed a fix since browser_insecure_form.js was permafailing on macos after being enabled:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&fromchange=38eb7e99885965254de8ab4540713961780ff1a5&searchStr=os%2Cx%2C10.14%2Cshippable%2Copt%2Cmochitests%2Ctest-macosx1014-64-shippable%2Fopt-mochitest-browser-chrome-e10s%2Cbc2&tochange=6e556d9c084532ca27fcf30353a88eb82b775595

The OSX failure is tracked under

Bug 1655783 - Intermittent browser/extensions/formautofill/test/browser/creditCard/browser_insecure_form.js | Uncaught exception - TypeError: can't access property "blur", content.document.activeElement is null (OSX)

Depends on: 1646536
Depends on: 1655783

We also have an occasional linux failure that's tracked under

Bug 1646536 - Intermittent browser/extensions/formautofill/test/browser/creditCard/browser_insecure_form.js | Uncaught exception - TypeError: can't access property "blur", content.document.activeElement is null (Linux)

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: