1456544 - Try removing -mstackrealign -mms-bitfields from MinGW build

Status: RESOLVED FIXED

(Firefox Build System :: General: Unsupported Platforms, enhancement, P5)

Description

[Tom Ritter [:tjr]]

Someone told me that because we only support GCC 6.1 and up, we no longer need these flags. Filing a bug to get it on file for investigation.

Comment 1

[Tom Ritter [:tjr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6bd271020fb301adb8b3f8659f47d76a419853fa

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb86df37bbae792a4143cba86cea94d471b4f78d

Comment 2

[Tom Ritter [:tjr]]

mms-bitfields seems to be okay; but mstackrealign caused test failures with an assert:

[task 2019-08-25T13:26:11.856Z] 13:26:11 INFO - GECKO(3700) | Assertion failure: callWithABI: callee did not use AutoUnsafeCallWithABI, at /builds/worker/workspace/build/src/js/src/jit/MacroAssembler.cpp:1653

Yay tests!

Jacek, are you okay with removing mms-bitfields?

Comment 3

[Jacek Caban]

Yes, it should be fine.

Comment 4

[Tom Ritter [:tjr]]

Attachment: Bug 1456544 - Remove mms-bitfields from the MinGW build r?#build

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b291f7b8f2fe
Remove mms-bitfields from the MinGW build r=nalexander

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/b291f7b8f2fe