Closed Bug 1456544 Opened 5 years ago Closed 4 years ago

Try removing -mstackrealign -mms-bitfields from MinGW build

Categories

(Firefox Build System :: General: Unsupported Platforms, enhancement, P5)

Product:
Firefox Build System
Component:
General: Unsupported Platforms
Version:
3 Branch
Type:
enhancement

Tracking

(firefox70 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: tjr, Assigned: tjr)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1456544 - Remove mms-bitfields from the MinGW build r?#build
47 bytes, text/x-phabricator-request
Details | Review 
Someone told me that because we only support GCC 6.1 and up, we no longer need these flags. Filing a bug to get it on file for investigation.
Blocks: 1463261
Version: Version 3 → 3 Branch
Priority: -- → P5

mms-bitfields seems to be okay; but mstackrealign caused test failures with an assert:

[task 2019-08-25T13:26:11.856Z] 13:26:11 INFO - GECKO(3700) | Assertion failure: callWithABI: callee did not use AutoUnsafeCallWithABI, at /builds/worker/workspace/build/src/js/src/jit/MacroAssembler.cpp:1653

Yay tests!

Jacek, are you okay with removing mms-bitfields?

Flags: needinfo?(jacek)

Yes, it should be fine.

Flags: needinfo?(jacek)
See Also: → 1576664
Pushed by tritter@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b291f7b8f2fe
Remove mms-bitfields from the MinGW build r=nalexander

https://hg.mozilla.org/mozilla-central/rev/b291f7b8f2fe

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Assignee: nobody → tom
See Also: → 1585355
You need to log in before you can comment on or make changes to this bug.