Closed Bug 1456546 Opened 8 years ago Closed 7 years ago

Implement BigInt support for arithmetic and comparison operators

Categories

(Core :: JavaScript Engine, enhancement, P2)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox61 --- affected

People

(Reporter: terpri, Unassigned)

References

Details

(Keywords: dev-doc-complete)

Attachments

(24 obsolete files)

Implement BigInt support for arithmetic and comparison operators.
Priority: -- → P2
Attached patch Part 1: Arithmetic methods (obsolete) — — Splinter Review
Attached patch Part 2: Comparison methods (obsolete) — — Splinter Review
Attached patch Part 3: ToNumeric (obsolete) — — Splinter Review
Attached patch Part 4: ToInt32OrBigInt (obsolete) — — Splinter Review
Attached patch Part 5: NumberValue method (obsolete) — — Splinter Review
Attached patch Part 6: Number constructor (obsolete) — — Splinter Review
Attached patch Part 8: Equality (obsolete) — — Splinter Review
Attached patch Part 9: Comparison (obsolete) — — Splinter Review
Attached patch Part 10: Arithmetic (obsolete) — — Splinter Review
Attached patch Part 11: Bitwise operators (obsolete) — — Splinter Review
Attached patch Part 12: asIntN/asUintN methods (obsolete) — — Splinter Review
Depends on: js-bigint
Attached patch Part 1: Arithmetic methods (obsolete) — — Splinter Review
Attachment #8973891 - Attachment is obsolete: true
Attachment #8973892 - Attachment is obsolete: true
Attachment #8973893 - Attachment is obsolete: true
Attachment #8973894 - Attachment is obsolete: true
Attachment #8973895 - Attachment is obsolete: true
Attachment #8973896 - Attachment is obsolete: true
Attachment #8973897 - Attachment is obsolete: true
Attachment #8973898 - Attachment is obsolete: true
Attachment #8973899 - Attachment is obsolete: true
Attachment #8973900 - Attachment is obsolete: true
Attachment #8973901 - Attachment is obsolete: true
Attachment #8973902 - Attachment is obsolete: true
Attached patch Part 2: Comparison methods (obsolete) — — Splinter Review
Attached patch Part 3: ToNumeric (obsolete) — — Splinter Review
Attached patch Part 4: ToInt32OrBigInt (obsolete) — — Splinter Review
Attached patch Part 5: NumberValue method (obsolete) — — Splinter Review
Attached patch Part 6: Number constructor (obsolete) — — Splinter Review
Attached patch Part 8: Equality (obsolete) — — Splinter Review
Attached patch Part 9: Comparison (obsolete) — — Splinter Review
Attached patch Part 10: Arithmetic (obsolete) — — Splinter Review
Attached patch Part 11: Bitwise operators (obsolete) — — Splinter Review
Attached patch Part 12: asIntN/asUintN methods (obsolete) — — Splinter Review
Blocks: js-bigint
No longer depends on: js-bigint
Depends on: 1471134
Depends on: 1486173
Attachment #8981507 - Attachment is obsolete: true
Attachment #8981509 - Attachment is obsolete: true
Attachment #8981510 - Attachment is obsolete: true
Attachment #8981514 - Attachment is obsolete: true
Attachment #8981511 - Attachment is obsolete: true
Attachment #8981512 - Attachment is obsolete: true
It looks like attachment 8981505 [details] [diff] [review] should be marked as obsolete following bug1471134
Similarly, attachment appears to be obsoleted by bug 1486173, which looks like it requires fixups in patch 9 --- Please let me know if that's not correct.
Comment on attachment 8981505 [details] [diff] [review] Part 1: Arithmetic methods obsoleted by #1471134 and #1490387
Attachment #8981505 - Attachment is obsolete: true
Comment on attachment 8981508 [details] [diff] [review] Part 4: ToInt32OrBigInt obsoleted by #1490387
Attachment #8981508 - Attachment is obsolete: true
Comment on attachment 8981515 [details] [diff] [review] Part 11: Bitwise operators obsoleted by #1490387
Attachment #8981515 - Attachment is obsolete: true
Attachment 8981506 [details] [diff] and attachment 8981513 [details] [diff] [review] seem obsoleted by bug 1492669 and bug 1486173; wdyt :terpri?
Flags: needinfo?(robin)
Summary: BigInt arithmetic → Implement BigInt support for arithmetic and comparison operators
(In reply to Andy Wingo [:wingo] from comment #30) > Attachment 8981506 [details] [diff] and attachment 8981513 [details] [diff] [review] > [review] seem obsoleted by bug 1492669 and bug 1486173; wdyt :terpri? Yeah, both of these patches have landed via other bugs, so I think this can be closed now
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Depends on: 1492669
Flags: needinfo?(robin)
Resolution: --- → FIXED
Attachment #8981506 - Attachment is obsolete: true
Attachment #8981513 - Attachment is obsolete: true
Attachment #8981516 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: