1486173 - BigInt equality comparison

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Robin Templeton [:terpri]]

Implement BigInt support for equality operators.

Comment 1

[Robin Templeton [:terpri]]

Attachment: Part 1: Move error reporting out of StringToBigInt.

StringToBigInt now fails only on OOM, and returns a JS::Result so that callers can distinguish between OOM errors and parsing failures.

Comment 2

[Robin Templeton [:terpri]]

Attachment: Part 2: Add BigInt methods for equality comparison.

Comment 3

[Robin Templeton [:terpri]]

Attachment: Part 3: Implement BigInt support for equality operators.

Comment 4

[Jan de Mooij [:jandem]]

Comment on attachment 9003954 [details] [diff] [review]
Part 3: Implement BigInt support for equality operators.

Review of attachment 9003954 [details] [diff] [review]:
-----------------------------------------------------------------

Nice

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/417d94835a03
Part 1: Move error reporting out of StringToBigInt. r=jandem
https://hg.mozilla.org/integration/mozilla-inbound/rev/c62f40111003
Part 2: Add BigInt methods for equality comparison. r=jandem
https://hg.mozilla.org/integration/mozilla-inbound/rev/be6163ba4a6a
Part 3: Implement BigInt support for equality operators. r=jandem

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/417d94835a03
https://hg.mozilla.org/mozilla-central/rev/c62f40111003
https://hg.mozilla.org/mozilla-central/rev/be6163ba4a6a