Closed Bug 1486173 Opened 2 years ago Closed 2 years ago

BigInt equality comparison

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: terpri, Assigned: terpri)

References

Details

Attachments

(3 files)

Implement BigInt support for equality operators.
StringToBigInt now fails only on OOM, and returns a JS::Result so that callers can distinguish between OOM errors and parsing failures.
Attachment #9003952 - Flags: review?(jdemooij)
Attachment #9003953 - Flags: review?(jdemooij)
Attachment #9003954 - Flags: review?(jdemooij)
Assignee: nobody → robin
Blocks: 1456546
Attachment #9003952 - Flags: review?(jdemooij) → review+
Attachment #9003953 - Flags: review?(jdemooij) → review+
Comment on attachment 9003954 [details] [diff] [review]
Part 3: Implement BigInt support for equality operators.

Review of attachment 9003954 [details] [diff] [review]:
-----------------------------------------------------------------

Nice
Attachment #9003954 - Flags: review?(jdemooij) → review+
Keywords: checkin-needed
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/417d94835a03
Part 1: Move error reporting out of StringToBigInt. r=jandem
https://hg.mozilla.org/integration/mozilla-inbound/rev/c62f40111003
Part 2: Add BigInt methods for equality comparison. r=jandem
https://hg.mozilla.org/integration/mozilla-inbound/rev/be6163ba4a6a
Part 3: Implement BigInt support for equality operators. r=jandem
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.