Closed Bug 1456755 Opened 2 years ago Closed 2 years ago

Enable ESLint rule no-undef for a couple more directories in devtools

Categories

(DevTools :: General, enhancement)

enhancement
Not set

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

There's a couple more directories where there's just one or two issues remaining and we can enable no-undef of those directories.

In the case of devtools/shared/tests/unit/head_devtools.js, no-undef reveals issues that I've already filed separately as bug 1456634 as they need deeper work to fix. For now, we can whitelist them.
Comment on attachment 8970815 [details]
Bug 1456755 - Enable ESLint rule no-undef for devtools/{client/scratchpad/,shared/tests/unit}.

https://reviewboard.mozilla.org/r/239596/#review246316

Thanks!
Attachment #8970815 - Flags: review?(jdescottes) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e512b622d80
Enable ESLint rule no-undef for devtools/{client/scratchpad/,shared/tests/unit}. r=jdescottes
Severity: normal → enhancement
https://hg.mozilla.org/mozilla-central/rev/4e512b622d80
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.