1456755 - Enable ESLint rule no-undef for a couple more directories in devtools

Status: RESOLVED FIXED

(DevTools :: General, enhancement)

Description

[Mark Banner (:standard8)]

There's a couple more directories where there's just one or two issues remaining and we can enable no-undef of those directories.

In the case of devtools/shared/tests/unit/head_devtools.js, no-undef reveals issues that I've already filed separately as bug 1456634 as they need deeper work to fix. For now, we can whitelist them.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1456755 - Enable ESLint rule no-undef for devtools/{client/scratchpad/,shared/tests/unit}.

Review commit: https://reviewboard.mozilla.org/r/239596/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239596/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8970815 [details]
Bug 1456755 - Enable ESLint rule no-undef for devtools/{client/scratchpad/,shared/tests/unit}.

https://reviewboard.mozilla.org/r/239596/#review246316

Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e512b622d80
Enable ESLint rule no-undef for devtools/{client/scratchpad/,shared/tests/unit}. r=jdescottes

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/4e512b622d80