1456762 - Attempt to improve ESLint handling for globals in html files

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement, P2)

Description

[Mark Banner (:standard8)]

Although we are currently using the html plugin for ESLint to parse our html files (mainly chrome tests), it is very hard currently to determine the globals used as we don't know the files that are imported via script tags.

To get around this, we currently have to manually specify import-globals-from.

I think we can make this better. I've opened a request with eslint-plugin-html to see if we can get the script tags inserted as comments into the javascript it generates. We should then be able to pick these up and process them.

Unfortunately as eslint-plugin-html is a processor, the rules don't have access to the original source to get this by themselves.

https://github.com/BenoitZugmeyer/eslint-plugin-html/issues/94

Comment 1

[Mark Banner (:standard8)]

Thanks to a suggestion from BenoitZugmeyer, I've realised that we can use `context.getFilename()` to get the file name, and then do a quick scan for any script tags.

I've got a patch more or less working for this now, so will hopefully post something soon.

Comment 2

[Mark Banner (:standard8)]

I've used htmlparser2 for scanning for the script tags. More reliable than a regexp, and eslint-plugin-html uses it anyway so we aren't including any more packages.

Try push is here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b181e94f43e2f4d213d89527b373010cc54a402f

Comment 3

[Phabricator Automation]

Attachment: Bug 1456762 - Add parsing of HTML files to ESLint to discover their script tags and the globals that are imported.

MozReview-Commit-ID: 6jiEbZnyv6e

Comment 4

[Phabricator Automation]

Attachment: Bug 1456762 - Remove now unnecessary import-globals-from statements in html files.

Depends on D1643

MozReview-Commit-ID: 84M50HDg0wl

Comment 5

[Phabricator Automation]

Comment on attachment 8985144 [details]
Bug 1456762 - Add parsing of HTML files to ESLint to discover their script tags and the globals that are imported.

Dave Townsend [:mossop] has approved the revision.

https://phabricator.services.mozilla.com/D1643

Comment 6

[Phabricator Automation]

Comment on attachment 8985145 [details]
Bug 1456762 - Remove now unnecessary import-globals-from statements in html files.

Dave Townsend [:mossop] has approved the revision.

https://phabricator.services.mozilla.com/D1644

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70bab1329de0
Add parsing of HTML files to ESLint to discover their script tags and the globals that are imported. r=mossop

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/70bab1329de0

Comment 9

[Mark Banner (:standard8)]

Reopening so that I can hopefully land the second part if phabricator will now let me...

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bc876a7147b
Remove now unnecessary import-globals-from statements in html files. r=mossop

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/1bc876a7147b