1456799 - [wdspec] add_cookie.py marks tests as fail inappropriately

Status: RESOLVED FIXED

(Testing :: geckodriver, defect, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

There are failures listed as the following which causes the test to fail:

https://taskcluster-artifacts.net/dDWmPJHLRY601K6Ei09_VA/0/public/logs/live_backing.log

[task 2018-04-25T11:30:47.971Z] 11:30:47     INFO - STDOUT: >               "domain": ".%s" % server_config["domains"][""]
[task 2018-04-25T11:30:47.972Z] 11:30:47     INFO - STDOUT:             }
[task 2018-04-25T11:30:47.972Z] 11:30:47     INFO - STDOUT:         }
[task 2018-04-25T11:30:47.974Z] 11:30:47     INFO - STDOUT: E       TypeError: list indices must be integers, not str

This is clearly a coding bug, and the test should not have been marked as expected fail.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1456799 - [wdspec] Fix add cookie tests for invalid domain usage.

Review commit: https://reviewboard.mozilla.org/r/239680/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239680/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1456799 - [wdspec] Fix linter failures for add cookie tests.

Review commit: https://reviewboard.mozilla.org/r/239682/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239682/

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1456799 - [wdspec] Add cookie tests have to use a shared custom add_cookie command.

Review commit: https://reviewboard.mozilla.org/r/239684/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239684/

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1456799 - [wdspec] Use wdclient to get a named cookie in add cookie tests.

Review commit: https://reviewboard.mozilla.org/r/239686/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/239686/

Comment 5

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8970929 [details]
Bug 1456799 - [wdspec] Fix add cookie tests for invalid domain usage.

https://reviewboard.mozilla.org/r/239680/#review245408

Comment 6

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8970930 [details]
Bug 1456799 - [wdspec] Fix linter failures for add cookie tests.

https://reviewboard.mozilla.org/r/239682/#review245410

Comment 7

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8970931 [details]
Bug 1456799 - [wdspec] Add cookie tests have to use a shared custom add_cookie command.

https://reviewboard.mozilla.org/r/239684/#review245412

Comment 8

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8970932 [details]
Bug 1456799 - [wdspec] Use wdclient to get a named cookie in add cookie tests.

https://reviewboard.mozilla.org/r/239686/#review245414

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb1909841a5d
[wdspec] Fix add cookie tests for invalid domain usage. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/281208264c74
[wdspec] Fix linter failures for add cookie tests. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/9d55d0203a2b
[wdspec] Add cookie tests have to use a shared custom add_cookie command. r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/c07b1375c1c4
[wdspec] Use wdclient to get a named cookie in add cookie tests. r=maja_zf

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/cb1909841a5d
https://hg.mozilla.org/mozilla-central/rev/281208264c74
https://hg.mozilla.org/mozilla-central/rev/9d55d0203a2b
https://hg.mozilla.org/mozilla-central/rev/c07b1375c1c4

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10646 for changes under testing/web-platform/tests

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/w3c/web-platform-tests/pull/10646
* continuous-integration/travis-ci/pr (https://travis-ci.org/w3c/web-platform-tests/builds/371440175?utm_source=github_status&utm_medium=notification)

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged