Closed
Bug 1456799
Opened 6 years ago
Closed 6 years ago
[wdspec] add_cookie.py marks tests as fail inappropriately
Categories
(Testing :: geckodriver, defect, P1)
Testing
geckodriver
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
Attachments
(4 files)
There are failures listed as the following which causes the test to fail: https://taskcluster-artifacts.net/dDWmPJHLRY601K6Ei09_VA/0/public/logs/live_backing.log [task 2018-04-25T11:30:47.971Z] 11:30:47 INFO - STDOUT: > "domain": ".%s" % server_config["domains"][""] [task 2018-04-25T11:30:47.972Z] 11:30:47 INFO - STDOUT: } [task 2018-04-25T11:30:47.972Z] 11:30:47 INFO - STDOUT: } [task 2018-04-25T11:30:47.974Z] 11:30:47 INFO - STDOUT: E TypeError: list indices must be integers, not str This is clearly a coding bug, and the test should not have been marked as expected fail.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: -- → P1
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Attachment #8970929 -
Flags: review?(mjzffr)
Attachment #8970930 -
Flags: review?(mjzffr)
Attachment #8970931 -
Flags: review?(mjzffr)
Attachment #8970932 -
Flags: review?(mjzffr)
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8970929 [details] Bug 1456799 - [wdspec] Fix add cookie tests for invalid domain usage. https://reviewboard.mozilla.org/r/239680/#review245408
Attachment #8970929 -
Flags: review?(mjzffr) → review+
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8970930 [details] Bug 1456799 - [wdspec] Fix linter failures for add cookie tests. https://reviewboard.mozilla.org/r/239682/#review245410
Attachment #8970930 -
Flags: review?(mjzffr) → review+
Comment 7•6 years ago
|
||
mozreview-review |
Comment on attachment 8970931 [details] Bug 1456799 - [wdspec] Add cookie tests have to use a shared custom add_cookie command. https://reviewboard.mozilla.org/r/239684/#review245412
Attachment #8970931 -
Flags: review?(mjzffr) → review+
Comment 8•6 years ago
|
||
mozreview-review |
Comment on attachment 8970932 [details] Bug 1456799 - [wdspec] Use wdclient to get a named cookie in add cookie tests. https://reviewboard.mozilla.org/r/239686/#review245414
Attachment #8970932 -
Flags: review?(mjzffr) → review+
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cb1909841a5d [wdspec] Fix add cookie tests for invalid domain usage. r=maja_zf https://hg.mozilla.org/integration/autoland/rev/281208264c74 [wdspec] Fix linter failures for add cookie tests. r=maja_zf https://hg.mozilla.org/integration/autoland/rev/9d55d0203a2b [wdspec] Add cookie tests have to use a shared custom add_cookie command. r=maja_zf https://hg.mozilla.org/integration/autoland/rev/c07b1375c1c4 [wdspec] Use wdclient to get a named cookie in add cookie tests. r=maja_zf
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cb1909841a5d https://hg.mozilla.org/mozilla-central/rev/281208264c74 https://hg.mozilla.org/mozilla-central/rev/9d55d0203a2b https://hg.mozilla.org/mozilla-central/rev/c07b1375c1c4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10646 for changes under testing/web-platform/tests
Can't merge web-platform-tests PR due to failing upstream checks: Github PR https://github.com/w3c/web-platform-tests/pull/10646 * continuous-integration/travis-ci/pr (https://travis-ci.org/w3c/web-platform-tests/builds/371440175?utm_source=github_status&utm_medium=notification)
Upstream PR merged
You need to log in
before you can comment on or make changes to this bug.
Description
•