1456893 - factor DETH global binding out into a separate GlobalObjectBindable class

Status: RESOLVED DUPLICATE of bug 1862244

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Ben Kelly [:bkelly, not reviewing]]

In bug 1456466 I am adding a helper class called DOMMozPromiseRequestHolder that auto-disconnects MozPromise Thenables when the global is closed.  To do this its extending DETH even though its not really an event target.

This bug is to split the global binding logic out into a separate class so things like this helper class can use it without incurring all the DETH event listener baggage.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

I need to wait to do this until the tree thaws after the FF61 soft freeze.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

This would be nice code cleanup, but I did not get to it.  Sorry.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

This was addressed through the introduction of GlobalTeardownObserver as a new intermediate base-class in bug 1862244 by :saschanaz.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

I filed bug 1987818 to track updating DOMMozPromiseRequestHolder to use GlobalTeardownObserver since this bug presumably was going to do that but was only filed about extracting out what is now GlobalTeardownObserver.