Closed
Bug 1862244
Opened 2 years ago
Closed 2 years ago
Add a main thread shutdown observer similar to WorkerRef
Categories
(Core :: DOM: Streams, enhancement)
Core
DOM: Streams
Tracking
()
RESOLVED
FIXED
122 Branch
People
(Reporter: saschanaz, Assigned: saschanaz)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
|
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
|
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-esr115+
|
Details | Review |
... although it will not have the ability to delay the shutdown.
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
•
|
||
Some observation on the current 6 subscribers of DOM_WINDOW_DESTROYED_TOPIC:
- Most of the observers also subscribe _FROZEN_TOPIC too. Looks reasonable to me as pages behind bfcache probably should stop consuming network resource etc. Exceptions are nsTypeAheadFind which is not network related, and JSStreamConsumer which I don't really understand.
- BodyConsumer
- EventSource except it also subscribes to THAWED_TOPIC.
- Notification
- WebSocket
- Only some of them cares about workers.
- BodyConsumer
- JSStreamConsumer, somehow it has a special setup with WindowStreamOwner and WorkerStreamOwner. (TIL about JSStreamConsumer. It seems it's to consume Response but I don't immediately see the purpose 🤔)
Andrew, do you know whether there's any other mainthread shutdown observing way I should be aware of?
Flags: needinfo?(bugmail)
|
||
Updated•2 years ago
|
Attachment #9361251 -
Attachment description: WIP: Bug 1862244 - Add MainThreadShutdownObserver → Bug 1862244 - Add MainThreadShutdownObserver r=asuth
|
|
||
Updated•2 years ago
|
Attachment #9361251 -
Attachment description: Bug 1862244 - Add MainThreadShutdownObserver r=asuth → Bug 1862244 - Add WindowGlobalShutdownObserver r=asuth
|
|
||
Updated•2 years ago
|
Attachment #9361251 -
Attachment description: Bug 1862244 - Add WindowGlobalShutdownObserver r=asuth → Bug 1862244 - Add WindowGlobalTeardownObserver r=asuth
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
|
||
Updated•2 years ago
|
Attachment #9361251 -
Attachment is obsolete: true
|
|
||
Updated•2 years ago
|
Attachment #9363060 -
Attachment description: WIP: Bug 1862244 - Add GlobalTeardownHelper r=smaug → Bug 1862244 - Add GlobalTeardownHelper r=smaug
Pushed by krosylight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/36ae08176ef8
Add GlobalTeardownHelper r=smaug
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox122:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 122 Branch
|
||
Comment 6•2 years ago
|
||
Comment on attachment 9363060 [details]
Bug 1862244 - Add GlobalTeardownHelper r=smaug
Needed for bug 1849860. Approved for 121.0b4.
Attachment #9363060 -
Flags: approval-mozilla-beta+
|
|
||
Updated•2 years ago
|
status-firefox121:
--- → fixed
|
|
Assignee | |
Comment 8•2 years ago
|
||
ESR rebase
|
|
||
Updated•2 years ago
|
Attachment #9366333 -
Flags: approval-mozilla-esr115?
|
|
||
Comment 9•2 years ago
|
||
Comment on attachment 9366333 [details]
Bug 1862244 - Add GlobalTeardownHelper r=smaug
Approved for 115.6esr.
Attachment #9366333 -
Flags: approval-mozilla-esr115? → approval-mozilla-esr115+
|
||
Comment 10•2 years ago
|
||
| uplift | ||
|
|
||
Updated•2 years ago
|
status-firefox-esr115:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•