1456986 - Remove binding details from ServiceWorker::Inner::PostMessage()

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, enhancement, P2)

Description

[Ben Kelly [:bkelly, not reviewing]]

Currently we pass the global and jscontext down into ServiceWorker::Inner::PostMessage().  We need to keep these up in the binding layer and only pass portable types down into the Inner.  This probably means doing an IPC serialization of the structured cloneable transferable.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Make ServiceWorker::Inner::PostMessage() use StructuredCloneData. r=baku

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf523018335f702fef36bf60e7e47389c3ef7368

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Make ServiceWorker::Inner::PostMessage() use StructuredCloneData. r=baku

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6709635f7ed4ff81f5beb7f2248d327bf3f85062

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

I wrote bug 1458936 to make structured clone utilities easier here.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8972920 [details] [diff] [review]
Make ServiceWorker::Inner::PostMessage() use StructuredCloneData. r=baku

Andrea, in preparation of remoting the ServiceWorker binding layer across IPC to the parent process this patch makes PostMessage() immediately convert to StructuredCloneData instead of passing the js pointers down into the guts of SWM.

Note, there is some ugly code in ServiceWorkerPrivate to convert from the StructuredCloneData to a StructuredCloneHolder.  This is necessary because SCD uses non-threadsafe ref-counting internally.  I filed bug 1458936 to make this better in the future.

Comment 5

[Andrea Marchesini [:baku]]

Comment on attachment 8972920 [details] [diff] [review]
Make ServiceWorker::Inner::PostMessage() use StructuredCloneData. r=baku

Review of attachment 8972920 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/serviceworkers/ServiceWorker.cpp
@@ +16,5 @@
>  #include "mozilla/dom/ClientState.h"
>  #include "mozilla/dom/Promise.h"
>  #include "mozilla/dom/ServiceWorkerGlobalScopeBinding.h"
>  #include "mozilla/dom/WorkerPrivate.h"
> +#include "mozilla/dom/ipc/StructuredCloneData.h"

Ok, I still don't understand how sort 'subdir' headers in alphabetic order...

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/509957c7a9f9
Make ServiceWorker::Inner::PostMessage() use StructuredCloneData. r=baku

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/509957c7a9f9

Comment 8

[Ben Kelly [:bkelly, not reviewing]]

Backing out for various issues:

https://hg.mozilla.org/integration/mozilla-inbound/rev/7cd5006f1365420afb922ced1a1c07feaa27c951
https://hg.mozilla.org/releases/mozilla-beta/rev/10812be17bab3794c4f6d97b2128f6a0d8e156ea

Comment 9

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Make ServiceWorker::Inner::PostMessage() use StructuredCloneData. r=baku

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4df3b7c9f430af38e0561344781887b2c875d310

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/7cd5006f1365

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee57d9bde7cb
Make ServiceWorker::Inner::PostMessage() use StructuredCloneData. r=baku

Comment 12

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/ee57d9bde7cb