Closed
Bug 1457024
Opened 7 years ago
Closed 7 years ago
[Retention] WNP for 60
Categories
(www.mozilla.org :: Pages & Content, enhancement)
Tracking
(firefox60blocking fixed)
RESOLVED
FIXED
People
(Reporter: erenaud, Assigned: jpetto)
References
()
Details
Attachments
(4 files)
Jon - can you confirm that this is the template?
Also, could you please get a PR going with the added copy for the Focus content?
I verified these strings already exist/have been localized, as follows:
Firefox Focus -
https://pontoon.mozilla.org/de/mozillaorg/firefox/mobile.lang/?string=172975
Blocks ads with trackers. Automatically. Plus, it can even speed up page loading. Get the private browser that has your back.
https://pontoon.mozilla.org/fr/mozillaorg/firefox/mobile.lang/?string=172977
However, I can't readily find 'Learn More', so unless Peiying can locate where that may be more widely localized we will need to use 'See more', which is in mozillaorg/firefox/mobile.lang/?string=172975
I found Learn More, here, but it's only in a few locales . . .
https://pontoon.mozilla.org/fr/mozillaorg/firefox/retention/thank-you.lang/?string=171461
Also, I identified "fi" and "ja-JP-mac" as not being not being activated in /firefox/mobile, so those locales are in question
https://l10n.mozilla-community.org/langchecker/?locale=all&website=0&file=firefox/mobile.lang
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(pmo)
Flags: needinfo?(jon)
Reporter | ||
Comment 1•7 years ago
|
||
Devyani - please attach the update QR codes with new Adjust links.
1 for the Firefox mobile CTA
1 for the Firefox Focus CTA
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(dgupta)
Comment 2•7 years ago
|
||
@Eric, a few Learn more or Learn More in different files: https://transvision.mozfr.org/?recherche=Learn+more&repo=mozilla_org&sourcelocale=en-US&locale=de&search_type=strings_entities&entire_string=entire_string
Flags: needinfo?(pmo)
Reporter | ||
Comment 3•7 years ago
|
||
I found 'Learn More' in the main.lang file . . . https://pontoon.mozilla.org/fr/mozillaorg/main.lang/?search=Learn+More&string=8051
Peiying - can you please confirm this will work?
Reporter | ||
Comment 4•7 years ago
|
||
Flod - to assuage your concerns (hopefully):
We are only using strings that have already been localized, as noted in the initial description. Peiying reviewed the request is good with it, having conveyed that fact that a script can be run to update all the identified lang files.
Our only gap is that of the 'fi' locale, where the firefox/mobile page has not been localized, so we need to remove that from the list here - bug 1455010#c0 when submitting the final list to releng, please (I confirmed this as being acceptable w. the Retention team).
Please confer w. Peiying and let us know if you have any concerns.
Flags: needinfo?(francesco.lodolo)
Comment 5•7 years ago
|
||
@Eric, as mentioned on Slack, "Learn More" in shared file will be used, and no script is needed to leverage strings already exist in main.lang and download_buttons.lang files.
Comment 6•7 years ago
|
||
(In reply to Eric Renaud [:erenaud] from comment #4)
> We are only using strings that have already been localized, as noted in the
> initial description. Peiying reviewed the request is good with it, having
> conveyed that fact that a script can be run to update all the identified
> lang files.
I know you're the messenger here, but:
* I pointed out in 59 that we should stop doing this kind of moves so close to the deadline (in that case we took strings from other pages, and put together one).
* We all agreed that the content was final in the meeting where the schedule was defined.
If we keep accepting last minute changes of this size, nobody is going to fix the process causing them. But, clearly, it doesn't look my opinion count as a blocker either.
> Our only gap is that of the 'fi' locale, where the firefox/mobile page has
> not been localized, so we need to remove that from the list here - bug
> 1455010#c0 when submitting the final list to releng, please (I confirmed
> this as being acceptable w. the Retention team).
Finnish is not the only locale affected. That's because the assumption is based on a list that I didn't provide yet in bug 1455010.
List of locales that should be dropped: az, ca, fi, gl, is, pa-IN, ta
Flags: needinfo?(francesco.lodolo)
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jon
Flags: needinfo?(jon)
Reporter | ||
Comment 7•7 years ago
|
||
Source doc for new content - https://docs.google.com/spreadsheets/d/1FYPyIvVFtl-8VREZYWA5uTHHv0A1WFjSDhQhtoSLSOA/edit?ts=5ae04756#gid=2084839098
Reporter | ||
Comment 9•7 years ago
|
||
Adding dependency for zh-TW content update for 60 WNP - bug 1454084
Update content in the zh-TW version of the /whatsnew page w. Mobile CTA for Fx 60.0 (this template is hardcoded)
https://drive.google.com/drive/folders/1BeqZayGbkBy2fHupnWWp77sqa2a9Sxql?usp=sharing
Adding dependency for Indonesian content update (Rocket) for 60 WNP - bug 1455199
Update /whatsnew mobile CTA version - variation for Indonesia w. Rocket CTA for Fx 60.0 (this template is hardcoded)
Use version A (screenshot) as noted in the bug
- https://drive.google.com/drive/folders/1xobL6EKo8WIoEayFAgrxAfqjLA_mEmnq?usp=sharing
Reporter | ||
Comment 10•7 years ago
|
||
Brynne - Please confirm that these are the basket message ids to be used for the send to device widget in the /whatsnew page?
sms: `mobile-heartbeat`
email: `download-firefox-mobile-reco`
Please set a needinfo to :jpetto when you respond.
Thank you - Eric
Flags: needinfo?(bhaack)
Reporter | ||
Comment 11•7 years ago
|
||
Conditional content for Focus CTA - below denotes the placement, the string and where (lang file) the string has already been localized
Headline -
"FireFox Focus"
https://pontoon.mozilla.org/fr/mozillaorg/firefox/mobile.lang/?string=172975
Body -
"Blocks ads with trackers. Automatically. Plus, it can even speed up page loading. Get the private browser that has your back"
https://pontoon.mozilla.org/fr/mozillaorg/firefox/mobile.lang/?string=172977
CTA line below body -
"Scan the QR code to get started."
https://pontoon.mozilla.org/fr/mozillaorg/firefox/mobile.lang/?string=173031
Assignee | ||
Comment 12•7 years ago
|
||
Just verifying that the Body string in comment 11 [1] should not have a period at the end (even though the previous sentences *do* have punctuation).
[1] "Blocks ads with trackers. Automatically. Plus, it can even speed up page loading. Get the private browser that has your back"
Reporter | ||
Comment 13•7 years ago
|
||
Peter - we need Analytics input here - we need to measure how many people see each variation (capture clickthru rates).
Content states are:
1 - Default - user not logged into Fx Account is shown Fx Account CTA
2 - Conditional via UITour - user logged into Fx Account, no mobile devices detected, is shown Firefox Mobile CTA
3 - Conditional via UITour - user logged into Fx, mobile devices are detected, is shown Firefox Focus CTA
Please ping with any questions (best to set a needinfo to :jpetto)
Reporter | ||
Comment 15•7 years ago
|
||
(In reply to Jon Petto [:jpetto] from comment #12)
> Just verifying that the Body string in comment 11 [1] should not have a
> period at the end (even though the previous sentences *do* have punctuation).
>
> [1] "Blocks ads with trackers. Automatically. Plus, it can even speed up
> page loading. Get the private browser that has your back"
Yes - I noted that and corrected it in the spreadsheet. The string in use on /mobile/ does have that period (so we just go with that instead throwing a wrench).
Comment 16•7 years ago
|
||
(In reply to Eric Renaud [:erenaud] from comment #10)
> Brynne - Please confirm that these are the basket message ids to be used for
> the send to device widget in the /whatsnew page?
>
> sms: `mobile-heartbeat`
>
> email: `download-firefox-mobile-reco`
>
> Please set a needinfo to :jpetto when you respond.
>
> Thank you - Eric
Hi Eric - The Basket Message IDs being used for Whats New, are:
SMS: whatsnewfifty
Email: download-firefox-mobile-whatsnew
Let me know if you have other questions, or need anything else.
Brynne
Flags: needinfo?(bhaack) → needinfo?(jon)
Comment 17•7 years ago
|
||
Shortened Tracking link is here: https://mzl.la/2JwvrgL
Flags: needinfo?(dgupta)
Comment 18•7 years ago
|
||
Shortened Adjust Tracking Link: https://mzl.la/2HtC0UB
Comment 19•7 years ago
|
||
Hello Eric - Please see QR codes and shortened tracking links in comments 17 and 18 above. Let me know if there are any issues with these.
Flags: needinfo?(erenaud)
Comment 20•7 years ago
|
||
Here is a Sketch file with different states for all the different conditions: https://mozilla.app.box.com/folder/48947002379
ALL ASSETS ARE FPO, logos, app store buttons should come from moz.org stock, and the background is just the current CSS gradient w/o the tail layers. I spoke with Vince about this — the designs are not prescriptive, but meant to show what needs to be where. I know the team will apply some site-wide design standards to this so I expect layouts will shift a bit.
Flags: needinfo?(erenaud)
Comment 21•7 years ago
|
||
Assignee | ||
Comment 22•7 years ago
|
||
:hectorz - Can you chime in here in regards to QR codes and adjust/app/play store links for mozillaonline distributions?
This new /whatsnew page can display a QR code for Firefox Mobile *OR* Focus, and also has custom adjust.com links for Firefox Mobile and Focus. (adjust.com links redirect to either the App or Play store depending on the visitor's platform.)
This /whatsnew page will be shown to the locales listed in bug 1455010 comment 9[1]. zh-TW and id locales will be served custom templates, and should not impact anything here.
Thanks!
[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1455010#c9
Flags: needinfo?(jon) → needinfo?(bzhao)
Reporter | ||
Comment 23•7 years ago
|
||
Michele - who should we query to determine if the message ids (Brynne confirmed on the right ones to use) to be used in the send-to-device widget have the corresponding localized content for the 6 locales to which it will be shown?
Flags: needinfo?(mwarther)
Comment 24•7 years ago
|
||
Eric - Devanyi is the lead on this and can confirm which ones are active on Mozilla.org for mobile.
Flags: needinfo?(mwarther) → needinfo?(dgupta)
Comment 25•7 years ago
|
||
(In reply to Jon Petto [:jpetto] from comment #22)
> :hectorz - Can you chime in here in regards to QR codes and adjust/app/play
> store links for mozillaonline distributions?
>
> This new /whatsnew page can display a QR code for Firefox Mobile *OR* Focus,
> and also has custom adjust.com links for Firefox Mobile and Focus.
> (adjust.com links redirect to either the App or Play store depending on the
> visitor's platform.)
>
> This /whatsnew page will be shown to the locales listed in bug 1455010
> comment 9[1]. zh-TW and id locales will be served custom templates, and
> should not impact anything here.
>
> Thanks!
>
>
> [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1455010#c9
Hello :jpetto,
Beijing office serve customized builds of Firefox for Desktop/Android to users in China, and the majority of (> 99% I believe) them are using the zh-CN locale. We don't have a customized build of Focus (yet).
For this WNP 60 page, when using a MozillaOnline repack of Firefox for Desktop:
* FxA: Show iframe from https://accounts.firefox.com.cn/;
* Fx mobile: Show QR code from bug 1415544, use `settings.GOOGLE_PLAY_FIREFOX_LINK_MOZILLAONLINE` in the Google Play button;
* Focus: Nothing special for MozillaOnline for now.
I think you should:
* Drop the MozillaOnline QR code from Focus;
* Add a `data-mozillaonline-link` to Google Play button of Fx mobile.
Send-to-mobile widget doesn't work for MozillaOnline builds yet, but it's not a big deal as long as it's not enabled for zh-CN.
I somewhat assumed `alt_href` in `google_play_button` macro would only be used for apps other than Firefox for Android when I first created it in [1], maybe it's better to update the macro to accommodate the use of Adjust links, so that it correctly adds the `data-mozillaonline-link` attribute to a Google Play button for Fx mobile.
Thanks!
[1]: https://github.com/mozilla/bedrock/commit/34fd6737fed0573add39bf9ed0e56db90f3e5cf3
Flags: needinfo?(bzhao)
Comment 26•7 years ago
|
||
(In reply to Eric Renaud [:erenaud] from comment #23)
> Michele - who should we query to determine if the message ids (Brynne
> confirmed on the right ones to use) to be used in the send-to-device widget
> have the corresponding localized content for the 6 locales to which it will
> be shown?
@erenaud I just slacked you with a question in out whatsnew 60 channel, I'm happy to help, What exact information do you need for this? Thanks.
Flags: needinfo?(dgupta) → needinfo?(erenaud)
Reporter | ||
Comment 27•7 years ago
|
||
Brynne confirmed Emails are localized in: DE, EN, ES, FR, ID, PL, PT, RU, zh-TW (via Slack)
Devyani - please confirm the same for SMS in DE, EN, FR
Flags: needinfo?(erenaud) → needinfo?(dgupta)
Assignee | ||
Comment 29•7 years ago
|
||
Noting that comments 27 and 28 resolve the Send to Device questions. We are good there.
Reporter | ||
Comment 30•7 years ago
|
||
Noting that Brynne confirmed SMS message are in place for the basket ids and are sent to EN, de-DE, en-DE, fr-FR, and en-FR
Flags: needinfo?(erenaud)
Assignee | ||
Comment 31•7 years ago
|
||
Screenshots for all states:
1. Not signed in to Sync: https://screenshots.firefox.com/MyNdnXRd1Dbe0wf1/www-demo4.allizom.org
2. Signed in to Sync with no mobile devices setup:
a. Send to Device available: https://screenshots.firefox.com/9uccYlQlOkZtxVZR/localhost
b. Send to Device not available: https://screenshots.firefox.com/XzhR1TyKhfnkk6aa/localhost
3. Signed in to Sync with mobile devices setup: https://screenshots.firefox.com/7Xa07ZsgweziHf1d/localhost
Comment 32•7 years ago
|
||
Eric and John, Please see below the Adjust links with Apple iOS fallback links. Please note I am sharing 3 links here, Firefox, Focus and Klar. Klar has a seprate fallback link.
Firefox:https://mzl.la/2KtrdHM
Focus:https://mzl.la/2rhsI2T
Klar:https://mzl.la/2joPGS8
Comment 33•7 years ago
|
||
@jpetto - Can you please add these data attributes to the datalayer on page load (of every page if possible)?
'FxASegment': 'Not Logged in|Logged in|Multi-Desktop Sync|Desktop and Mobile Sync| Multi-Desktop and Mobile Sync|Not Firefox Desktop| unknown pre fx 31',
'FxAMultiDesktopSync': 'true|false| unknown pre Fx 31',//populate nothing for non fx desktop
'FxALogin': 'true|false|unknown pre Fx 31', //populate nothing for nonfx desktop
'FxAMobileSync': 'true|false|unknown pre Fx31',//populate nothing for non fx desktop
Flags: needinfo?(pgerman) → needinfo?(jon)
Reporter | ||
Comment 34•7 years ago
|
||
Noting Decision log items established in the QA meeting earlier today -
Proper fallback link on apple app store (on Focus CTA page)
Proper fallback link on apple app store (on Fx Mobile CTA page)
Devyani provided links in comment 32
When the account benefits page is live, the link in en-US WNP needs to be updated to point to that (Eric will reopen this bug).
Flags: needinfo?(erenaud)
Comment 35•7 years ago
|
||
Hello Eric and Jon,
Based on an error in the Focus Link before, I am re-sharing the 3 links again. The Focus Link works now as is should.
Firefox:https://mzl.la/2KtrdHM
Focus:https://mzl.la/2FBO0Oa
Klar:https://mzl.la/2joPGS8
Thanks,
Devyani
Comment 36•7 years ago
|
||
Hi Team,
As I investigated the introduction of a download for Firefox Focus I realized that this is the first time that we have a download button for Focus on the site.
Our current download button tagging solution doesn't support multiple products. As such, we won't simply be able to customize the data attributes on this one tile like it was a regular Firefox Download button (because it isn't).
If it is possible, we'll want to add a data attribute called data-download-product. As such the full compliment of data attributes for this button would be:
data-download-product="Focus"
data-download-os="Android|iOS"
data-download-version="android|ios"//This is not duplicate of data-download-os
data-download-language="<language>"
data-download-location="primary cta"
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(jon)
Assignee | ||
Comment 37•7 years ago
|
||
The page is complete and up on a demo:
https://www-demo4.allizom.org/firefox/60.0/whatsnew/
Note that because we are using UITour and FxA on a demo URL, testing requires a custom profile. See the pull request [1] for instructions on testing.
[1] https://github.com/mozilla/bedrock/pull/5607
Comment 38•7 years ago
|
||
:jpetto. Data attributes and data layer are populated as expected.
Tag management to pick up new data attributes is complete.
GA configurations are complete.
Reporting is still outstanding.
Comment 39•7 years ago
|
||
Hello,
I saw the ID whatsnew page bug has been resolved:
https://bugzilla.mozilla.org/show_bug.cgi?id=1455199
But I'm not sure if it's on track.
So I'm just putting a reminder here in case the ID whatsnew page missed the 60.0 train.
Thank you!
Updated•7 years ago
|
status-firefox60:
--- → affected
tracking-firefox60:
--- → blocking
Assignee | ||
Comment 40•7 years ago
|
||
:rfkelly -
If you have the time, can you confirm the FxA iframe implementation on the /whatsnew page for Fx60 is good to go? This is the query string we are using:
?action=email&utm_campaign=fxa-embedded-form&utm_medium=referral&utm_source=whatsnew&utm_content=fx-{{ version }}&entrypoint=whatsnew&service=sync&context=iframe&style=chromeless&haltAfterSignIn=true
Note that the iframe will only be shown to visitors who are not logged in to Sync. (Users who *are* logged in see other conditional content.)
The pull request [1] has more information. We are going to push this to production today to ensure we're ready for the Fx60 launch, but can update query param values at any time.
Thanks!
[1] https://github.com/mozilla/bedrock/pull/5607
Flags: needinfo?(rfkelly)
Comment 41•7 years ago
|
||
Thanks for the ping, this looks good to me. Shane, looping you in as well.
Flags: needinfo?(rfkelly) → needinfo?(stomlinson)
Comment 42•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/bedrock
https://github.com/mozilla/bedrock/commit/f09e98b6113b97b731fe3707263c8e0b9c66f3f5
[fix bug 1457024] Add /whatsnew view for Fx60.
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment 43•7 years ago
|
||
(In reply to Jon Petto [:jpetto] from comment #40)
> :rfkelly -
>
> If you have the time, can you confirm the FxA iframe implementation on the
> /whatsnew page for Fx60 is good to go? This is the query string we are using:
>
> ?action=email&utm_campaign=fxa-embedded-
> form&utm_medium=referral&utm_source=whatsnew&utm_content=fx-{{ version
> }}&entrypoint=whatsnew&service=sync&context=iframe&style=chromeless&haltAfter
> SignIn=true
:jpetto, can you change `context` from `iframe` to `fx_firstrun_v2`? We added
`fx_firstrun_v2` a while back to give you a couple of additional commands, `form_engaged`
and `navigated` to help your team keep track of those things. Plus, I'd like to
ditch support for `context=iframe` soon so that we have less code to maintain.
Flags: needinfo?(stomlinson) → needinfo?(jon)
Updated•7 years ago
|
Comment 44•7 years ago
|
||
Comment 45•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/bedrock
https://github.com/mozilla/bedrock/commit/7937e689a86c9ae3bd0ae34a12fc3ce8079a276b
[fix bug 1457024] Fixes for Fx60 WNP:
1. Update FxA iframe param
2. Use localized link for Fx accounts 'learn more' for non en-US
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(jon)
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(erenaud)
You need to log in
before you can comment on or make changes to this bug.
Description
•